New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801279 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Ignore or file bug for each errorprone warning

Project Member Reported by wnwen@chromium.org, Jan 11 2018

Issue description

Errorprone warnings are causing our builds to become very verbose, sometimes tens to hundreds of screens of warnings. This results in all the logs being ignored.

Warnings should be categorized in one of the two following buckets:

- To eventually be fixed, these have positive impact. These have bugs filed for them to be fixed and turned into errors for future reference.

- Others should be silenced, they have low impact and make our build logs very verbose, resulting in devs simply ignoring all of it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56cfc3f0c2d7a06c1d756ca8a8321db8fe7abb95

commit 56cfc3f0c2d7a06c1d756ca8a8321db8fe7abb95
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Jan 11 21:25:32 2018

Android: Turn off some errorprone warnings

Some warnings should eventually be fixed, they have positive impact.
These have bugs filed for them to be fixed and turned into errors for
future reference.

Other warnings should be silenced, they have low impact and make our
build logs very verbose, resulting in devs simply ignoring all of it.

The rest of the warnings will be sorted into one of the two previous
categories at some point. The goal is for all errorprone warnings to be
in one of the two above categories so that we greatly reduce the number
of inactionable and verbose log messages in our build.

BUG= 801279 

Change-Id: I82d3416996d5db811eceea68be40c5a159c7dfe7
Reviewed-on: https://chromium-review.googlesource.com/862323
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528758}
[modify] https://crrev.com/56cfc3f0c2d7a06c1d756ca8a8321db8fe7abb95/build/android/gyp/javac.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/350cb72476c884a0bfa6a14652bc85296bff0da8

commit 350cb72476c884a0bfa6a14652bc85296bff0da8
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Jan 18 18:54:11 2018

Android: Turn off more errorprone warnings

Turning off these warnings allow building chrome_java to at least be
without errorprone warnings.

BUG= 801279 

Change-Id: Ie5bbccc32076f69e82e29c5bcf1f1d9ce2b3754d
Reviewed-on: https://chromium-review.googlesource.com/867456
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530216}
[modify] https://crrev.com/350cb72476c884a0bfa6a14652bc85296bff0da8/build/android/gyp/javac.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84d6167fb11b8615e45778c0dc103bc9fe0b38c7

commit 84d6167fb11b8615e45778c0dc103bc9fe0b38c7
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Jan 22 15:24:49 2018

Android: Turn off all errorprone warnings

Turning off these warnings allow building "all" to at least be without
errorprone warnings. Some warnings may still be left, but those can be
added to javac.py later.

Bug:  801279 
Change-Id: I6e4de4b262a9c3e39a5dfe770277e0fac73a76ce
Reviewed-on: https://chromium-review.googlesource.com/875125
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530865}
[modify] https://crrev.com/84d6167fb11b8615e45778c0dc103bc9fe0b38c7/build/android/gyp/javac.py

Comment 4 by wnwen@chromium.org, Jan 22 2018

Status: Fixed (was: Assigned)

Sign in to add a comment