New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801268 link

Starred by 1 user
Status: Fixed
Owner:
█ rob.b...@samsung.com
Email to this user bounced
Closed: Mar 2018
Cc:
agrieve@chromium.org
█ nyquist@chromium.org
█ wnwen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Fix implicit casts by compound assignment in code

Project Member Reported by wnwen@chromium.org, Jan 11 2018 
1. Read http://errorprone.info/bugpattern/NarrowingCompoundAssignment
2. Remove 'NarrowingCompoundAssignment' suppression for errorprone.
3. Fix or suppress each instance in code.
4. Upgrade 'NarrowingCompoundAssignment' to errorprone error to prevent future regressions.

Comment 1 by rob.b...@samsung.com, Mar 8 2018

Owner: rob.b...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d

commit 96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d
Author: Rob Buis <rob.buis@samsung.com>
Date: Thu Mar 08 21:23:25 2018

Fix errorprone NarrowingCompoundAssignment warnings

Fix errorprone NarrowingCompoundAssignment warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/NarrowingCompoundAssignment

Bug:  801268 

Change-Id: Ief55318e789176288962359566d708af51c7c890
Reviewed-on: https://chromium-review.googlesource.com/953181
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#541888}
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/build/android/gyp/javac.py
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackScroller.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/chrome/android/java/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelper.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/BitmapUtils.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/chrome/android/java/src/org/chromium/chrome/browser/util/MathUtils.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/chrome/android/java/src/org/chromium/chrome/browser/util/ViewUtils.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/remoting/android/java/src/org/chromium/chromoting/SimulatedTouchInputStrategy.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/remoting/android/java/src/org/chromium/chromoting/jni/TouchEventData.java
[modify] https://crrev.com/96c7ab0153ae97a8d8e05949f36cd7bb8eedbf1d/ui/android/java/src/org/chromium/ui/UiUtils.java

Comment 3 by rob.b...@samsung.com, Mar 15 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment