sbirch@: should be bypass the FRE to let it shown? And if so, should we only shown the custom items or both predefined and custom items?

We recently change the action name of Browser Actions intent, then this makes Browser Actions would not be available before M64. M65 stable would be early March and considering the Android support release timeline, M65 is the time we should fix this.

We are OK to skip the FRE to show the dialog as long as the FRE is shown before Chrome proper is opened. This may be tricky for download though since that normally wouldn't bring up Chrome -- maybe we should open the link in Chrome to show the FRE if the user asks for it to be downloaded?

Can we mark BrowserActionActivity as disabled in the AndroidManifest and only mark it as enabled after the FRE is complete?

I realize there might be two problem for enable BrowserActionActivity after FRE is complete:
1. If Chrome has already passed FRE and we have this new update make then BrowserActionActivity disabled in AndroidManifest, there is no way to enable it?
2. Does Chrome has a callback when users manually clear the data? If not, if users clear Chrome data, FRE would be set while BrowserActionActivity is still available, that would cause the save problem we have now?

Another option is FRE does not abort BrowserActionActivity but if FRE is not completed, we don't show predefined items?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20fb835192b5eae97ebe1db1e19ab6a7475a29f7

commit 20fb835192b5eae97ebe1db1e19ab6a7475a29f7
Author: Lei Tian <ltian@chromium.org>
Date: Wed Jan 24 22:09:59 2018

Browser Actions would not show predefined items if FRE is not complete

BrowserActionActivity could be shown even FRE is not finished but if FRE
is not finished, predefined item would not shown. It only shows the
custom item which looks like fallback dialog.

Bug:  801264 
Change-Id: I1d723e413fa06a7cd28d897620ed22f986887a5f
Reviewed-on: https://chromium-review.googlesource.com/875190
Commit-Queue: Lei Tian <ltian@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531706}
[modify] https://crrev.com/20fb835192b5eae97ebe1db1e19ab6a7475a29f7/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
[modify] https://crrev.com/20fb835192b5eae97ebe1db1e19ab6a7475a29f7/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java
[modify] https://crrev.com/20fb835192b5eae97ebe1db1e19ab6a7475a29f7/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
[modify] https://crrev.com/20fb835192b5eae97ebe1db1e19ab6a7475a29f7/chrome/android/javatests/src/org/chromium/chrome/browser/browseractions/BrowserActionActivityTest.java

[Auto-generated comment by a script] We noticed that this issue is targeted for M-65; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-65 label, otherwise remove Merge-TBD label. Thanks.

Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Friendly reminder to please merge to M65 branch 3325 soon.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3d1ed32b709e704c72ea8985d7759dfdc98bf6a

commit f3d1ed32b709e704c72ea8985d7759dfdc98bf6a
Author: Lei Tian <ltian@chromium.org>
Date: Tue Jan 30 20:27:58 2018

Browser Actions would not show predefined items if FRE is not complete

BrowserActionActivity could be shown even FRE is not finished but if FRE
is not finished, predefined item would not shown. It only shows the
custom item which looks like fallback dialog.

Bug:  801264 
NOTRY=true
NOPRESUBMIT=true
TBR=ltian@chromium.org

(cherry picked from commit 20fb835192b5eae97ebe1db1e19ab6a7475a29f7)

Change-Id: I1d723e413fa06a7cd28d897620ed22f986887a5f
Original-Reviewed-on: https://chromium-review.googlesource.com/875190
Commit-Queue: Lei Tian <ltian@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531706}
Reviewed-on: https://chromium-review.googlesource.com/893424
Cr-Commit-Position: refs/branch-heads/3325@{#183}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/f3d1ed32b709e704c72ea8985d7759dfdc98bf6a/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
[modify] https://crrev.com/f3d1ed32b709e704c72ea8985d7759dfdc98bf6a/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java
[modify] https://crrev.com/f3d1ed32b709e704c72ea8985d7759dfdc98bf6a/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java
[modify] https://crrev.com/f3d1ed32b709e704c72ea8985d7759dfdc98bf6a/chrome/android/javatests/src/org/chromium/chrome/browser/browseractions/BrowserActionActivityTest.java