New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801256 link

Starred by 1 user
Status: Fixed
Owner:
mar...@mwiacek.com
Closed: Jan 2018
Cc:
agrieve@chromium.org
█ nyquist@chromium.org
█ wnwen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Fix/remove wrong parameter names comments in code

Project Member Reported by wnwen@chromium.org, Jan 11 2018 
We should not need parameter names comments, as Android Studio adds them in on the fly.

1. Read http://errorprone.info/bugpattern/ParameterName
2. Remove 'ParameterName' suppression for errorprone.
3. Fix or suppress each instance in code.
4. Upgrade 'ParameterName' to errorprone error to prevent future regressions.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b617025dcf1c85bf8d0b048a436213b8e6f6b6b

commit 9b617025dcf1c85bf8d0b048a436213b8e6f6b6b
Author: marcin <marcin@mwiacek.com>
Date: Tue Jan 23 15:39:33 2018

Remove ParameterName errorProne warning/disable hiding these warnings

Checked build for

chrome_public_apk
chrome_public_test_apk
content_shell_apk
content_shell_test_apk
webview_instrumentation_apk
webview_instrumentation_test_apk

BUG= 801256 

Change-Id: I6425593b8037c2d3d4b64c564a8dc77f896c3ef8
Reviewed-on: https://chromium-review.googlesource.com/878864
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#531245}
[modify] https://crrev.com/9b617025dcf1c85bf8d0b048a436213b8e6f6b6b/build/android/gyp/javac.py
[modify] https://crrev.com/9b617025dcf1c85bf8d0b048a436213b8e6f6b6b/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditorPreference.java
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/095cd3d1f6db28683d7379834d5b7663f385a128

commit 095cd3d1f6db28683d7379834d5b7663f385a128
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Jan 29 23:40:08 2018

Android: Raise ParameterName to errorprone error

This warnings should always be fixed in new code.

Bug:  801256 
Change-Id: I6089a070efc7a5dfa276417f6035b3109e5dc565
Reviewed-on: https://chromium-review.googlesource.com/891483
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532659}
[modify] https://crrev.com/095cd3d1f6db28683d7379834d5b7663f385a128/build/android/gyp/javac.py

Comment 3 by wnwen@chromium.org, Jan 31 2018

Cc: -wnwen@chromium.org mar...@mwiacek.com
Owner: wnwen@chromium.org
Status: Fixed (was: Available)

Comment 4 by wnwen@chromium.org, Jan 31 2018

Cc: -mar...@mwiacek.com wnwen@chromium.org
Owner: mar...@mwiacek.com
Switching to marcin@ as owner since he landed the original fix.
►

Sign in to add a comment