New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801253 link

Starred by 1 user
Status: Fixed
Owner:
█ rob.b...@samsung.com
Email to this user bounced
Closed: Mar 2018
Cc:
agrieve@chromium.org
█ nyquist@chromium.org
█ wnwen@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Fix using same name as java.lang in code

Project Member Reported by wnwen@chromium.org, Jan 11 2018 
1. Read http://errorprone.info/bugpattern/JavaLangClash
2. Remove 'JavaLangClash' suppression for errorprone.
3. Fix or suppress each instance in code.
4. Upgrade 'JavaLangClash' to errorprone error to prevent future regressions.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc1712d681a6307c7ed371328855f2b38824abb2

commit cc1712d681a6307c7ed371328855f2b38824abb2
Author: Rob Buis <rob.buis@samsung.com>
Date: Fri Feb 23 21:18:33 2018

Fix errorprone JavaLangClash warnings

Fix errorprone JavaLangClash warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/JavaLangClash

Bug:  801253 
Change-Id: I5958e0e1c3d15e637b04c12e2810dee0cfb16cfc
Reviewed-on: https://chromium-review.googlesource.com/929755
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#538903}
[modify] https://crrev.com/cc1712d681a6307c7ed371328855f2b38824abb2/build/android/gyp/javac.py
[modify] https://crrev.com/cc1712d681a6307c7ed371328855f2b38824abb2/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java
[modify] https://crrev.com/cc1712d681a6307c7ed371328855f2b38824abb2/remoting/android/java/src/org/chromium/chromoting/HostListManager.java
[modify] https://crrev.com/cc1712d681a6307c7ed371328855f2b38824abb2/remoting/android/java/src/org/chromium/chromoting/base/OAuthTokenFetcher.java
[modify] https://crrev.com/cc1712d681a6307c7ed371328855f2b38824abb2/remoting/android/java/src/org/chromium/chromoting/jni/ConnectionListener.java

Comment 2 by rob.b...@samsung.com, Mar 8 2018

Status: Fixed (was: Available)
Fixed.

Comment 3 by wnwen@chromium.org, Mar 8 2018

Owner: rob.b...@samsung.com
►

Sign in to add a comment