[MD Extensions] Respect ProfileInfo#isSupervised boolean |
||||||
Issue descriptionCurrent UI ignores the isSupervised boolean [1]. The old UI did the following when the boolean was true (see screenshots): 1) Showed a yellow banner at the top 2) Disabled the "developer mode" checkbox 3) Hid the "Get more extensions" link at the bottom of the page [1] https://cs.chromium.org/chromium/src/chrome/common/extensions/api/developer_private.idl?l=236
,
Jan 11 2018
,
Jan 11 2018
How do we want to display this text? AFAIK, we don't have any yellow banners across the top in MD.
,
Jan 11 2018
For the banner text we probably need some suggestion from UX. Adding bettes@. The other two changes are fairly straight-forward. @bettes: Any suggestions for the yellow-banner equivalent in MD Extensions?
,
Jan 12 2018
Starting on items 2 and 3 from initial post.
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d commit 9c4b487b9b7713f6fd3fe4016a6938de9b12a33d Author: dpapad <dpapad@chromium.org> Date: Fri Jan 12 22:45:36 2018 MD Extensions: Respect ProfileInfo#isSupervised boolean. When true, disable dev mode checkbox, and stop displaying a link to the CWS. This matches the old UI's behavior. Bug: 801233 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I50d49aea0672429c8aa53c75493746adf7ff8abf Reviewed-on: https://chromium-review.googlesource.com/865156 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#529095} [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/browser/resources/md_extensions/manager.html [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/browser/resources/md_extensions/manager.js [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/browser/resources/md_extensions/sidebar.html [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/browser/resources/md_extensions/sidebar.js [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/browser/resources/md_extensions/toolbar.html [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/browser/resources/md_extensions/toolbar.js [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/test/data/webui/extensions/cr_extensions_browsertest.js [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/test/data/webui/extensions/extension_sidebar_test.js [modify] https://crrev.com/9c4b487b9b7713f6fd3fe4016a6938de9b12a33d/chrome/test/data/webui/extensions/extension_toolbar_test.js
,
Jan 13 2018
The most important parts of this bug have been fixed. Only the equivalent of the yellow banner is missing. Leaving it open, but not a blocker anymore.
,
Feb 12 2018
@namratakannan: See the 2nd screenshot from the old UI on the bug description. We are missing an equivalent for the new UI. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Jan 11 2018