New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801226 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

32-bit overflow in chrome://tracing for private memory footprint column

Project Member Reported by erikc...@chromium.org, Jan 11 2018

Issue description

Labels: -Pri-3 Pri-1
Ping - several users have been uploading bloated memory-infra traces and it's impossible to tell how much memory the browser is using. Could someone take a look a this?

Comment 2 by lalitm@chromium.org, Jan 17 2018

Owner: lalitm@chromium.org
Status: Started (was: Untriaged)
Lookiing into it!
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03639ba0fb7568d8f0e7b57dee164e22add675b6

commit 03639ba0fb7568d8f0e7b57dee164e22add675b6
Author: Lalit Maganti <lalitm@chromium.org>
Date: Wed Jan 17 13:16:55 2018

memory-infra: fix overflows adding sizes to trace

We need to cast to a 64bit integer before converting from KB back to
bytes to prevent overflow.

Bug:  801226 
Change-Id: I54e302d6d6a7b77bce038e67b5e77a5397c111f2
Reviewed-on: https://chromium-review.googlesource.com/870352
Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529722}
[modify] https://crrev.com/03639ba0fb7568d8f0e7b57dee164e22add675b6/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc

Comment 4 by lalitm@chromium.org, Jan 17 2018

Status: Fixed (was: Started)
That should fix things!
Thanks!

Sign in to add a comment