32-bit overflow in chrome://tracing for private memory footprint column |
|||
Issue descriptionSee the end of the follinwing post: https://bugs.chromium.org/p/chromium/issues/detail?id=798234#c9
,
Jan 17 2018
Lookiing into it!
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03639ba0fb7568d8f0e7b57dee164e22add675b6 commit 03639ba0fb7568d8f0e7b57dee164e22add675b6 Author: Lalit Maganti <lalitm@chromium.org> Date: Wed Jan 17 13:16:55 2018 memory-infra: fix overflows adding sizes to trace We need to cast to a 64bit integer before converting from KB back to bytes to prevent overflow. Bug: 801226 Change-Id: I54e302d6d6a7b77bce038e67b5e77a5397c111f2 Reviewed-on: https://chromium-review.googlesource.com/870352 Reviewed-by: Hector Dearman <hjd@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#529722} [modify] https://crrev.com/03639ba0fb7568d8f0e7b57dee164e22add675b6/services/resource_coordinator/public/cpp/memory_instrumentation/tracing_observer.cc
,
Jan 17 2018
That should fix things!
,
Jan 17 2018
Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by erikc...@chromium.org
, Jan 17 2018