The fix for Issue 857512 made having origin and tag fields in RegeneratedNotificationInfo unnecessary. We can safely get rid of them. Relevant code is in: chrome/browser/notifications/notification_platform_bridge_android.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/832946ed5eed7db6479d288b9afbe16febcdabbf commit 832946ed5eed7db6479d288b9afbe16febcdabbf Author: Mugdha Lakhani <nator@chromium.org> Date: Wed Jan 24 11:01:44 2018 [Android Notifications] Remove unused fields Remove origin and tag fields from various functions since they're no longer used. Bug: 801221 , 801535 Change-Id: I0b105acbf48cd3097b96ab40358dbec7ca0ec1fc Reviewed-on: https://chromium-review.googlesource.com/879202 Reviewed-by: Anita Woodruff <awdf@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#531497} [modify] https://crrev.com/832946ed5eed7db6479d288b9afbe16febcdabbf/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java [modify] https://crrev.com/832946ed5eed7db6479d288b9afbe16febcdabbf/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationJobService.java [modify] https://crrev.com/832946ed5eed7db6479d288b9afbe16febcdabbf/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java [modify] https://crrev.com/832946ed5eed7db6479d288b9afbe16febcdabbf/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationService.java [modify] https://crrev.com/832946ed5eed7db6479d288b9afbe16febcdabbf/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridgeIntentTest.java [modify] https://crrev.com/832946ed5eed7db6479d288b9afbe16febcdabbf/chrome/browser/notifications/notification_platform_bridge_android.cc [modify] https://crrev.com/832946ed5eed7db6479d288b9afbe16febcdabbf/chrome/browser/notifications/notification_platform_bridge_android.h
Comment 1 by na...@chromium.org
, Jan 15 2018Status: Assigned (was: Untriaged)