possible_browser.Create should only receive browser_options |
||||
Issue description
For all platforms it is currently defined:
def possible_browser.Create(finder_options)
but what they all actually need is just the browser_options.
To further demarcate the separation between general (telemetry) and browser options, let's make this method receive the browser options only.
This will also help simplify some code for the refactor in issue 784319 .
,
Jan 11 2018
We set finder options and browser options through this wrapper in chromeos: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/common_lib/cros/chrome.py?l=123-124 The easiest way to verify that you haven't broken anything is to run cros_run_vm_test from the simple chrome SDK shell. This runs a quick sanity test that invokes chrome.py. Let me know if you have any problems with this.
,
Jan 11 2018
I can take this bug if you need a hand, Juan
,
Jan 12 2018
It's blocking the rest of my refactor, so I'll get to it now.
,
Jan 12 2018
And now I feel how all of this is pointless: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_options.py?rcl=30e5a9f19de9cff42ee5ff8b5d9a4be5546e3588&l=318 sigh :( Anyway, I'll pretend I didn't see that line now and file a separate bug for that.
,
Jan 12 2018
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||
►
Sign in to add a comment |
||||
Comment 1 by perezju@chromium.org
, Jan 11 2018