New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801208 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug


Participants' hotlists:
ErrorProne-Fixes


Sign in to add a comment

Fix floating point literals in code

Project Member Reported by wnwen@chromium.org, Jan 11 2018

Issue description

1. Read http://errorprone.info/bugpattern/FloatingPointLiteralPrecision
2. Remove 'FloatingPointLiteralPrecision' suppression for errorprone.
3. Fix literals in code.
4. Upgrade 'FloatingPointLiteralPrecision' to errorprone error to prevent future regressions.
 
Owner: rob.b...@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67ea97d0f3ef633b4bf9d5ab735941a92d5f9065

commit 67ea97d0f3ef633b4bf9d5ab735941a92d5f9065
Author: Rob Buis <rob.buis@samsung.com>
Date: Fri Feb 09 15:51:09 2018

Fix errorprone FloatingPointLiteralPrecision warnings

Fix errorprone FloatingPointLiteralPrecision warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/FloatingPointLiteralPrecision

Bug:  801208 

Change-Id: Ic0e574024cc5a6eeb71f9def61103f7a3c58cb90
Reviewed-on: https://chromium-review.googlesource.com/909069
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#535722}
[modify] https://crrev.com/67ea97d0f3ef633b4bf9d5ab735941a92d5f9065/build/android/gyp/javac.py
[modify] https://crrev.com/67ea97d0f3ef633b4bf9d5ab735941a92d5f9065/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/stack/StackScroller.java
[modify] https://crrev.com/67ea97d0f3ef633b4bf9d5ab735941a92d5f9065/third_party/android_data_chart/java/src/org/chromium/third_party/android/datausagechart/ChartDataUsageView.java

Status: Fixed (was: Assigned)

Sign in to add a comment