Omnibox clear button is absent in RTL |
||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): ToT iOS Version: 11 Device: iPhone Steps to reproduce: 1. Set iOS device language to Hebrew 2. Tap on Omnibox 3. Type something Observed behavior: Clear button is absent Expected behavior: Clear button should be present
,
Jan 18 2018
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bf7c55b936906dd57f6bdd952f422afb9b38ce8 commit 3bf7c55b936906dd57f6bdd952f422afb9b38ce8 Author: stkhapugin@chromium.org <stkhapugin@chromium.org> Date: Mon Jan 22 18:24:49 2018 Fix a bug where the clear button in omnibox doesn't appear in RTL. The bug comes from a change in animation logic that didn't account for RTL, where leftView becomes rightView. The solution is to conditionally animate the correct view. Bug: 801194 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20aad960585ae196289ba0a12c58e04c16c9e022 Reviewed-on: https://chromium-review.googlesource.com/873914 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530915} [modify] https://crrev.com/3bf7c55b936906dd57f6bdd952f422afb9b38ce8/ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm
,
Jan 23 2018
,
Jan 30 2018
Verified on 66.0.3335.0 Canary on iPhone 8(iOS 11.2.5) and iPhone 8plus(iOS 11.3 beta) Omnibox clear text button is now displayed in RTL Link to video: https://drive.google.com/file/d/1zaMfsO55uTw-ViOUGKhf9qnYvecbStQm/view?usp=sharing |
||||
►
Sign in to add a comment |
||||
Comment 1 by huangml@chromium.org
, Jan 11 2018Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)