New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801189 link

Starred by 1 user
Status: Fixed
Owner:
agrieve@chromium.org
Closed: Jan 2018
Cc:
█ ltian@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add support for ${applicationId} for merged manifests

Project Member Reported by agrieve@chromium.org, Jan 11 2018 
Manifest merger will substitute this keyword with the apk's applicationId. This already works when used directly in an apk's AndroidManifest.xml. 

However, when ${applicationId} is used in an AndroidManifest.xml provided to an android_resources(), then process_resources.py fails:

AndroidManifest.xml:20: Tag <provider> attribute authorities has invalid character '$'.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f93bff15048f823e4c771d4421c2d72ca6d4df2

commit 3f93bff15048f823e4c771d4421c2d72ca6d4df2
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Jan 11 18:21:36 2018

Android: Allow library AndroidManifest to use ${applicationId}

The fix here is to just always pass the dummy manifest to aapt when
generating R.java files.

Bug:  801189 
Change-Id: Iee54bf45ea32bf163fae1056d7694666434d8b93
Reviewed-on: https://chromium-review.googlesource.com/861664
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528672}
[modify] https://crrev.com/3f93bff15048f823e4c771d4421c2d72ca6d4df2/build/android/gyp/process_resources.py
[modify] https://crrev.com/3f93bff15048f823e4c771d4421c2d72ca6d4df2/build/config/android/internal_rules.gni
[modify] https://crrev.com/3f93bff15048f823e4c771d4421c2d72ca6d4df2/build/config/android/rules.gni

Comment 2 by agrieve@chromium.org, Jan 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment