New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 801184 link

Starred by 1 user
Status: Fixed
Owner:
engedy@chromium.org
Closed: Jan 2018
Cc:
altimin@chromium.org
█ kraynov@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

RenderViewTest::TearDown() doesn't close JS-created views

Project Member Reported by kraynov@chromium.org, Jan 11 2018 
Browser test RenderFrameRemoteInterfacesTest.MainFrameOfOpenedWindowAtFirstCommittedLoad creates 3 new web views (windows) but test's TearDown() doesn't clean them up. So their WebFrameSchedulerImpl-s not getting destructed during shutdown procedure.

engedy@ could you take a look please?
(since you did relevant changes here https://chromium-review.googlesource.com/814994)
Thanks!
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f197c1c2b441da15274e2c17a928d7760b0bb260

commit f197c1c2b441da15274e2c17a928d7760b0bb260
Author: Balazs Engedy <engedy@chromium.org>
Date: Tue Jan 16 19:32:37 2018

Make RenderViewTests clean up all RenderViews.

As of crrev.com/c/814994/, the RenderViewTest harness gives tests the
ability to open additional windows, but previously RenderViewTest::TearDown
did not clean up these additional windows, so their WebFrameSchedulerImpls
were not getting destructed during shutdown.

RenderViewTest::TearDown now sends a ViewMsg_Close to all open views.

Bug:  801184 
Change-Id: Ibe153b1946bd04c2004904b6df978142be0f7b22
Reviewed-on: https://chromium-review.googlesource.com/866771
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529489}
[modify] https://crrev.com/f197c1c2b441da15274e2c17a928d7760b0bb260/content/public/test/render_view_test.cc

Comment 2 by engedy@chromium.org, Jan 16 2018

Status: Fixed (was: Assigned)
This should be fixed. I'm not quite sure how the consequences of this bug had manifested, could you guys please check and either flip the bug to verified or reopen?
►

Sign in to add a comment