New issue
Advanced search Search tips

Issue 801145 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Adaptive Toolbar: Add EarlGrey tests

Project Member Reported by gambard@chromium.org, Jan 11 2018

Issue description

Earl Grey tests should be added to prevent regression on the Adaptive toolbar.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e14c8fe74f35a3ce00768292531ab81fd6102fb

commit 0e14c8fe74f35a3ce00768292531ab81fd6102fb
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Jan 12 11:38:10 2018

Add util to check AdaptiveToolbar flag

This CL adds a until to check if the AdaptiveToolbar is enabled or not.
It will allow the test to change the hooks and be able to force the
adaptive toolbar.

Bug:  801145 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5dd4a8615902ee1da06d2639d0daef864e168a9f
Reviewed-on: https://chromium-review.googlesource.com/860008
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528926}
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/app/tests_fake_hook.mm
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/app/tests_hook.h
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.h
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/browser/ui/toolbar/public/toolbar_controller_base_feature.mm
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/browser/ui/toolbar/toolbar_private_base_feature.h
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/browser/ui/toolbar/toolbar_private_base_feature.mm
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/browser/ui/ui_util.h
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/browser/ui/ui_util.mm
[modify] https://crrev.com/0e14c8fe74f35a3ce00768292531ab81fd6102fb/ios/chrome/test/earl_grey/eg_tests_hook.mm

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b77909c7e9a0574db339411c05158ed0756655ac

commit b77909c7e9a0574db339411c05158ed0756655ac
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Jan 15 10:46:06 2018

Add test suite for the adaptive toolbar

This CL adds a simple test for the adaptive toolbar, passing only with
the adaptive toolbar.
It makes sure that the app can still start with the flag enabled, and
that the flag is enabling the toolbar.

It uses the test hooks to make sure the flag is enabled for this test.

Bug:  801145 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1ec3c85e5fdbeade51979386ac2c5dd1f997a34a
Reviewed-on: https://chromium-review.googlesource.com/860009
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529242}
[modify] https://crrev.com/b77909c7e9a0574db339411c05158ed0756655ac/ios/build/bots/tests/eg_tests.json
[modify] https://crrev.com/b77909c7e9a0574db339411c05158ed0756655ac/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn
[add] https://crrev.com/b77909c7e9a0574db339411c05158ed0756655ac/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_eg_tests_hook.mm
[add] https://crrev.com/b77909c7e9a0574db339411c05158ed0756655ac/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_egtest.mm
[modify] https://crrev.com/b77909c7e9a0574db339411c05158ed0756655ac/ios/chrome/test/earl_grey/BUILD.gn
[modify] https://crrev.com/b77909c7e9a0574db339411c05158ed0756655ac/ios/chrome/test/earl_grey/chrome_ios_eg_test.gni
[modify] https://crrev.com/b77909c7e9a0574db339411c05158ed0756655ac/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/b77909c7e9a0574db339411c05158ed0756655ac/testing/buildbot/manage.py

Status: WontFix (was: Assigned)
Tracked elsewhere.

Sign in to add a comment