New issue
Advanced search Search tips

Issue 801123 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK failure in LayoutScrollbarPart::marginTop()

Project Member Reported by tmonius...@opera.com, Jan 11 2018

Issue description

Chrome Version: Version 65.0.3318.0 (Developer Build) (64-bit)
OS: Win7

What steps will reproduce the problem?
(1) Set HDPI scale to 125% in system settings.
(2) Launch Chromium build with DCHECKs enabled.
(3) Open web page that causes crash (minimal test case in attachment).

What happens instead?
Page crashes on DCHECK failure.

 
crash.html
286 bytes View Download
Owner: tmonius...@opera.com

Comment 2 by bokan@chromium.org, Jan 18 2018

Cc: bokan@chromium.org chaopeng@chromium.org
Status: Assigned (was: Untriaged)
Reproduced on Windows in ToT. Couldn't get it to crash on Linux. Unfortunately, I couldn't get a stacktrace out of it quickly (not a native Win developer...)

tmoniuszko@, are you actively working on this? Could you paste the DCHECK and stack trace? Let me know if you need help, both chaopeng@ and I are familiar with these parts.
Yes, the fix is in review already:
https://chromium-review.googlesource.com/c/chromium/src/+/860929
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0317a349a1796af50089d4b4dcacad1f133db1e5

commit 0317a349a1796af50089d4b4dcacad1f133db1e5
Author: Tomasz Moniuszko <tmoniuszko@opera.com>
Date: Mon Jan 22 16:50:01 2018

Make sure LayoutScrollbarPart margins are integers

Bug:  801123 
Change-Id: I875cd6431b9ac5e9cded7ab947242d451e889d04
Reviewed-on: https://chromium-review.googlesource.com/860929
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Cr-Commit-Position: refs/heads/master@{#530885}
[modify] https://crrev.com/0317a349a1796af50089d4b4dcacad1f133db1e5/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp
[modify] https://crrev.com/0317a349a1796af50089d4b4dcacad1f133db1e5/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment