Issue metadata
Sign in to add a comment
|
7.7% regression in smoothness.gpu_rasterization.tough_path_rendering_cases at 526690:526811 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 11 2018
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8957696314888968752
,
Jan 11 2018
=== BISECT JOB RESULTS === NO Perf regression found Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : smoothness.gpu_rasterization.tough_path_rendering_cases Metric : frame_times/MotionMark_Canvas_Fill_Shapes Revision Result N chromium@526689 90.4592 +- 3.46709 21 good chromium@526811 90.4691 +- 3.12054 21 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=MotionMark.Canvas.Fill.Shapes smoothness.gpu_rasterization.tough_path_rendering_cases More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8957696314888968752 For feedback, file a bug with component Speed>Bisection
,
Jan 25 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/1199a3c2840000
,
Jan 25 2018
Kicked off another bisect with wider range.
,
Jan 26 2018
📍 Found significant differences after each of 3 commits. https://pinpoint-dot-chromeperf.appspot.com/job/1199a3c2840000 WebVTT line, position and size cue properties stored as double By k2.nagaraju@samsung.com · Tue Jan 02 13:11:56 2018 chromium @ fbdca255c3f886b43912e28e012e016334a8853c Add include guards to highcontrast_classifier.h By bratell@opera.com · Tue Jan 02 14:12:24 2018 chromium @ c6e321c6527e02f4f0a3f1b26b1acfecf44a814c Enable new edge inversion handling in Skia. By senorblanco@chromium.org · Tue Jan 02 17:16:48 2018 chromium @ e4d6d0b50ec2e40aabe6a8c9928f512101771bb1 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 27 2018
Looks like the first two commits are because there was a fluke in the build (crbug.com/806052). It's really the last one. Enable new edge inversion handling in Skia. By senorblanco@chromium.org · Tue Jan 02 17:16:48 2018 chromium @ e4d6d0b50ec2e40aabe6a8c9928f512101771bb1
,
Jan 27 2018
Unfortunately, I think this is a regression we're going to have to live with. My change addressed some pretty serious artifacts, and some performance regression is expected. We may be able to make that back with future optimizations, but I don't think we can go back on correctness at this point. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 11 2018