New issue
Advanced search Search tips

Issue 801102 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jan 2018
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Adaptive Toolbar: Fix the location bar view -set

Project Member Reported by gambard@chromium.org, Jan 11 2018 
The application is crashing when launching it with the adaptive toolbar flag enabled.
It is because the LocationBarView is added and constrained to the container while it is nil.

Checks should be added to prevent that.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e9c8d2ad8d8db72beee72af72abbc66300660aa

commit 1e9c8d2ad8d8db72beee72af72abbc66300660aa
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jan 11 12:12:07 2018

Fix the setup of LocationBarView

When setting the LocationBarView in the ToolbarView, it should be added
to the view hierarchy only if the container exists.
Also, the container should add and constrain the LocationBarView only
if it exists.

Bug:  801102 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6f78827f75c65b919222bbc45e56dccf9a14d6d6
Reviewed-on: https://chromium-review.googlesource.com/861627
Commit-Queue: Louis Romero <lpromero@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528603}
[modify] https://crrev.com/1e9c8d2ad8d8db72beee72af72abbc66300660aa/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm

Comment 2 by gambard@chromium.org, Jan 11 2018

Status: fixed (was: Assigned)
►

Sign in to add a comment