Regression:Spacing issue is observed for text after adding new folder in bookmark overlay.
Reported by
vku...@etouch.net,
Jan 11 2018
|
|||||||
Issue descriptionChrome Version:65.0.3318.0 (Official Build)Revision 193c7425ab494d87b07d70a1df512d58fcd58b58-refs/heads/master@{#528541} (64 Bit) OS:Mac OS X(10.12.6,10.13.1,10.13.3) What steps will reproduce the problem? (1)Launch chrome and right click on bookmark bar select "Add folder" (2)Click on 'New folder' and observe the text. Actual: Spacing issue is observed for text after adding new folder in bookmark overlay. Expected: No such spacing issue should be seen for text after adding new folder in bookmark overlay. This is a regression issue broken in 'M65' and below is the manual bisect info Good Build: 65.0.3315.0(Revision:527553) Bad Build: 65.0.3316.0(Revision:527861) Note: Issue not seen on Windows (7,8,8.1,10),Linux (14.04 LTS) OS.
,
Jan 11 2018
,
Jan 16 2018
The behavior in the "actual" video looks like the behavior before <https://chromium-review.googlesource.com/c/chromium/src/+/852377>, but that CL landed 3 days before this bug was filed, so I'm a bit puzzled. Reporter, can you re-test this please?
,
Jan 17 2018
With response to comment #3: Rechecked again and above issue is still reproducible on latest canary version 65.0.3322.3(Official Build) on Mac OS X(10.12.6,10.13.1,10.13.3),Win(7,8,8.1,10) & Linux(14.04 LTS) OS as well. Please refer attached screen-cast.
,
Jan 17 2018
Ah, okay, I see what the issue is. Here's the fix: <https://chromium-review.googlesource.com/c/chromium/src/+/870751>
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f81dbbb30c4b054059502682325551d278b251be commit f81dbbb30c4b054059502682325551d278b251be Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Jan 17 20:35:00 2018 views: use interior padding in treeview edit field In f1b8b41f, TreeView's Textfield for editing lost the default Harmony focus ring and gained a fixed 1pt border. However, that change lost the interior padding on the Textfield, so the text runs directly into the border ring. Bug: 801096 Change-Id: Ic078c3ae17964c7929e903f2e6665303be1188ad Reviewed-on: https://chromium-review.googlesource.com/870751 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#529861} [modify] https://crrev.com/f81dbbb30c4b054059502682325551d278b251be/ui/views/controls/tree/tree_view.cc
,
Jan 17 2018
,
Jan 18 2018
Update : Verified this issue on Windows (7,8,8.1,10),Mac OS(10.12.6,10.13.1,10.13.3)& Linux (14.04 LTS) OS with latest canary version #65.0.3324.0(Official build) and the issue is fixed.Kindly refer attached screen-cast. Thank you!
,
Jan 18 2018
,
Feb 2 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vku...@etouch.net
, Jan 11 2018Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)