New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801096 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Spacing issue is observed for text after adding new folder in bookmark overlay.

Reported by vku...@etouch.net, Jan 11 2018

Issue description

Chrome Version:65.0.3318.0 (Official Build)Revision 193c7425ab494d87b07d70a1df512d58fcd58b58-refs/heads/master@{#528541} (64 Bit)
OS:Mac OS X(10.12.6,10.13.1,10.13.3)

What steps will reproduce the problem?
(1)Launch chrome and right click on bookmark bar  select "Add folder"
(2)Click on 'New folder' and observe the text.

Actual: Spacing issue is observed for text after adding new folder in bookmark overlay.

Expected: No such spacing issue should be seen for text after adding new folder in bookmark overlay.

This is a regression issue broken in 'M65' and below is the manual bisect info
Good Build: 65.0.3315.0(Revision:527553)
Bad Build:  65.0.3316.0(Revision:527861) 

Note: Issue not seen on Windows (7,8,8.1,10),Linux (14.04 LTS) OS.
 
Actual_Result.mov
1.6 MB Download
Expected_Result.mov
1.1 MB Download

Comment 1 by vku...@etouch.net, Jan 11 2018

Labels: hasbisect-per-revision
Owner: ellyjo...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 527616 (known good), but no later than 527617 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/e50425bed92b9a78403abfceeefe269f44cb92c7..f1b8b41f59422b2de372cb39ed37b3b46c11c0cb

Suspecting: https://chromium.googlesource.com/chromium/src/+/f1b8b41f59422b2de372cb39ed37b3b46c11c0cb

@ellyjones: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Labels: RegressedIn-65 Target-65 FoundIn-65
The behavior in the "actual" video looks like the behavior before <https://chromium-review.googlesource.com/c/chromium/src/+/852377>, but that CL landed 3 days before this bug was filed, so I'm a bit puzzled.

Reporter, can you re-test this please?

Comment 4 by vku...@etouch.net, Jan 17 2018

Labels: OS-Linux OS-Windows
With response to comment #3:
Rechecked again and above issue is still reproducible on latest canary version 65.0.3322.3(Official Build) on Mac OS X(10.12.6,10.13.1,10.13.3),Win(7,8,8.1,10) & Linux(14.04 LTS) OS as well.

Please refer attached screen-cast.
Actual_folder.mp4
395 KB View Download
Status: Started (was: Assigned)
Ah, okay, I see what the issue is. Here's the fix: <https://chromium-review.googlesource.com/c/chromium/src/+/870751>
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f81dbbb30c4b054059502682325551d278b251be

commit f81dbbb30c4b054059502682325551d278b251be
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Jan 17 20:35:00 2018

views: use interior padding in treeview edit field

In f1b8b41f, TreeView's Textfield for editing lost the default Harmony
focus ring and gained a fixed 1pt border. However, that change lost
the interior padding on the Textfield, so the text runs directly into
the border ring.

Bug:  801096 
Change-Id: Ic078c3ae17964c7929e903f2e6665303be1188ad
Reviewed-on: https://chromium-review.googlesource.com/870751
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529861}
[modify] https://crrev.com/f81dbbb30c4b054059502682325551d278b251be/ui/views/controls/tree/tree_view.cc

Status: Fixed (was: Started)

Comment 8 by vku...@etouch.net, Jan 18 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3324.0
Update : 
Verified this issue on Windows (7,8,8.1,10),Mac OS(10.12.6,10.13.1,10.13.3)& Linux (14.04 LTS) OS with latest canary version #65.0.3324.0(Official build) and the issue is fixed.Kindly refer attached screen-cast.

Thank you!

Comment 9 by vku...@etouch.net, Jan 18 2018

Actual_Bookmark.mp4
269 KB View Download
Labels: ET-MUM-Reported

Sign in to add a comment