New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801088 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Ctrl-Space should be passed to Android apps when only one IME is enabled.

Project Member Reported by yhanada@chromium.org, Jan 11 2018

Issue description

In that case, we don't have any reason to reserve the keyboard shortcut.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdba22e6b710cb2d8e1b8c97f2decaa3d208cc86

commit cdba22e6b710cb2d8e1b8c97f2decaa3d208cc86
Author: Yuichiro Hanada <yhanada@chromium.org>
Date: Fri Jan 19 00:27:13 2018

exo: Discard a reserved keyboard shortcut only if it's enabled.

When seeing a reserved keyboard shortcut, exo display server sends
keyboard leave/enter event with pressed keys information instead of
key events.

      only one IME is enabled.

Bug: 801088
Test: Manual. Confirm that Ctrl-Space is sent to Android apps when
Change-Id: I207434b45690f231601cb6187e35a806f8c69f89
Reviewed-on: https://chromium-review.googlesource.com/866655
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530360}
[modify] https://crrev.com/cdba22e6b710cb2d8e1b8c97f2decaa3d208cc86/components/exo/keyboard.cc

Status: Fixed (was: Assigned)
Cc: reve...@chromium.org
Labels: -M-65 M-69
Status: Assigned (was: Fixed)
As we moved the filtering code into the container side, the issue came back.
I haven't came up with how to fix the issue in the container side because the container doesn't know whether a key event is an active shortcut or not.

Sign in to add a comment