New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801087 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Delay is seen for 'Automatic name servers' values to display after selecting 'Customer name servers' option and again selecting 'Automatic name servers' option in chrome://settings

Project Member Reported by mmanchala@chromium.org, Jan 11 2018

Issue description

Chrome Version:  64.03282.85/10176.45.0 Beta channel  Daisy, Candy & Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://settings page -> At 'Network' section click on Wi-Fi -> select Connected Wi-Fi network
(2)Click on 'Network' -> At 'Name servers' observe 'Automatic name servers' values are seen
(3)Now select 'Customer name servers' option and again select 'Automatic name servers' option ->  observe delay in 'Automatic name servers' values to display i.e. ',,,' is seen  (Please refer video and screenshot)

Expected: After selecting 'Customer name servers' option and again selecting 'Automatic name servers' option
a)Delay should not be seen to display 'Automatic name servers'  values
or
b)Nothing should be seen i.e. no value should be seen for few seconds

Actual: Instead 
a)Delay is seen for 'Automatic name servers' values to display
b)',,,' is seen 

This is Regression issue as same is working fine in 63.0.3239.116/10032.75.0 Stable-channel Candy

@stevenjb : Please confirm the issue

Note: Issue is seen on latest M-65 also

 
Actual_Values.webm
862 KB View Download
Actual.jpg
105 KB View Download
Expected_NoDelay.webm
701 KB View Download
Labels: -Pri-1 -M-64 M-65 Pri-2
Since this resolves itself, lowering to a P2 for 65.

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/771fb3b616f0cc640127321c150b76f05b51578d

commit 771fb3b616f0cc640127321c150b76f05b51578d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Feb 01 20:03:24 2018

Network config: nameservers: clear empty

Don't display empty nameservers when switching from custom -> automatic.

Bug:  801087 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia4111f044368411773a0cbfb94cf129231f72845
Reviewed-on: https://chromium-review.googlesource.com/896267
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533789}
[modify] https://crrev.com/771fb3b616f0cc640127321c150b76f05b51578d/ui/webui/resources/cr_components/chromeos/network/network_nameservers.js

Labels: Merge-Request-65
Status: Fixed (was: Started)
Labels: Inhouse-HYD-Reported
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 2 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 5 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f1898bdb6d63e9d5d644c7389323f3b8e6a7972

commit 5f1898bdb6d63e9d5d644c7389323f3b8e6a7972
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Feb 05 20:03:44 2018

Network config: nameservers: clear empty

Don't display empty nameservers when switching from custom -> automatic.

TBR=stevenjb@chromium.org

(cherry picked from commit 771fb3b616f0cc640127321c150b76f05b51578d)

Bug:  801087 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia4111f044368411773a0cbfb94cf129231f72845
Reviewed-on: https://chromium-review.googlesource.com/896267
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#533789}
Reviewed-on: https://chromium-review.googlesource.com/902325
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#313}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/5f1898bdb6d63e9d5d644c7389323f3b8e6a7972/ui/webui/resources/cr_components/chromeos/network/network_nameservers.js

Sign in to add a comment