New issue
Advanced search Search tips

Issue 801053 link

Starred by 1 user
Status: Fixed
Owner:
shimazu@chromium.org
Closed: Jan 2018
Cc:
falken@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Repeated call on ServiceWorkerDataPipeReader::OnHandleGotSignal

Project Member Reported by shimazu@chromium.org, Jan 11 2018 
IO Thread seems to be occupied by ServiceWorkerDataPipeReader::OnHandleGotSignal probably after it returns earlier when |stream_pending_buffer_| is null.

https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_data_pipe_reader.cc?type=cs&sq=package:chromium&l=56

I could reproduce it only on CrOS (62.0.3202.97) for now, but I think it's still happening on ToT since the code hasn't been changed since M62.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/108763a19bd710bbb78975a36c11df15e9996dec

commit 108763a19bd710bbb78975a36c11df15e9996dec
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Thu Jan 11 08:11:23 2018

Use MANUAL policy for a SimpleWatcher in ServiceWorkerDataPipeReader

Previously the watcher invoked the handler even if no buffer is set by net
stack, and the handle was called repeatedly. This patch fixes that by using
MANUAL arming policy. The readable handler will be invoked only after a buffer
is set in ReadDataRaw, which is called by the net stack.

Bug:  801053 
Change-Id: Ibd56d71075cfb673e29735787f01375b5bbea491
Reviewed-on: https://chromium-review.googlesource.com/861381
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528582}
[modify] https://crrev.com/108763a19bd710bbb78975a36c11df15e9996dec/content/browser/service_worker/service_worker_data_pipe_reader.cc

Comment 2 by shimazu@google.com, Jan 15 2018

Labels: -M-62 M-65 FoundIn-62
Status: Fixed (was: Started)

Comment 3 by shimazu@chromium.org, Jan 15 2018

Labels: OS-Android OS-Linux OS-Mac OS-Windows
Also I don't think this bug is only on CrOS.
►

Sign in to add a comment