New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801046 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 800899



Sign in to add a comment

"swarming.py reproduce" leaves behind work directory, causing second invocation to fail

Project Member Reported by kbr@chromium.org, Jan 11 2018

Issue description

To reproduce, on Windows, run:

python tools\swarming_client\swarming.py reproduce -S chromium-swarm.appspot.com 3af44789a4596410
python tools\swarming_client\swarming.py reproduce -S chromium-swarm.appspot.com 3af44789a4596410

The second invocation will fail with:

Usage: swarming.py reproduce [options] task_id -- <extra_args>

swarming.py: error: Please delete the directory 'work' first


Perhaps the tool should have an option to leave the work directory behind, but its default behavior should be to clean up after itself.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/64990b3adb9a8a531878ae29ac1d5c885984d49f

commit 64990b3adb9a8a531878ae29ac1d5c885984d49f
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Sat Jun 16 13:11:02 2018

[client] Fix 3 issues for the cost of one CL

- swarming.py reproduce uses a cache by default to fix usage on 32 bits.
- swarming.py reproduce cleans up 'work' directory by default.
- isolateserver.py uses a cache by default to fix usage on 32 bits.

Sorry for lack of tests, I burned all my energy on the last CLs so there was
none left. In practice, people who use these report bugs when they fail, so yay?

Bug:  824832 ,  801046 
Change-Id: I097aa353cc8d0cdecd05902ad359c210c115f46c
Reviewed-on: https://chromium-review.googlesource.com/1103118
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>

[modify] https://crrev.com/64990b3adb9a8a531878ae29ac1d5c885984d49f/client/isolateserver.py
[modify] https://crrev.com/64990b3adb9a8a531878ae29ac1d5c885984d49f/client/swarming.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4ed0f75179a60aabbc6c6dfab3ea7159de05fa1

commit f4ed0f75179a60aabbc6c6dfab3ea7159de05fa1
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Sun Jun 17 02:36:52 2018

Roll src/tools/swarming_client/ 281c39019..9a518d097 (8 commits)

https://chromium.googlesource.com/infra/luci/client-py.git/+log/281c390193ec..9a518d097dca

$ git log 281c39019..9a518d097 --date=short --no-merges --format='%ad %ae %s'
2018-06-16 maruel [swarming] Implement NamedCache.cleanup()
2018-06-16 maruel [client] Fix 3 issues for the cost of one CL
2018-06-15 maruel [client] Fix cache LRU coherency
2018-06-15 maruel [client] Fix Memory CAC to be LRU, internal cleanups
2018-06-14 maruel [client] cache the named cache size; stop keeping empty caches
2018-06-14 maruel [client] Update lru.py and test
2018-06-13 maruel [client] Refactor the caches to stop using context manager
2018-06-13 iannucci [swarming] Actually apply pool based TaskTemplates.

Created with:
  roll-dep src/tools/swarming_client

TBR=qyearsley@chromium.org

Bug:  801046 ,  824832 
Change-Id: Id2dd2bc2b0295d96726eb200f6e9a0cc8aea1eb7
Reviewed-on: https://chromium-review.googlesource.com/1103534
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567906}
[modify] https://crrev.com/f4ed0f75179a60aabbc6c6dfab3ea7159de05fa1/DEPS

Comment 3 by mar...@chromium.org, Jun 17 2018

Status: Fixed (was: Assigned)

Sign in to add a comment