Make a new directory for Clank browser java code relating to selection. This will center around SelectionPopupControllerImpl and supporting classes.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad commit 4ae371bc93bcfd0b3033c29701b33f0516b8d0ad Author: Pedro Amaral <amaralp@chromium.org> Date: Thu Jan 11 16:40:46 2018 Make Android selection directory Bug: 801035 Change-Id: If407b604d8db0af022616a93a0db6dfd16e4d731 Reviewed-on: https://chromium-review.googlesource.com/860481 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#528641} [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/android_webview/glue/java/DEPS [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/android_webview/java/DEPS [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/BUILD.gn [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/ContentClassFactory.java [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/ContentViewCoreImpl.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/FloatingActionModeCallback.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/FloatingPastePopupMenu.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/HandleViewResources.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/LGEmailActionModeWorkaround.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/LegacyPastePopupMenu.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/MenuDescriptor.java [add] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/OWNERS [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/PastePopupMenu.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/SelectionEventProxyImpl.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/SelectionIndicesConverter.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/SelectionInsertionHandleObserver.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionClient.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionMetricsLogger.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionProvider.java [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content_public/browser/ActionModeCallbackHelper.java [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content_public/browser/SelectionClient.java [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/java/src/org/chromium/content_public/browser/SelectionPopupController.java [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java [modify] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/junit/src/org/chromium/content/browser/selection/MenuDescriptorTest.java [add] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/junit/src/org/chromium/content/browser/selection/OWNERS [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/junit/src/org/chromium/content/browser/selection/SelectionPopupControllerTest.java [rename] https://crrev.com/4ae371bc93bcfd0b3033c29701b33f0516b8d0ad/content/public/android/junit/src/org/chromium/content/browser/selection/SmartSelectionMetricsLoggerTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a commit 28eaa56781f3f1e9f30f0746a159173e8c2a4a1a Author: Yoland Yan <yolandyan@chromium.org> Date: Thu Jan 11 22:34:48 2018 Revert "Make Android selection directory" This reverts commit 4ae371bc93bcfd0b3033c29701b33f0516b8d0ad. Reason for revert: It broke downstream arm-unpublished-builder-rel bot Original change's description: > Make Android selection directory > > Bug: 801035 > Change-Id: If407b604d8db0af022616a93a0db6dfd16e4d731 > Reviewed-on: https://chromium-review.googlesource.com/860481 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Pedro Amaral <amaralp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528641} TBR=boliu@chromium.org,amaralp@chromium.org Change-Id: I5807816720ff8e3b46f7ae318e7a3604de9e16d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 801035 Reviewed-on: https://chromium-review.googlesource.com/862164 Reviewed-by: Yoland Yan <yolandyan@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#528785} [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/android_webview/glue/java/DEPS [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/android_webview/java/DEPS [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/BUILD.gn [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/ContentClassFactory.java [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/ContentViewCoreImpl.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/FloatingActionModeCallback.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/MenuDescriptor.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/SelectionEventProxyImpl.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/SelectionIndicesConverter.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/SelectionInsertionHandleObserver.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/SelectionPopupControllerImpl.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/SmartSelectionClient.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/SmartSelectionMetricsLogger.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/SmartSelectionProvider.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/input/FloatingPastePopupMenu.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/input/HandleViewResources.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/input/LGEmailActionModeWorkaround.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/input/LegacyPastePopupMenu.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content/browser/input/PastePopupMenu.java [delete] https://crrev.com/c2232cbe4f82bb91243b066e0fda01068682ac8d/content/public/android/java/src/org/chromium/content/browser/selection/OWNERS [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content_public/browser/ActionModeCallbackHelper.java [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content_public/browser/SelectionClient.java [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/java/src/org/chromium/content_public/browser/SelectionPopupController.java [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java [modify] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/junit/src/org/chromium/content/browser/MenuDescriptorTest.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/junit/src/org/chromium/content/browser/SelectionPopupControllerTest.java [rename] https://crrev.com/28eaa56781f3f1e9f30f0746a159173e8c2a4a1a/content/public/android/junit/src/org/chromium/content/browser/SmartSelectionMetricsLoggerTest.java [delete] https://crrev.com/c2232cbe4f82bb91243b066e0fda01068682ac8d/content/public/android/junit/src/org/chromium/content/browser/selection/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/242b78c83ad56851fb49f0f9e2001cdeecebd935 commit 242b78c83ad56851fb49f0f9e2001cdeecebd935 Author: Yoland Yan <yolandyan@chromium.org> Date: Thu Jan 11 22:46:04 2018 Revert "Revert "Make Android selection directory"" This reverts commit 28eaa56781f3f1e9f30f0746a159173e8c2a4a1a. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Make Android selection directory" > > This reverts commit 4ae371bc93bcfd0b3033c29701b33f0516b8d0ad. > > Reason for revert: It broke downstream arm-unpublished-builder-rel bot > > Original change's description: > > Make Android selection directory > > > > Bug: 801035 > > Change-Id: If407b604d8db0af022616a93a0db6dfd16e4d731 > > Reviewed-on: https://chromium-review.googlesource.com/860481 > > Reviewed-by: Bo <boliu@chromium.org> > > Commit-Queue: Pedro Amaral <amaralp@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#528641} > > TBR=boliu@chromium.org,amaralp@chromium.org > > Change-Id: I5807816720ff8e3b46f7ae318e7a3604de9e16d5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 801035 > Reviewed-on: https://chromium-review.googlesource.com/862164 > Reviewed-by: Yoland Yan <yolandyan@chromium.org> > Commit-Queue: Yoland Yan <yolandyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528785} TBR=boliu@chromium.org,yolandyan@chromium.org,amaralp@chromium.org Change-Id: If14e4f2e18398d94bd86fe22bd13a8186368594f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 801035 Reviewed-on: https://chromium-review.googlesource.com/862620 Reviewed-by: Yoland Yan <yolandyan@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#528790} [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/android_webview/glue/java/DEPS [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/android_webview/java/DEPS [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/android_webview/java/src/org/chromium/android_webview/PopupTouchHandleDrawable.java [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/BUILD.gn [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/ContentClassFactory.java [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/ContentViewCoreImpl.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/FloatingActionModeCallback.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/FloatingPastePopupMenu.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/HandleViewResources.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/LGEmailActionModeWorkaround.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/LegacyPastePopupMenu.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/MenuDescriptor.java [add] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/OWNERS [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/PastePopupMenu.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/SelectionEventProxyImpl.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/SelectionIndicesConverter.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/SelectionInsertionHandleObserver.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/SelectionPopupControllerImpl.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionClient.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionMetricsLogger.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content/browser/selection/SmartSelectionProvider.java [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content_public/browser/ActionModeCallbackHelper.java [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content_public/browser/SelectionClient.java [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/java/src/org/chromium/content_public/browser/SelectionPopupController.java [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java [modify] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/javatests/src/org/chromium/content/browser/input/ImeActivityTestRule.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/junit/src/org/chromium/content/browser/selection/MenuDescriptorTest.java [add] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/junit/src/org/chromium/content/browser/selection/OWNERS [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/junit/src/org/chromium/content/browser/selection/SelectionPopupControllerTest.java [rename] https://crrev.com/242b78c83ad56851fb49f0f9e2001cdeecebd935/content/public/android/junit/src/org/chromium/content/browser/selection/SmartSelectionMetricsLoggerTest.java
Comment 1 by bugdroid1@chromium.org
, Jan 11 2018