New issue
Advanced search Search tips

Issue 801031 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

The XFormTest.verifyIsInvertible case in gfx_unittests failed on Loongson.

Reported by wangqing...@loongson.cn, Jan 11 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux mips64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3096.2 Safari/537.36

Steps to reproduce the problem:
1. build gfx_unittests
2. run gfx_unittests
3. 

What is the expected behavior?
passed this test case.

What went wrong?
Note: Google Test filter = XFormTest.verifyIsInvertible
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from XFormTest
[ RUN      ] XFormTest.verifyIsInvertible
../../ui/gfx/transform_unittest.cc:2080: Failure
Value of: A.IsInvertible()
  Actual: true
Expected: false
[  FAILED  ] XFormTest.verifyIsInvertible (1 ms)
[----------] 1 test from XFormTest (1 ms total)
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (2 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] XFormTest.verifyIsInvertible
 1 FAILED TEST

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 60.0.3096.2  Channel: n/a
OS Version: 
Flash Version:
 
Initial patch that Closed madd.d and msub.d instructions generated in skia on Loongson has just been submitted for a review.

It can be viewed at:
https://chromium-review.googlesource.com/c/chromium/src/+/861340

Comment 2 by wfh@chromium.org, Jan 11 2018

can you go ahead and create a master bug for adding loongson support to chromium, and then make these bugs blocked on that bug?

I think we should also have some discussion in general about adding loongson support on chromium-dev can you go ahead and post a plan for your work to that group, including an estimate of how many modifications you expect to have to make and how you plan to ensure they don't regress (e.g. do you have your own continuous integration?)

https://groups.google.com/a/chromium.org/forum/#!forum/chromium-dev is the place for this. Thanks
Components: Internals>Skia
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 17 (5 days ago)

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment