TextEliderTest.ElideRectangleTextLongWords and 1 other(s) in gfx_unittests failing on chromium.mac/Mac10.11 Tests |
|||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of tapted@chromium.org TextEliderTest.ElideRectangleTextLongWords and 1 other(s) in gfx_unittests failing on chromium.mac/Mac10.11 Tests Builders failed on: - Mac10.11 Tests: https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests
,
Jan 11 2018
Tests are - TextEliderTest.ElideRectangleTextPunctuation - TextEliderTest.ElideRectangleTextLongWords
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1c782b62e096d37e155bf638844ae385bf09f07 commit d1c782b62e096d37e155bf638844ae385bf09f07 Author: Trent Apted <tapted@chromium.org> Date: Thu Jan 11 02:04:53 2018 Pass the Typesetter::HARFBUZZ to ElideRectangleText unittests Two tests started failing after r528483 on macOS 10.11 only: - TextEliderTest.ElideRectangleTextPunctuation - TextEliderTest.ElideRectangleTextLongWords This is because ElideRectangleText switched to HARFBUZZ. Update the tests to use HARFBUZZ when determining test string widths. TBR=msw@chromium.org Bug: 801029 Change-Id: I7f84415545ec9acd2b3bba470c11b423fa8f1b14 Reviewed-on: https://chromium-review.googlesource.com/860973 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#528533} [modify] https://crrev.com/d1c782b62e096d37e155bf638844ae385bf09f07/ui/gfx/text_elider_unittest.cc
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffb373e3e64d342c4f9a00f569c380e18604e893 commit ffb373e3e64d342c4f9a00f569c380e18604e893 Author: Taiju Tsuiki <tzik@chromium.org> Date: Thu Jan 11 04:21:35 2018 Revert "Pass the Typesetter::HARFBUZZ to ElideRectangleText unittests" This reverts commit d1c782b62e096d37e155bf638844ae385bf09f07. Reason for revert: This CL seems to break TextEliderTest.ElideRectangleTextLongWords on Mac bots. The log is available here: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/27969 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F27969%2F%2B%2Frecipes%2Fsteps%2Fgfx_unittests_on_Mac-10.10%2F0%2Flogs%2FTextEliderTest.ElideRectangleTextLongWords%2F0 Original change's description: > Pass the Typesetter::HARFBUZZ to ElideRectangleText unittests > > Two tests started failing after r528483 on macOS 10.11 only: > - TextEliderTest.ElideRectangleTextPunctuation > - TextEliderTest.ElideRectangleTextLongWords > > This is because ElideRectangleText switched to HARFBUZZ. Update > the tests to use HARFBUZZ when determining test string widths. > > TBR=msw@chromium.org > > Bug: 801029 > Change-Id: I7f84415545ec9acd2b3bba470c11b423fa8f1b14 > Reviewed-on: https://chromium-review.googlesource.com/860973 > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528533} TBR=msw@chromium.org,tapted@chromium.org Change-Id: I928e7407b1eb75fa5a403d558dbc50b380c3a8df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 801029 Reviewed-on: https://chromium-review.googlesource.com/861442 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#528557} [modify] https://crrev.com/ffb373e3e64d342c4f9a00f569c380e18604e893/ui/gfx/text_elider_unittest.cc
,
Jan 11 2018
Two tests started failing after r528533 on macOS *10.10* only: - TextEliderTest.ElideRectangleTextLongWords - TextEliderTest.ElideRectangleText :|
,
Jan 11 2018
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f98802d841e3452f84830e69850b59b173343cd commit 6f98802d841e3452f84830e69850b59b173343cd Author: Trent Apted <tapted@chromium.org> Date: Thu Jan 11 04:49:18 2018 Disable TextEliderTest.ElideRectangleTextPunctuation,ElideRectangleTextLongWords on Mac Two tests started failing after r528483 on macOS 10.11 only: - TextEliderTest.ElideRectangleTextPunctuation - TextEliderTest.ElideRectangleTextLongWords Fixing them on 10.11 broke 10.10. Disable for now. TBR=msw@chromium.org Bug: 801029 Change-Id: I9ad3ef24b281f924f5de3a06c76623ead5ff6aee Reviewed-on: https://chromium-review.googlesource.com/861375 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#528562} [modify] https://crrev.com/6f98802d841e3452f84830e69850b59b173343cd/ui/gfx/text_elider_unittest.cc
,
Jan 11 2018
I think the smart thing to do here is just wait for Typesetter::DEFAULT to switch to HARFBUZZ.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a2b8ef0a399f1ff0850181c0ee5f900a9425290 commit 8a2b8ef0a399f1ff0850181c0ee5f900a9425290 Author: Trent Apted <tapted@chromium.org> Date: Thu Jan 18 05:51:58 2018 Switch the default typesetter in gfx:: to HARFBUZZ. All Cocoa UI consumers now specify that they typeset with CoreText. The remaining consumers all use HARFBUZZ. This resolves some subtle problems in views UI around text eliding. Bug: 801094 , 801029 , 798927 , 454835 Change-Id: Iece3506938d83e214837491eec3ef097ac296d0c Reviewed-on: https://chromium-review.googlesource.com/869630 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#530064} [modify] https://crrev.com/8a2b8ef0a399f1ff0850181c0ee5f900a9425290/ui/gfx/canvas_skia.cc [modify] https://crrev.com/8a2b8ef0a399f1ff0850181c0ee5f900a9425290/ui/gfx/text_constants.h [modify] https://crrev.com/8a2b8ef0a399f1ff0850181c0ee5f900a9425290/ui/gfx/text_elider_unittest.cc
,
Jan 19 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by tapted@chromium.org
, Jan 11 2018Status: Assigned (was: Available)