New issue
Advanced search Search tips

Issue 801018 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 780164



Sign in to add a comment

[MD Extensions] "Allow in incognito" should respect ProfileInfo#isIncognitoAvailable

Project Member Reported by dpa...@chromium.org, Jan 11 2018 
See screenshot from old UI.

[1] https://cs.chromium.org/chromium/src/chrome/common/extensions/api/developer_private.idl?l=235
allow_in_incognito_hidden.png
31.5 KB View Download

Comment 1 by dpa...@chromium.org, Jan 11 2018

Blocking: 780164

Comment 2 by dschuyler@chromium.org, Jan 11 2018 

Is the/a fix to not show the control if ProfileInfo#isIncognitoAvailable is false?

Comment 3 by dpa...@chromium.org, Jan 11 2018 

Correct.

Comment 4 by dpa...@chromium.org, Jan 11 2018

Owner: dpa...@chromium.org
Status: Assigned (was: Available)

Comment 5 by dpa...@chromium.org, Jan 12 2018

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d4d413528a59bbd395b891f2502b74621e99ab3

commit 3d4d413528a59bbd395b891f2502b74621e99ab3
Author: dpapad <dpapad@chromium.org>
Date: Fri Jan 12 18:33:29 2018

MD Extensions: Respect ProfileInfo#isIncognitoAvailable.

When false, hides the "allow in incognito" toggle.

Bug:  801018 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I24c18ea0e1851abba98433c87ff162df7f98ac09
Reviewed-on: https://chromium-review.googlesource.com/862699
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529000}
[modify] https://crrev.com/3d4d413528a59bbd395b891f2502b74621e99ab3/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/3d4d413528a59bbd395b891f2502b74621e99ab3/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/3d4d413528a59bbd395b891f2502b74621e99ab3/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/3d4d413528a59bbd395b891f2502b74621e99ab3/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/3d4d413528a59bbd395b891f2502b74621e99ab3/chrome/test/data/webui/extensions/extension_detail_view_test.js

Comment 7 by dpa...@chromium.org, Jan 12 2018

Status: Fixed (was: Started)
►

Sign in to add a comment