New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 801011 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 780164



Sign in to add a comment

[MD Extensions] "Load unpacked" button should respect ProfileInfo#canLoadUnpacked.

Project Member Reported by dpa...@chromium.org, Jan 11 2018

Issue description

See screenshot from old UI.

[1] https://cs.chromium.org/chromium/src/chrome/common/extensions/api/developer_private.idl?l=232
 
load_unpacked.png
29.8 KB View Download

Comment 1 by dpa...@chromium.org, Jan 11 2018

Blocking: 780164
Owner: dschuyler@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bd5302de9d328b1bee025ed18ce447968b6c0d8

commit 2bd5302de9d328b1bee025ed18ce447968b6c0d8
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Fri Jan 12 00:27:09 2018

[MD extensions] hide Load Unpacked Extensions if forbidden

This CL hides the Load Unpacked Extension button in the MD extensions
toolbar if the policy sets canLoadUnpacked to false.

Bug:  801011 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I99cb332879f8ff7afce1c6572c41495933a68b2b
Reviewed-on: https://chromium-review.googlesource.com/860174
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528826}
[modify] https://crrev.com/2bd5302de9d328b1bee025ed18ce447968b6c0d8/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/2bd5302de9d328b1bee025ed18ce447968b6c0d8/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/2bd5302de9d328b1bee025ed18ce447968b6c0d8/chrome/browser/resources/md_extensions/toolbar.html
[modify] https://crrev.com/2bd5302de9d328b1bee025ed18ce447968b6c0d8/chrome/browser/resources/md_extensions/toolbar.js
[modify] https://crrev.com/2bd5302de9d328b1bee025ed18ce447968b6c0d8/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
[modify] https://crrev.com/2bd5302de9d328b1bee025ed18ce447968b6c0d8/chrome/test/data/webui/extensions/extension_manager_unit_test.js
[modify] https://crrev.com/2bd5302de9d328b1bee025ed18ce447968b6c0d8/chrome/test/data/webui/extensions/extension_toolbar_test.js

Status: Fixed (was: Started)

Sign in to add a comment