New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800988 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 747385



Sign in to add a comment

cros buildresult

Project Member Reported by dgarr...@chromium.org, Jan 10 2018

Issue description

The toolchain team would like to have a command that can look up the following things about a tryjob, given the tryjob's buildbucket id.

a) Has it completed.
b) Build pass/fail
c) Per Stage pass/fail
d) Artifacts URL

They would also like this commands output to nicely structured for machine parsing (json?).
 
This is a blocker for moving tryjobs to swarming, since their current solution depends on a buildbot behaviors and APIs.
Blocking: 747385
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)

Comment 4 by cmt...@chromium.org, Jan 11 2018

Cc: llozano@chromium.org yunlian@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/00a0c976a2e56c2ad56347ceffc37a31f9cf31f5

commit 00a0c976a2e56c2ad56347ceffc37a31f9cf31f5
Author: Don Garrett <dgarrett@google.com>
Date: Thu Jan 18 22:44:43 2018

cros buildresult: New command to look up results for a build.

New command to find the results of a build. This tool is general, but
originally intended for the build tools team.

BUG= chromium:800988 
TEST=Manual

Change-Id: I80ae5ee43767e12802b1f31b4e0dbbc52d67c763
Reviewed-on: https://chromium-review.googlesource.com/861382
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[add] https://crrev.com/00a0c976a2e56c2ad56347ceffc37a31f9cf31f5/cli/cros/cros_buildresult_unittest.py
[add] https://crrev.com/00a0c976a2e56c2ad56347ceffc37a31f9cf31f5/cli/cros/cros_buildresult.py
[add] https://crrev.com/00a0c976a2e56c2ad56347ceffc37a31f9cf31f5/cli/cros/cros_buildresult_unittest

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5c1b9c71cd42264ae9f0b9376980059487634693

commit 5c1b9c71cd42264ae9f0b9376980059487634693
Author: Don Garrett <dgarrett@google.com>
Date: Fri Jan 19 01:40:40 2018

cros buildresult: Populate toolchain_url and artifact_url.

Create a fake artifact_url based on metadata_url, which already exists
in CIDB and is populated.

BUG= chromium:800988 
TEST=Manual + new unittests.

Change-Id: I2c75ce0168eba19e99561e875202b0a158e454f5
Reviewed-on: https://chromium-review.googlesource.com/862887
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/5c1b9c71cd42264ae9f0b9376980059487634693/cli/cros/cros_buildresult_unittest.py
[modify] https://crrev.com/5c1b9c71cd42264ae9f0b9376980059487634693/cli/cros/cros_buildresult.py
[modify] https://crrev.com/5c1b9c71cd42264ae9f0b9376980059487634693/lib/cidb.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/48d3e1a0d895235d3e84e8b1b188001ce9f66721

commit 48d3e1a0d895235d3e84e8b1b188001ce9f66721
Author: Don Garrett <dgarrett@google.com>
Date: Sat Jan 20 04:35:45 2018

cros buildresult: Don't crash if build not found.

If a build doesn't exist in CIDB at all, we need to not crash. We
could be more informative if we queried buildbucket, but not crashing
is a good start.

BUG= chromium:800988 
TEST=cros buildresult --buildbucket-id=8956941933144134560

Change-Id: I4d68b7c395fa80c52cbf7a3ac5b491a4db375daf
Reviewed-on: https://chromium-review.googlesource.com/877184
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/48d3e1a0d895235d3e84e8b1b188001ce9f66721/cli/cros/cros_buildresult.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/39d16f6ba34e45b9020aee23e730deea4759a6a5

commit 39d16f6ba34e45b9020aee23e730deea4759a6a5
Author: Don Garrett <dgarrett@google.com>
Date: Sat Jan 27 04:54:14 2018

cros buildresult: Add build-config / date support.

Commands like the following are now supported.

cros buildresult --build-config funky-tryjob --date 2018-1-1
cros buildresult --build-config funky-tryjob \
  --start-date 2018-1-1  --end-date 2018-1-20

BUG= chromium:800988 
TEST=run_tests + manual runs.

Change-Id: Ie308f809edbd93135cf6dffa39cdbfa68a61035d
Reviewed-on: https://chromium-review.googlesource.com/882962
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/39d16f6ba34e45b9020aee23e730deea4759a6a5/cli/cros/cros_buildresult.py

Status: Fixed (was: Started)
I believe this is now done. If there is a problem, if you need some other feature, please let me know.

Sign in to add a comment