New issue
Advanced search Search tips

Issue 800977 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug

Blocked on:
issue 801295
issue 805196
issue 823808

Blocking:
issue 28287


Show other hotlists

Hotlists containing this issue:
Chromium-Packagers


Sign in to add a comment

Add a bot to build Linux tarballs

Project Member Reported by thomasanderson@chromium.org, Jan 10 2018

Issue description

Proposal: Add a bot that 
* Downloads the Linux tarballs as the publish_tarball bot generates them.
* Extracts the tarballs.
* Bootstraps gn.
* Builds clang.
* Sets args.gn to be similar to a packager build (eg. https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/chromium#n167)
* Builds chrome/installer/linux.
 
Blockedon: 801295
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3ab7388319114eb92838a72509b774fc6c1ef8d

commit a3ab7388319114eb92838a72509b774fc6c1ef8d
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jan 12 01:53:31 2018

Add --skip-build and --skip-checkout options to clang build script

These options are necessary for adding clang sources to the Linux tarballs.  The
intent is that the publish_tarball bot will run:
$ tools/clang/scripts/update.py --skip-build
And Chromium packagers will run:
$ tools/clang/scripts/update.py --skip-checkout

BUG=800977
R=pcc

Change-Id: I1981df1dee8590ceb79520e1420f93d5fd529241
Reviewed-on: https://chromium-review.googlesource.com/861866
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528843}
[modify] https://crrev.com/a3ab7388319114eb92838a72509b774fc6c1ef8d/tools/clang/scripts/update.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 2018

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7134f1d2e49db8860faf912134f32636df0e3e78

commit 7134f1d2e49db8860faf912134f32636df0e3e78
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jan 19 01:09:57 2018

Add LLVM sources to the tarballs

This is needed so chromium packagers don't have to download the clang/lld
binaries from GCS.  They prefer to build from source.

BUG=800977
R=mmoss

Change-Id: I07d4d7c78501915c8b5660889e7453e650b9ce97
Reviewed-on: https://chromium-review.googlesource.com/875156
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

[modify] https://crrev.com/7134f1d2e49db8860faf912134f32636df0e3e78/recipes/recipes/publish_tarball.py
[modify] https://crrev.com/7134f1d2e49db8860faf912134f32636df0e3e78/recipes/recipes/publish_tarball.expected/basic.json

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/887968cf7c0d068973bbf3b316f6c28e10d191c6

commit 887968cf7c0d068973bbf3b316f6c28e10d191c6
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jan 19 21:18:35 2018

Remove build_tarball recipe

The recipe will be added to build/scripts/slave/recipes instead of in infra.

BUG=800977
R=mmoss

Change-Id: I46b6e07f6f1932775d665d75fb74ba3759dcfe9b
Reviewed-on: https://chromium-review.googlesource.com/875888
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/887968cf7c0d068973bbf3b316f6c28e10d191c6/recipes/README.recipes.md
[delete] https://crrev.com/d023e069ea08fcf9e13c7d46ea1b11c85ff76257/recipes/recipes/build_tarball.expected/basic.json
[delete] https://crrev.com/d023e069ea08fcf9e13c7d46ea1b11c85ff76257/recipes/recipes/build_tarball.py

Labels: Merge-Request-64
Requesting merge to M64 for:
https://chromium.googlesource.com/chromium/src.git/+/a3ab7388319114eb92838a72509b774fc6c1ef8d

The change does not affect the binary.  All it does is add some flags to a script, which we need it so that the publish_tarball bot stays green on the M64 branch.
Project Member

Comment 9 by sheriffbot@chromium.org, Jan 23 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-64
Nevermind on the merge request.  The beta channel has been updated and the publish_tarball bot has broken, so the only fix now is to add an exception in the publish_tarball recipe to only include the clang sources for M65 and higher.
Blockedon: 805196
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dd2f9a9e938056079aee4da0402cadeaa226e660

commit dd2f9a9e938056079aee4da0402cadeaa226e660
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jan 24 01:11:09 2018

Fix publish_tarball for M64 and M63

The --skip-build flag was only added to the clang update script in M65 or later,
so skip downloading the clang sources unless the major version is at least 65.

BUG=800977, 805147 
R=mmoss

Change-Id: Id1cf789bcc46668442354a67d07b5a4508fa4a70
Reviewed-on: https://chromium-review.googlesource.com/882460
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/dd2f9a9e938056079aee4da0402cadeaa226e660/recipes/recipes/publish_tarball.py
[modify] https://crrev.com/dd2f9a9e938056079aee4da0402cadeaa226e660/recipes/recipes/publish_tarball.expected/basic.json

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/872c0004fd2c8410cd9433d681a9811fc9b5defc

commit 872c0004fd2c8410cd9433d681a9811fc9b5defc
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jan 24 18:14:23 2018

Trigger tarball builds from publish_tarball

BUG=800977
R=mmoss

Change-Id: I19734f8218d672eee8da0b67d2322a60fce426bb
Reviewed-on: https://chromium-review.googlesource.com/875326
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/872c0004fd2c8410cd9433d681a9811fc9b5defc/recipes/recipes/publish_tarball.py
[modify] https://crrev.com/872c0004fd2c8410cd9433d681a9811fc9b5defc/recipes/recipes/publish_tarball.expected/basic.json

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 25 2018

Labels: merge-merged-config
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/819da91d1a1d0d7fb565b871ddba3de815fc3903

commit 819da91d1a1d0d7fb565b871ddba3de815fc3903
Author: Ryan Tseng <hinoka@google.com>
Date: Thu Jan 25 01:19:27 2018

[milo] Update consoles for fyi and linux.tryserver

Update console based off buildbot changes

fyi:
https://chromium-review.googlesource.com/876822

linux tryserver:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/858376

Bug: 800977, 777018 
Change-Id: I5f4a3b9209f622688a7a46bee2a06c187c34fd5a
Reviewed-on: https://chromium-review.googlesource.com/882308
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>

[modify] https://crrev.com/819da91d1a1d0d7fb565b871ddba3de815fc3903/luci-milo-dev.cfg
[modify] https://crrev.com/819da91d1a1d0d7fb565b871ddba3de815fc3903/luci-milo.cfg

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/86e40f0c059084612b6d823b88054c8620ebb47b

commit 86e40f0c059084612b6d823b88054c8620ebb47b
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jan 31 03:01:29 2018

Bootstrap gn with clang

The system gcc on Trusty doesn't support --std=c++14, which causes the "Build
From Tarball" bot to fail, so bootstrap gn with our clang too.

BUG=800977
R=mmoss

Change-Id: If62bd9b185e45af99eab6022ffea4906721fd368
Reviewed-on: https://chromium-review.googlesource.com/894496
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/86e40f0c059084612b6d823b88054c8620ebb47b/recipes/recipes/build_from_tarball.expected/basic.json
[modify] https://crrev.com/86e40f0c059084612b6d823b88054c8620ebb47b/recipes/recipes/build_from_tarball.py

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e93e6df04b6b08ad34060fba69144b2aea0352ba

commit e93e6df04b6b08ad34060fba69144b2aea0352ba
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Jan 31 22:45:44 2018

Fix gn bootstrap on systems with an old libstdc++

Running GN bootstrap on Trusty (which has libstdc++ 4.8) will result in build
errors caused by missing features in the old libstdc++ headers.  This CL
bootstraps gn with libc++ to prevent this type of issue in the future.  This is
needed to fix the gn bootstrap step of the "Build From Tarball" bot.

BUG=800977
R=dpranke

Change-Id: Icb5415088adf5e757ad082f3a1edc83ec0f77323
Reviewed-on: https://chromium-review.googlesource.com/895394
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533454}
[modify] https://crrev.com/e93e6df04b6b08ad34060fba69144b2aea0352ba/tools/gn/bootstrap/bootstrap.py

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a698b27a9aa97ff54e9b6d83255997975d0fb7bd

commit a698b27a9aa97ff54e9b6d83255997975d0fb7bd
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Feb 07 22:37:36 2018

Make the build_from_tarball recipe more similar to a packager build

The Build From Tarball bot has been green for the past few cycles, so now it's
time to start making it look more like a real Chromium packager build.

This CL builds clang instead of downloading it and unbundles libraries where
possible.

BUG=800977
R=mmoss

Change-Id: I687e7353473b1429094271ebd82c55e33e5ff3db
Reviewed-on: https://chromium-review.googlesource.com/907383
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/a698b27a9aa97ff54e9b6d83255997975d0fb7bd/recipes/recipes/build_from_tarball.expected/basic.json
[modify] https://crrev.com/a698b27a9aa97ff54e9b6d83255997975d0fb7bd/recipes/recipes/build_from_tarball.py

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a4846d5a97f11e24a1c48f65d5fb7da2ad05bff6

commit a4846d5a97f11e24a1c48f65d5fb7da2ad05bff6
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Feb 12 19:54:58 2018

Add quotes around goma_dir for build_from_tarball recipe

BUG=800977
R=mmoss

Change-Id: I0a21b95ff8fd1c2c815df4caa935ffb2bec68088
Reviewed-on: https://chromium-review.googlesource.com/914231
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/a4846d5a97f11e24a1c48f65d5fb7da2ad05bff6/recipes/recipes/build_from_tarball.expected/basic.json
[modify] https://crrev.com/a4846d5a97f11e24a1c48f65d5fb7da2ad05bff6/recipes/recipes/build_from_tarball.py

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/35fcfd2ab458b8ceae05f3692aaaa9e83323d3eb

commit 35fcfd2ab458b8ceae05f3692aaaa9e83323d3eb
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Feb 14 05:40:39 2018

Remove goma usage from build_from_tarball recipe

The "Build From Tarball" bot is now failing because the clang binaries that it
builds are not available in goma.

For now, skip on using goma entirely.  I'll add it back if I can figure out how
to get the clang build deterministic.

R=mmoss
BUG=800977

Change-Id: I98523ae37d23ed5d8dd367f05a20d493eb16be3d
Reviewed-on: https://chromium-review.googlesource.com/917609
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/35fcfd2ab458b8ceae05f3692aaaa9e83323d3eb/recipes/README.recipes.md
[modify] https://crrev.com/35fcfd2ab458b8ceae05f3692aaaa9e83323d3eb/recipes/recipes/build_from_tarball.expected/basic.json
[modify] https://crrev.com/35fcfd2ab458b8ceae05f3692aaaa9e83323d3eb/recipes/recipes/build_from_tarball.py

Project Member

Comment 22 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e5d9860cf47e1187c90d27353b6cc778b8a93bf

commit 7e5d9860cf47e1187c90d27353b6cc778b8a93bf
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Feb 21 21:24:55 2018

Add unbundled packages to sid sysroot

This is necessary for the "Build From Tarball" bot [1] which unbundles libraries
before building.  The packages that this CL adds were previously unnecessary
because the sources were pulled into third_party and built as part of a regular
build.

[1] https://ci.chromium.org/buildbot/chromium.infra.cron/Build%20From%20Tarball/

BUG=800977
R=thestig

Change-Id: I433ee21b620170104d9e8206eeab60b5dd056b2f
Reviewed-on: https://chromium-review.googlesource.com/922890
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538211}
[modify] https://crrev.com/7e5d9860cf47e1187c90d27353b6cc778b8a93bf/build/linux/sysroot_scripts/packagelist.sid.amd64
[modify] https://crrev.com/7e5d9860cf47e1187c90d27353b6cc778b8a93bf/build/linux/sysroot_scripts/packagelist.sid.arm
[modify] https://crrev.com/7e5d9860cf47e1187c90d27353b6cc778b8a93bf/build/linux/sysroot_scripts/packagelist.sid.arm64
[modify] https://crrev.com/7e5d9860cf47e1187c90d27353b6cc778b8a93bf/build/linux/sysroot_scripts/packagelist.sid.i386
[modify] https://crrev.com/7e5d9860cf47e1187c90d27353b6cc778b8a93bf/build/linux/sysroot_scripts/packagelist.sid.mips64el
[modify] https://crrev.com/7e5d9860cf47e1187c90d27353b6cc778b8a93bf/build/linux/sysroot_scripts/packagelist.sid.mipsel
[modify] https://crrev.com/7e5d9860cf47e1187c90d27353b6cc778b8a93bf/build/linux/sysroot_scripts/sysroot-creator-sid.sh

Project Member

Comment 23 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/372cee7a92e1544a75b8d66514d41fe3c22816db

commit 372cee7a92e1544a75b8d66514d41fe3c22816db
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Feb 23 19:00:13 2018

Linux: Add build flag to allow skipping the distro version check

This build flag is intended to be set by the "Build From Tarball" bot which does
an unbundled build.  This is necessary because some of the libraries that we
statically link (eg. harfbuzz) use features that are very new and not available
on all (or any) supported distros.

BUG=800977
R=thestig

Change-Id: Ie7d635effe148aae07a75b60221442b0c71f2a38
Reviewed-on: https://chromium-review.googlesource.com/933725
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538842}
[modify] https://crrev.com/372cee7a92e1544a75b8d66514d41fe3c22816db/chrome/installer/linux/BUILD.gn

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13734d4601ef881b0ed854a13c593aabbcc59ba3

commit 13734d4601ef881b0ed854a13c593aabbcc59ba3
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Sat Feb 24 04:45:47 2018

Switch to Debian Sid sysroot

BUG=800977
R=thestig,dpranke
CC=​dcastagna

Change-Id: I75a468d6d00389b94faa2432d66c934f06037ff9
Reviewed-on: https://chromium-review.googlesource.com/930233
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538989}
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/base/logging_unittest.cc
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/config/sysroot.gni
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/install-sysroot.py
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/packagelist.sid.amd64
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/packagelist.sid.arm
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/packagelist.sid.arm64
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/packagelist.sid.i386
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/packagelist.sid.mips64el
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/packagelist.sid.mipsel
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/sysroot-creator-sid.sh
[modify] https://crrev.com/13734d4601ef881b0ed854a13c593aabbcc59ba3/build/linux/sysroot_scripts/sysroots.json

Project Member

Comment 25 by bugdroid1@chromium.org, Mar 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c33cb72e9ad2897a0e3e4633641a40fc73114e08

commit c33cb72e9ad2897a0e3e4633641a40fc73114e08
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Mar 05 18:03:14 2018

Unbundle more libraries from Build From Tarball

We've switched to the Debian Sid sysroot, so more libraries can be unbundled.
Also added enable_distro_version_check=false to silence build complaints about
depending on libraries that are too new.

BUG=800977
R=mmoss

Change-Id: I8bd1f196b96e4d80fc6b2603010a7a42a7bd4548
Reviewed-on: https://chromium-review.googlesource.com/947663
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/c33cb72e9ad2897a0e3e4633641a40fc73114e08/recipes/recipes/build_from_tarball.expected/basic.json
[modify] https://crrev.com/c33cb72e9ad2897a0e3e4633641a40fc73114e08/recipes/recipes/build_from_tarball.py

Project Member

Comment 26 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/040f6fb8e9e4a0835a81068951e42085af36fcf0

commit 040f6fb8e9e4a0835a81068951e42085af36fcf0
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Mar 09 23:31:09 2018

Don't build v8 snapshot when building tarball

The v8_context_snapshot_generator relies on a lot of system libraires to run.
Some of them are not available in the Ubuntu Trusty host system.

BUG=800977
R=mmoss

Change-Id: Ic079a02415e5adf792b9fa4b356d231cfd489fa0
Reviewed-on: https://chromium-review.googlesource.com/957470
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/040f6fb8e9e4a0835a81068951e42085af36fcf0/recipes/recipes/build_from_tarball.expected/basic.json
[modify] https://crrev.com/040f6fb8e9e4a0835a81068951e42085af36fcf0/recipes/recipes/build_from_tarball.py

Project Member

Comment 27 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03910003604f13b0b9cae179991ff722df261aa3

commit 03910003604f13b0b9cae179991ff722df261aa3
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Mar 14 20:11:42 2018

Fix build with unbundled zlib

Linux distros like Gentoo have a philosophy of not statically-linking
dependencies.  The reason is not necessarily to save disk space, but
because they like to compile with their own flags and patches applied.
This CL fixes the zlib unbundle for them.

BUG=800977

Change-Id: I129d95a5a4b6c4183666f712609b2e3f0509526e
Reviewed-on: https://chromium-review.googlesource.com/947464
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543178}
[modify] https://crrev.com/03910003604f13b0b9cae179991ff722df261aa3/third_party/zlib/google/compression_utils.cc

Project Member

Comment 28 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/97a41c29f376cf772ee9c939ffbe4b0f1c516654

commit 97a41c29f376cf772ee9c939ffbe4b0f1c516654
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Mar 16 23:19:15 2018

Increase timeout for Build From Tarball to 80 minutes

By default, builds will stop after 40 minutes with no output.  The Build From
Tarball bot compiles with lto enabled, and sometimes produces no output during
the compile step for more than 40 minutes.  This CL increases the timeout to 80
minutes to prevent the bot from being killed.

BUG=800977
R=dpranke

Change-Id: If1256da6d8b113a375ac17594bd3716fa53d10d0
Reviewed-on: https://chromium-review.googlesource.com/966880
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/97a41c29f376cf772ee9c939ffbe4b0f1c516654/masters/master.chromium.infra.cron/master.cfg

Project Member

Comment 29 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3d30e9d19c1a2b3a69217e5e47d1faf019de223

commit f3d30e9d19c1a2b3a69217e5e47d1faf019de223
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Mar 22 22:30:59 2018

Fix and simplify libjpeg unbundle

third_party/BUILD.gn defines two variables: use_system_libjpeg and
use_libjpeg_turbo.  If use_system_libjpeg is true, then use_libjpeg_turbo is
ignored.  These variables really have a combined 3 states:

* use_system_libjpeg=true: Use the system libjpeg, which might be the turbo or
  regular version of libjpeg, depending on what the user has installed.
* use_system_libjpeg=false,use_libjpeg_turbo=true: Use
  third_party/libjpeg_turbo.
* use_system_libjpeg=false,use_libjpeg_turbo=false: Use third_party/libjpeg.

The current unbundle assumes use_system_libjpeg=false and use_libjpeg_turbo=true
(the defaults) and then rewrites the build file of libjpeg_turbo to use the
system library.  This CL changes the unbundle to be more direct: simply set
use_system_libjpeg=true.  The libjpeg unbundle was broken and
use_system_libjpeg=true was required anyway.

BUG=800977
R=thestig,dpranke
TBR=thakis

Change-Id: I080ab62592007876b3a2e3838cc1a893a383f838
Reviewed-on: https://chromium-review.googlesource.com/974136
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545271}
[modify] https://crrev.com/f3d30e9d19c1a2b3a69217e5e47d1faf019de223/build/linux/unbundle/libjpeg.gn
[modify] https://crrev.com/f3d30e9d19c1a2b3a69217e5e47d1faf019de223/build/linux/unbundle/replace_gn_files.py
[modify] https://crrev.com/f3d30e9d19c1a2b3a69217e5e47d1faf019de223/third_party/BUILD.gn
[add] https://crrev.com/f3d30e9d19c1a2b3a69217e5e47d1faf019de223/third_party/libjpeg.gni

Comment 30 by ebra...@gnu.org, Mar 29 2018

Blocking: 28287

Comment 31 by ebra...@gnu.org, Mar 29 2018

Blockedon: 823808

Comment 32 by ebra...@gnu.org, Mar 29 2018

Cc: ebra...@gnu.org
Project Member

Comment 33 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/cf8a2481c2f56b00bc7551110fe2bd671895722e

commit cf8a2481c2f56b00bc7551110fe2bd671895722e
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Mar 30 19:13:26 2018

Increase timeout for Build From Tarball from 80 minutes to 180 minutes

"Build From Tarball" has been mostly green, but recently had another timeout
[1].  Increase the timeout further to 3 hours.

[1] https://ci.chromium.org/buildbot/chromium.infra.cron/Build%20From%20Tarball/130

BUG=800977
R=dpranke

Change-Id: I52fc6baa959fe81c1029555cdbda040c85e9fb1a
Reviewed-on: https://chromium-review.googlesource.com/988261
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/cf8a2481c2f56b00bc7551110fe2bd671895722e/masters/master.chromium.infra.cron/master.cfg

Project Member

Comment 34 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/3219a00b4ad2f5be6aacfc63c400d4c5f43774a0

commit 3219a00b4ad2f5be6aacfc63c400d4c5f43774a0
Author: Tom Anderson <thomasanderson@google.com>
Date: Fri Mar 30 22:33:21 2018

Comment 35 by ebra...@gnu.org, Mar 31 2018

Just curious, can this cover  Issue 350913  also?
Project Member

Comment 36 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/745a6ceac201f7f7d27d730bae779d02df16ad80

commit 745a6ceac201f7f7d27d730bae779d02df16ad80
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Apr 09 17:38:24 2018

Add CR_SYSROOT_HASH define to force rebuilds on sysroot updates

R=thestig
TBR=thakis
BUG=800977

Change-Id: I1147d171fee32e8ce51c08449a1a50144d5e051b
Reviewed-on: https://chromium-review.googlesource.com/1002986
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549213}
[modify] https://crrev.com/745a6ceac201f7f7d27d730bae779d02df16ad80/build/config/posix/BUILD.gn
[modify] https://crrev.com/745a6ceac201f7f7d27d730bae779d02df16ad80/build/linux/sysroot_scripts/install-sysroot.py

Project Member

Comment 37 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b828d53cbc4e24dc6f84f25e4b83c6082e717982

commit b828d53cbc4e24dc6f84f25e4b83c6082e717982
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Apr 09 22:29:12 2018

Add more unbundle packages to sysroots

The new packages are necessary to test unbundling of flac, libxslt, and zlib.

BUG=800977
R=thestig
TBR=mark

Change-Id: I2c5f88b3819ce000e906cf303fdffa30bdde84cb
Reviewed-on: https://chromium-review.googlesource.com/981451
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549303}
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/packagelist.sid.amd64
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/packagelist.sid.arm
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/packagelist.sid.arm64
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/packagelist.sid.i386
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/packagelist.sid.mips64el
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/packagelist.sid.mipsel
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/sysroot-creator-sid.sh
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/sysroot-creator.sh
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/build/linux/sysroot_scripts/sysroots.json
[modify] https://crrev.com/b828d53cbc4e24dc6f84f25e4b83c6082e717982/third_party/crashpad/crashpad/compat/linux/sys/ptrace.h

Project Member

Comment 38 by bugdroid1@chromium.org, Apr 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/961ea628cff07b24dbd5974288f41a29bd0ab65d

commit 961ea628cff07b24dbd5974288f41a29bd0ab65d
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Mon Apr 09 23:12:12 2018

Revert "Add more unbundle packages to sysroots"

This reverts commit b828d53cbc4e24dc6f84f25e4b83c6082e717982.

Reason for revert: Causing a build failure on Google Chrome Linux x64
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/29741

/b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: exp2f@GLIBC_2.2.5
>>> defined in obj/third_party/swiftshader/src/OpenGL/compiler/swiftshader_opengl_compiler/Intermediate.o
>>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Context.o
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: exp2f@GLIBC_2.2.5
>>> defined in obj/third_party/swiftshader/src/OpenGL/compiler/swiftshader_opengl_compiler/Intermediate.o
>>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Sampler.o
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: powf@GLIBC_2.2.5
>>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Surface.o
>>> defined in obj/third_party/swiftshader/src/Shader/swiftshader_shader/Constants.o
/b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: powf@GLIBC_2.2.5
>>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Surface.o
>>> defined in obj/third_party/swiftshader/src/Common/swiftshader_common/Math.o

Original change's description:
> Add more unbundle packages to sysroots
> 
> The new packages are necessary to test unbundling of flac, libxslt, and zlib.
> 
> BUG=800977
> R=​thestig
> TBR=mark
> 
> Change-Id: I2c5f88b3819ce000e906cf303fdffa30bdde84cb
> Reviewed-on: https://chromium-review.googlesource.com/981451
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549303}

TBR=thakis@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,mark@chromium.org

Change-Id: I90188d22140d7cdd60f8bbea5b0e88705e498988
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 800977
Reviewed-on: https://chromium-review.googlesource.com/1003532
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549314}
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/packagelist.sid.amd64
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/packagelist.sid.arm
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/packagelist.sid.arm64
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/packagelist.sid.i386
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/packagelist.sid.mips64el
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/packagelist.sid.mipsel
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/sysroot-creator-sid.sh
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/sysroot-creator.sh
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/build/linux/sysroot_scripts/sysroots.json
[modify] https://crrev.com/961ea628cff07b24dbd5974288f41a29bd0ab65d/third_party/crashpad/crashpad/compat/linux/sys/ptrace.h

Project Member

Comment 39 by bugdroid1@chromium.org, Apr 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ba724351903202e03ec36af9ec58bd95724a17

commit 02ba724351903202e03ec36af9ec58bd95724a17
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Apr 17 15:04:53 2018

Reland "Revert "Add more unbundle packages to sysroots""

This is a reland of 961ea628cff07b24dbd5974288f41a29bd0ab65d
Chromium r550608 has rolled clang to r329921, which includes the build fix.

Original change's description:
> Revert "Add more unbundle packages to sysroots"
>
> This reverts commit b828d53cbc4e24dc6f84f25e4b83c6082e717982.
>
> Reason for revert: Causing a build failure on Google Chrome Linux x64
> https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/29741
>
> /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: exp2f@GLIBC_2.2.5
> >>> defined in obj/third_party/swiftshader/src/OpenGL/compiler/swiftshader_opengl_compiler/Intermediate.o
> >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Context.o
> /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: exp2f@GLIBC_2.2.5
> >>> defined in obj/third_party/swiftshader/src/OpenGL/compiler/swiftshader_opengl_compiler/Intermediate.o
> >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Sampler.o
> /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: powf@GLIBC_2.2.5
> >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Surface.o
> >>> defined in obj/third_party/swiftshader/src/Shader/swiftshader_shader/Constants.o
> /b/c/b/Google_Chrome_Linux_x64/src/out/Release/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: duplicate symbol: powf@GLIBC_2.2.5
> >>> defined in obj/third_party/swiftshader/src/Renderer/swiftshader_renderer/Surface.o
> >>> defined in obj/third_party/swiftshader/src/Common/swiftshader_common/Math.o
>
> Original change's description:
> > Add more unbundle packages to sysroots
> >
> > The new packages are necessary to test unbundling of flac, libxslt, and zlib.
> >
> > BUG=800977
> > R=​thestig
> > TBR=mark
> >
> > Change-Id: I2c5f88b3819ce000e906cf303fdffa30bdde84cb
> > Reviewed-on: https://chromium-review.googlesource.com/981451
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#549303}
>
> TBR=thakis@chromium.org,thestig@chromium.org,thomasanderson@chromium.org,mark@chromium.org
>
> Change-Id: I90188d22140d7cdd60f8bbea5b0e88705e498988
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 800977
> Reviewed-on: https://chromium-review.googlesource.com/1003532
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549314}

Bug: 800977
Change-Id: I6b5deb3cd3c2d6ab77dfd904eb641744b88d2231
Reviewed-on: https://chromium-review.googlesource.com/1012903
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551339}
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/packagelist.sid.amd64
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/packagelist.sid.arm
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/packagelist.sid.arm64
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/packagelist.sid.i386
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/packagelist.sid.mips64el
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/packagelist.sid.mipsel
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/sysroot-creator-sid.sh
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/sysroot-creator.sh
[modify] https://crrev.com/02ba724351903202e03ec36af9ec58bd95724a17/build/linux/sysroot_scripts/sysroots.json

Sign in to add a comment