New issue
Advanced search Search tips

Issue 800962 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

amd64-generic-telemetry failing with LoginException: Timed out going through login screen.

Project Member Reported by jdufault@chromium.org, Jan 10 2018

Issue description

Failing tests:
- telemetry.internal.browser.extension_unittest.ExtensionTest.testExtensionBasic 
- telemetry.internal.browser.extension_unittest.ExtensionTest.testExtensionGetByExtensionId
- telemetry.internal.browser.extension_unittest.ExtensionTest.testWebApp
- telemetry.internal.browser.extension_unittest.ExtensionTest.testMultipleExtensions

Example failure:
01/10 13:45:56.276 INFO |run_chromeos_tests:0052| [358/1150] telemetry.internal.browser.extension_unittest.ExtensionTest.testWebApp queued
01/10 13:45:56.283 INFO |run_chromeos_tests:0052| [359/1150] telemetry.internal.browser.extension_unittest.ExtensionTest.testWebApp failed unexpectedly 80.8263s:
01/10 13:45:56.285 INFO |run_chromeos_tests:0052|   ExtensionsToLoad: ['ngpdhehecbbicanlekddpcejomggkdno']
01/10 13:45:56.286 INFO |run_chromeos_tests:0052|   Extension list: <telemetry.internal.backends.chrome.extension_backend.ExtensionBackendDict object at 0x789508391a10>
01/10 13:45:56.288 INFO |run_chromeos_tests:0052|   Failed with LoginException while starting the browser backend.
01/10 13:45:56.289 INFO |run_chromeos_tests:0052|   Traceback (most recent call last):
01/10 13:45:56.290 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/extension_unittest.py", line 76, in testWebApp
01/10 13:45:56.291 INFO |run_chromeos_tests:0052|       if not self.CreateBrowserWithExtension('simple_app'):
01/10 13:45:56.292 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/extension_unittest.py", line 38, in CreateBrowserWithExtension
01/10 13:45:56.293 INFO |run_chromeos_tests:0052|       self._browser = browser_to_create.Create(options)
01/10 13:45:56.294 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_finder.py", line 56, in Create
01/10 13:45:56.295 INFO |run_chromeos_tests:0052|       browser_backend, self._platform_backend, startup_args)
01/10 13:45:56.296 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 45, in __init__
01/10 13:45:56.297 INFO |run_chromeos_tests:0052|       self._browser_backend.Start(startup_args, startup_url=startup_url)
01/10 13:45:56.298 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
01/10 13:45:56.299 INFO |run_chromeos_tests:0052|       return func(*args, **kwargs)
01/10 13:45:56.300 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 182, in Start
01/10 13:45:56.301 INFO |run_chromeos_tests:0052|       + self._GetLoginStatus())
01/10 13:45:56.302 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
01/10 13:45:56.303 INFO |run_chromeos_tests:0052|       return func(*args, **kwargs)
01/10 13:45:56.304 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py", line 301, in _RaiseOnLoginFailure
01/10 13:45:56.304 INFO |run_chromeos_tests:0052|       raise exceptions.LoginException(error)
01/10 13:45:56.305 INFO |run_chromeos_tests:0052|   LoginException: Timed out going through login screen. 

The failures started in https://luci-milo.appspot.com/buildbot/chromiumos.chromium/amd64-generic-telemetry/13683
 
Components: Tests>Telemetry
Labels: -Pri-3 OS-Chrome Pri-1
Owner: perezju@chromium.org
Status: Assigned (was: Untriaged)
I suspect https://chromium.googlesource.com/catapult.git/+/4e95faaa533b077604929c36bb6c77015c3c5c4d since it seems similar to the failing test cases.
Yep, confirmed this is me, and doesn't have an easy fix. Reverting for now.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/2c400a6bb32dff0ef61f3345d041ff5266bb3a1c

commit 2c400a6bb32dff0ef61f3345d041ff5266bb3a1c
Author: Juan Antonio Navarro Pérez <perezju@chromium.org>
Date: Thu Jan 11 10:12:33 2018

Revert "[Telemetry] Move --load-extension to chrome_startup_args module"

This reverts commit 4e95faaa533b077604929c36bb6c77015c3c5c4d.

Reason for revert: broke cros backend

Original change's description:
> [Telemetry] Move --load-extension to chrome_startup_args module
> 
> Move the last bit of startup args computation out of
> chrome_browser_backend and into chrome_startup_args.
> 
> Follow up CLs will migrate the corresponding methods for each of
> android, desktop and cros browser-backends.
> 
> Bug:  chromium:787834 
> Change-Id: Ib8bd7c9463075a5459fc83b14113491d970ddb9f
> Reviewed-on: https://chromium-review.googlesource.com/857462
> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>

TBR=achuith@chromium.org,perezju@chromium.org,nednguyen@google.com

Change-Id: I9f58250920e164ba850fc5068d2f638612c0f7ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:787834 
Bug:  chromium:800962 
Reviewed-on: https://chromium-review.googlesource.com/860107
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/2c400a6bb32dff0ef61f3345d041ff5266bb3a1c/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py
[modify] https://crrev.com/2c400a6bb32dff0ef61f3345d041ff5266bb3a1c/telemetry/telemetry/internal/backends/chrome/chrome_startup_args.py

Status: Fixed (was: Assigned)

Sign in to add a comment