Some build warnings for the media team to take a look at:


../../media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:213: warning: [Finally] If you return or throw from a finally, then values returned or thrown from the try-catch block will be ignored. Consider usin g try-with-resources instead.
                return capturedData;
                ^
    (see http://errorprone.info/bugpattern/Finally)





../../media/base/android/java/src/org/chromium/media/AudioRecordInput.java:87: warning: [ThreadJoinLoop] Thread.join needs to be surrounded by a loop until it succeeds, as in Uninterruptibles.joinUninterruptibly.
                    join();
                        ^
    (see http://errorprone.info/bugpattern/ThreadJoinLoop)
  Did you mean 'Uninterruptibles.joinUninterruptibly(this);'?




../../media/base/android/java/src/org/chromium/media/AudioTrackOutputStream.java:119: warning: [deprecation] AudioTrack(int,int,int,int,int,int) in AudioTrack has been deprecated
                return new AudioTrack(streamType, sampleRateInHz, channelConfig, audioFormat,
                       ^




../../media/base/android/java/src/org/chromium/media/MediaDrmSessionManager.java:75: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' 
in many environments
            byte[] emeId = UUID.randomUUID().toString().replace('-', '0').getBytes();
                                                                                  ^
    (see http://errorprone.info/bugpattern/DefaultCharset)
  Did you mean 'byte[] emeId = UUID.randomUUID().toString().replace('-', '0').getBytes(UTF_8);' or 'byte[] emeId = UUID.randomUUID().toString().replace('-', '0').getBytes(Charset.defaultCharset());'?




../../media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:1296: warning: [deprecation] EVENT_KEY_EXPIRE
D in MediaDrm has been deprecated
                case MediaDrm.EVENT_KEY_EXPIRED:
                             ^



../../media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:74: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments
    private static final byte[] UNPROVISION = "unprovision".getBytes();
                                                                    ^
    (see http://errorprone.info/bugpattern/DefaultCharset)
  Did you mean 'private static final byte[] UNPROVISION = "unprovision".getBytes(UTF_8);' or 'private static final byte[] UNPROVISION = "unprovision".getBytes(Charset.defaultCharset());'?




../../media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java:245: warning: [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments
                InputStream stream = new ByteArrayInputStream(mData.getBytes());
                                                                            ^
    (see http://errorprone.info/bugpattern/DefaultCharset)
  Did you mean 'InputStream stream = new ByteArrayInputStream(mData.getBytes(UTF_8));' or 'InputStream stream = new ByteArrayInputStream(mData.getBytes(Charset.defaultCharset()));'?