New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 800953 link

Starred by 3 users
Status: Fixed
Owner:
█ roc...@chromium.org
please use my google.com address
Closed: Jan 2018
Cc:
sa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

nacl_loader should expose chrome::mojom::ResourceUsageReporter interface to content_browser

Project Member Reported by w...@chromium.org, Jan 10 2018 
Chrome Version: 65.0.3317.1 w/ DCHECKs enabled
OS: Windows 10

What steps will reproduce the problem?
(1) Run SyzyASAN Canary w/ DCHECKs enabled.
(2) Launch Chrome Remote Desktop.
(3) Open Task Manager.

What is the expected result?

Expect that Task Manager opens.

What happens instead?

Chrome hits a ServiceManager DCHECK:

[13608:13908:0110/142823.087:FATAL:service_manager.cc(154)] Check failed: false. The Service Manager prevented service "content_browser" from binding interface "chrome::mojom::ResourceUsageReporter" in target service "nacl_loader". You probably need to update one or more service manifests to ensure that "nacl_loader" exposes "chrome::mojom::ResourceUsageReporter" through a capability and that "content_browser" requires that capability from the "nacl_loader" service..

Comment 1 by w...@chromium.org, Jan 10 2018

Labels: Hotlist-Dcheck-Albatross
See crash report bc7a9a834a90e2d4 for an example of this firing.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62facf9202434f6e6a033e8ece321920f93d8da9

commit 62facf9202434f6e6a033e8ece321920f93d8da9
Author: Ken Rockot <rockot@chromium.org>
Date: Thu Jan 11 17:13:03 2018

Add ResourceUsageReporter to nacl_loader manifest

Chrome binds and implements this interface in any child process type, but
the Service Manager DCHECKs if the hosted service doesn't explicitly
allow access to the interface within its manifest.

This adds the interface to nacl_loader's manifest so that all may be
right in the world.

TBRing NaCl owners since the change isn't really relevant to NaCl per se.

Bug:  800953 
Change-Id: I8be9b441feabc4e30bdf199275f1a69023b29d91
TBR: bradnelson@chromium.org
R: wez@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/861061
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528651}
[modify] https://crrev.com/62facf9202434f6e6a033e8ece321920f93d8da9/components/nacl/loader/nacl_loader_manifest.json

Comment 3 by w...@chromium.org, Jan 11 2018 

Issue 801080 has been merged into this issue.

Comment 4 by w...@chromium.org, Jan 11 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment