New issue
Advanced search Search tips

Issue 800947 link

Starred by 1 user
Status: Verified
Owner:
zmin@chromium.org
Closed: Feb 2018
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Force sign in local error message is not displayed properly

Project Member Reported by zmin@chromium.org, Jan 10 2018 
Chrome Version: M65

What steps will reproduce the problem?
(1) Open Chrome on clean user data dir and close
(2) Enabled force sign in
(3) Click the default browser, Chrome shows the error message.
(4) Close the error message, click "Add Person", close the sign in dialog
(5) Click the previous profile

What is the expected result?
The error message in (3) displayed again

What happens instead?
The error page is displayed with empty error message string.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2232cbe4f82bb91243b066e0fda01068682ac8d

commit c2232cbe4f82bb91243b066e0fda01068682ac8d
Author: Owen Min <zmin@chromium.org>
Date: Thu Jan 11 22:27:32 2018

Fix the issue that sign in path in UserManager is not set properly.

Set the path properly so that the error message can be displayed
without browsering window.

If the sign in is blocked at the very beginning, reset the path.
If the sign in error needs to be displayed without browser,
set the path to the selected profile.

Bug:  800947 
Change-Id: I545bd31c8a3a6b673aaa22687191392a4a0c58d1
Reviewed-on: https://chromium-review.googlesource.com/861202
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528784}
[modify] https://crrev.com/c2232cbe4f82bb91243b066e0fda01068682ac8d/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm
[modify] https://crrev.com/c2232cbe4f82bb91243b066e0fda01068682ac8d/chrome/browser/ui/user_manager.h
[modify] https://crrev.com/c2232cbe4f82bb91243b066e0fda01068682ac8d/chrome/browser/ui/views/profiles/user_manager_view.cc
[modify] https://crrev.com/c2232cbe4f82bb91243b066e0fda01068682ac8d/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

Comment 2 by brajkumar@chromium.org, Jan 12 2018

Labels: TE-Verified-M65 TE-Verified-65.0.3319.0
Verified this issue on Windows-10 using chrome latest canary #65.0.3319.0 by following steps mentioned in the original comment. Observed the error message string is displayed while opening the first profile after step-4. Hence adding TE-Verified label for M65.

Thanks!
800947.mp4
2.9 MB View Download

Comment 3 by zmin@chromium.org, Feb 27 2018

Status: Verified (was: Assigned)
►

Sign in to add a comment