New issue
Advanced search Search tips

Issue 800945 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on: View detail
issue 812085
issue 864700
issue 809793
issue 810169
issue 810575
issue 811619
issue 812724
issue 812725
issue 818075
issue 824453
issue 834873
issue 834994
issue 834998
issue 852844
issue 861915
issue 873340

Blocking:
issue 777293



Sign in to add a comment

Tracking issue for wallpaper picker redesign

Project Member Reported by wzang@chromium.org, Jan 10 2018

Issue description

The Wallpaper picker redesign has two main components:

1) Integer with the Backdrop wallpaper backend service, currently used by Android.

2) Redesign the UI. A preview can be found at https://docs.google.com/presentation/d/1fMerzd5yHbFESORDW58fQUo5inA0nWXPM7oUqadN-gE/edit#slide=id.g273dca9ebd_0_0
 

Comment 1 by wzang@chromium.org, Jan 10 2018

Blocking: 777293
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbdcdd757fdba8d12ac1024e7c417faf8ea5feb3

commit bbdcdd757fdba8d12ac1024e7c417faf8ea5feb3
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Jan 11 18:37:41 2018

cros: Create switch for the redesigned wallpaper picker

The redesigned wallpaper picker is mainly on UI changes ([1]). So we
want to reuse the existing code and only modify the styles.

Add some basic rules in this CL. There'll be follow-up CLs.

[1] Slides for reference:
https://docs.google.com/presentation/d/1fMerzd5yHbFESORDW58fQUo5inA0nWXPM7oUqadN-gE

Bug:  800945 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1ca4d7d2238f6cb9c892aaff3e059d8ab627ba07
Reviewed-on: https://chromium-review.googlesource.com/861422
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528678}
[modify] https://crrev.com/bbdcdd757fdba8d12ac1024e7c417faf8ea5feb3/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/bbdcdd757fdba8d12ac1024e7c417faf8ea5feb3/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[modify] https://crrev.com/bbdcdd757fdba8d12ac1024e7c417faf8ea5feb3/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/bbdcdd757fdba8d12ac1024e7c417faf8ea5feb3/chromeos/chromeos_switches.cc
[modify] https://crrev.com/bbdcdd757fdba8d12ac1024e7c417faf8ea5feb3/chromeos/chromeos_switches.h

Components: UI>Shell>Wallpaper

Comment 4 by wzang@chromium.org, Jan 19 2018

Description: Show this description
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c7a9d9fa38d5ef93c72964e618cd387135331bf

commit 5c7a9d9fa38d5ef93c72964e618cd387135331bf
Author: Wenzhao Zang <wzang@chromium.org>
Date: Mon Jan 29 21:49:52 2018

cros: Integrate wallpaper picker with Backdrop service

1. |CollectionInfoFetcher| is responsible to download and
   deserialize the proto related to the collection info from
   Backdrop wallpaper service. |ImageInfoFetcher| is responsible
   to fetch the image specific information belonging to each particular
   collection.

2. wallpaper_manager.js fetches the list of the collection info via
   extension API and displays them in the category column. After that
   point, it uses lazy loading for each collection: it fetches the
   image info for each collection only after the user clicks on it.

Bug:  800945 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I520660ceb821b1f57fd349d0cdb87e12c1ec0ca5
Reviewed-on: https://chromium-review.googlesource.com/877580
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532602}
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/chromeos/BUILD.gn
[add] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/chromeos/extensions/backdrop_wallpaper_handlers/backdrop_wallpaper.proto
[add] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/chromeos/extensions/backdrop_wallpaper_handlers/backdrop_wallpaper_handlers.cc
[add] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/chromeos/extensions/backdrop_wallpaper_handlers/backdrop_wallpaper_handlers.h
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/chromeos/extensions/wallpaper_manager_util.cc
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/chromeos/extensions/wallpaper_manager_util.h
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/chromeos/extensions/wallpaper_private_api.h
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/chrome/common/extensions/api/wallpaper_private.json
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/5c7a9d9fa38d5ef93c72964e618cd387135331bf/tools/metrics/histograms/enums.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/317c7b55e9783201af3fca42c308327294074518

commit 317c7b55e9783201af3fca42c308327294074518
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Feb 03 03:15:24 2018

cros: Enable the new wallpaper picker to display images

The new wallpaper picker has two main differences with the old one:

1) The images are fetched from a different server (it's already
   implemented in backdrop_wallpaper_handlers).

2) The style changes. The general logic in *.js files are the same,
   so we prefer to reuse the existing code and add flag checks here and
   there. (We'll be able to clean up the code only used by the old
   picker when it's mature.)

Bug:  800945 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icf48369e86644046fee0f220a212661daefa495d
Reviewed-on: https://chromium-review.googlesource.com/898205
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534252}
[modify] https://crrev.com/317c7b55e9783201af3fca42c308327294074518/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[modify] https://crrev.com/317c7b55e9783201af3fca42c308327294074518/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js
[modify] https://crrev.com/317c7b55e9783201af3fca42c308327294074518/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
[modify] https://crrev.com/317c7b55e9783201af3fca42c308327294074518/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/408acd921a68fc78299f07e846c3999766500eb0

commit 408acd921a68fc78299f07e846c3999766500eb0
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Feb 06 08:03:58 2018

cros: Add top header to the new wallpaper picker

Add the top info header and add the basic functionality to set the new
collection of wallpapers. The CSS style needs further changes.
(A comparison between the mock and the layout up to this CL is in [1].)

[1] https://goo.gl/zJoaLc

Bug:  800945 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7b229b5e1584fb41e7f885179e8c4f78e6b86b1
Reviewed-on: https://chromium-review.googlesource.com/902329
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534658}
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/resources/chromeos/wallpaper_manager/js/constants.js
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/resources/chromeos/wallpaper_manager/js/util.js
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/resources/chromeos/wallpaper_manager/main.html
[modify] https://crrev.com/408acd921a68fc78299f07e846c3999766500eb0/chrome/browser/resources/chromeos/wallpaper_manager/manifest.json

Comment 8 by wzang@chromium.org, Feb 7 2018

Blockedon: 809793

Comment 9 by wzang@chromium.org, Feb 7 2018

Blockedon: 810169
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0aa4710de34b1b785ca08775b400390d9f641a98

commit 0aa4710de34b1b785ca08775b400390d9f641a98
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Feb 08 22:11:14 2018

cros: Support all languages on new wallpaper picker

This is similar to BackdropFetcher.java in google3.

      changing locale.

Bug:  800945 
Test: On device, the wallpaper picker can show different languages after
Change-Id: Ifec66defb695933bcbc504025710eadca9e2fb13
Reviewed-on: https://chromium-review.googlesource.com/909789
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535541}
[modify] https://crrev.com/0aa4710de34b1b785ca08775b400390d9f641a98/chrome/browser/chromeos/extensions/backdrop_wallpaper_handlers/backdrop_wallpaper_handlers.cc

Blockedon: 810575

Comment 12 by wzang@chromium.org, Feb 13 2018

Blockedon: 811619

Comment 13 by wzang@chromium.org, Feb 14 2018

Blockedon: 812085

Comment 14 by wzang@chromium.org, Feb 15 2018

Blockedon: 812724

Comment 15 by wzang@chromium.org, Feb 15 2018

Blockedon: 812725
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cd94a51ed7f3a9a2030a751f6f1dc942d6e8790

commit 0cd94a51ed7f3a9a2030a751f6f1dc942d6e8790
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Feb 17 20:22:49 2018

cros: Update new wallpaper picker UI (Part I)

This CL makes the new wallpaper picker fully usable. There're some
corner cases that haven't been determined by UX and they are explicitly
marked as 'TODO'.

Mock: goo.gl/kGgEVr
Spec:
https://drive.google.com/file/d/1nxrxAmlXOMp50IkGFGNobmIS-QpkYtLY/view

Bug:  800945 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I396e5727e2f564623163424de05e86be8ecb4cb0
Reviewed-on: https://chromium-review.googlesource.com/917215
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537551}
[modify] https://crrev.com/0cd94a51ed7f3a9a2030a751f6f1dc942d6e8790/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[modify] https://crrev.com/0cd94a51ed7f3a9a2030a751f6f1dc942d6e8790/chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
[modify] https://crrev.com/0cd94a51ed7f3a9a2030a751f6f1dc942d6e8790/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_images_grid.js
[modify] https://crrev.com/0cd94a51ed7f3a9a2030a751f6f1dc942d6e8790/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/0cd94a51ed7f3a9a2030a751f6f1dc942d6e8790/chrome/browser/resources/chromeos/wallpaper_manager/main.html

Project Member

Comment 17 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06a28877ccbd466ea4cdf6187b82aaa25a31dc3d

commit 06a28877ccbd466ea4cdf6187b82aaa25a31dc3d
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Feb 23 04:01:35 2018

cros: Add new wallpaper picker to experimental flags

The flag helps UX/PM to review the new picker.

Bug:  800945 
Change-Id: Ie8357057f14a4a5908c5cb6af9ee43b60bb45c9a
Reviewed-on: https://chromium-review.googlesource.com/927113
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538695}
[modify] https://crrev.com/06a28877ccbd466ea4cdf6187b82aaa25a31dc3d/chrome/browser/about_flags.cc
[modify] https://crrev.com/06a28877ccbd466ea4cdf6187b82aaa25a31dc3d/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/06a28877ccbd466ea4cdf6187b82aaa25a31dc3d/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/06a28877ccbd466ea4cdf6187b82aaa25a31dc3d/tools/metrics/histograms/enums.xml

Blockedon: 818075

Comment 19 by wzang@chromium.org, Mar 21 2018

Blockedon: 824453
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/951f2814e99fb1b8c1c6aae949e63fb629c446c6

commit 951f2814e99fb1b8c1c6aae949e63fb629c446c6
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Apr 13 21:04:01 2018

cros: Update new wallpaper picker UI (Part II)

Spec:
https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

Bug:  800945 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9035fb027b998a71af6312a4365c5c85193dbcec
Reviewed-on: https://chromium-review.googlesource.com/982818
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550761}
[modify] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/2x/button_close.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/2x/button_minimize.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/2x/no_images_illustration.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/button_close.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/button_minimize.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/center_cropped_layout.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/center_cropped_layout_disabled.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/center_layout.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/center_layout_disabled.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/current_wallpaper_explore.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/current_wallpaper_refresh.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/left_arrow.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/no_images_illustration.png
[modify] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
[modify] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/main.html

Project Member

Comment 21 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/951f2814e99fb1b8c1c6aae949e63fb629c446c6

commit 951f2814e99fb1b8c1c6aae949e63fb629c446c6
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Apr 13 21:04:01 2018

cros: Update new wallpaper picker UI (Part II)

Spec:
https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

Bug:  800945 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9035fb027b998a71af6312a4365c5c85193dbcec
Reviewed-on: https://chromium-review.googlesource.com/982818
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#550761}
[modify] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/css/wallpaper_manager.css
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/2x/button_close.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/2x/button_minimize.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/2x/no_images_illustration.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/button_close.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/button_minimize.png
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/center_cropped_layout.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/center_cropped_layout_disabled.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/center_layout.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/center_layout_disabled.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/current_wallpaper_explore.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/current_wallpaper_refresh.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/left_arrow.svg
[add] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/images/ui/no_images_illustration.png
[modify] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
[modify] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/js/wallpaper_manager.js
[modify] https://crrev.com/951f2814e99fb1b8c1c6aae949e63fb629c446c6/chrome/browser/resources/chromeos/wallpaper_manager/main.html

Comment 22 by wzang@chromium.org, Apr 19 2018

Blockedon: 834873

Comment 23 by wzang@chromium.org, Apr 19 2018

Blockedon: 834998

Comment 24 by wzang@chromium.org, Apr 19 2018

Blockedon: 834994

Comment 25 by wzang@chromium.org, Jun 14 2018

Blockedon: 852844

Comment 26 by wzang@chromium.org, Jun 26 2018

Labels: -M-66 M-69
Project Member

Comment 27 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41cfb89f45d8f60aee2941c0d94ea77ce97f680e

commit 41cfb89f45d8f60aee2941c0d94ea77ce97f680e
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Jun 26 04:27:46 2018

cros: Convert new wallpaper picker to feature and enable by default

May control this with a Finch flag later.

Bug:  800945 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Idfaa09501781398a805d8b4ae0453538d7a5ee4b
Reviewed-on: https://chromium-review.googlesource.com/1099999
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570331}
[modify] https://crrev.com/41cfb89f45d8f60aee2941c0d94ea77ce97f680e/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/41cfb89f45d8f60aee2941c0d94ea77ce97f680e/ash/public/cpp/ash_features.h
[modify] https://crrev.com/41cfb89f45d8f60aee2941c0d94ea77ce97f680e/chrome/browser/about_flags.cc
[modify] https://crrev.com/41cfb89f45d8f60aee2941c0d94ea77ce97f680e/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/41cfb89f45d8f60aee2941c0d94ea77ce97f680e/chrome/browser/resources/chromeos/wallpaper_manager/js/event_page.js
[modify] https://crrev.com/41cfb89f45d8f60aee2941c0d94ea77ce97f680e/chromeos/chromeos_switches.cc
[modify] https://crrev.com/41cfb89f45d8f60aee2941c0d94ea77ce97f680e/chromeos/chromeos_switches.h
[modify] https://crrev.com/41cfb89f45d8f60aee2941c0d94ea77ce97f680e/tools/metrics/histograms/enums.xml

Blockedon: 861915
Blockedon: 864700
Blockedon: 873340
Project Member

Comment 32 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3b25596c17db65441cfbc343ba95ee5d5b37588

commit b3b25596c17db65441cfbc343ba95ee5d5b37588
Author: Wenzhao Zang <wzang@chromium.org>
Date: Fri Aug 31 01:19:38 2018

cros: Disable new wallpaper picker for M69

The plan is to ship all tablet features together in M70. This CL will
be merged to M69 and reverted in M70.

Bug:  800945 
Change-Id: I8ca2adb4b8b0c1715d7229f48bb521d0dd3ed35b
Reviewed-on: https://chromium-review.googlesource.com/1198523
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587898}
[modify] https://crrev.com/b3b25596c17db65441cfbc343ba95ee5d5b37588/ash/public/cpp/ash_features.cc

Project Member

Comment 33 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8183e3d7f504ef6158827f1a1b0fd5392811725

commit c8183e3d7f504ef6158827f1a1b0fd5392811725
Author: Wenzhao (Colin) Zang <wzang@chromium.org>
Date: Fri Aug 31 01:40:42 2018

Revert "cros: Disable new wallpaper picker for M69"

This reverts commit b3b25596c17db65441cfbc343ba95ee5d5b37588.

Reason for revert: Re-enable in M70.

Original change's description:
> cros: Disable new wallpaper picker for M69
> 
> The plan is to ship all tablet features together in M70. This CL will
> be merged to M69 and reverted in M70.
> 
> Bug:  800945 
> Change-Id: I8ca2adb4b8b0c1715d7229f48bb521d0dd3ed35b
> Reviewed-on: https://chromium-review.googlesource.com/1198523
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587898}

TBR=xiyuan@chromium.org,wzang@chromium.org

Change-Id: Iaf353081adb041d9b5df6aee2642e6cfa8e092ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  800945 
Reviewed-on: https://chromium-review.googlesource.com/1198487
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587905}
[modify] https://crrev.com/c8183e3d7f504ef6158827f1a1b0fd5392811725/ash/public/cpp/ash_features.cc

Labels: Merge-Request-69
Requesting merge for CL in #32, which disables the feature in M69.
Project Member

Comment 35 by sheriffbot@chromium.org, Sep 4

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)

Sign in to add a comment