Change bugdroid to Play prism in Settings |
|||||||||
Issue descriptionBugdroid icon next to "Google Play Store" should be play prism in MD Settings sidebar.
,
Jan 11 2018
+stevenjb -- will you be able to swap this CrOS-only asset? @Elizabeth/Jenn, should we take the "play prism" icon from here? https://icons.googleplex.com/#icon=ic_play_prism&search=play
,
Jan 11 2018
Sure, it should be straightfoward to swap out the image.
,
Jan 12 2018
Please use the attached icons.
,
Jan 12 2018
,
Jan 19 2018
,
Jan 31 2018
Apologies, I forgot about this. The Settings icons are all a single size, 24x24. These are 20x20 and 40x40. (I thought we had an open issue to support 2x icons in Settings, but I couldn't quickly find it. It will be a fair bit of work which is why it's been put off).
,
Feb 6 2018
Since the icon in https://icons.googleplex.com/#icon=ic_play_prism&search=play looks identical (to me) other than the color which I can grab from the assets in comment #4, I will go ahead and grab the 24x24 version of that and use it.
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6d2c9a258f0a731ead5847b870e1383137076d0 commit d6d2c9a258f0a731ead5847b870e1383137076d0 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Feb 06 02:48:29 2018 Settings menu: Use google play store prism icon Note: This section and icon is CrOS only. Bug: 800931 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0a56d90f5db67fa564bad083469310cf5d87bb90 Reviewed-on: https://chromium-review.googlesource.com/903186 Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534604} [modify] https://crrev.com/d6d2c9a258f0a731ead5847b870e1383137076d0/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/d6d2c9a258f0a731ead5847b870e1383137076d0/chrome/browser/resources/settings/settings_menu/settings_menu.html
,
Feb 6 2018
SGTM, thanks Steven!
,
Feb 7 2018
,
Feb 8 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75cded4921013bc0bb134f811cd8a2e89e1f742f commit 75cded4921013bc0bb134f811cd8a2e89e1f742f Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Feb 08 22:24:48 2018 Settings menu: Use google play store prism icon Note: This section and icon is CrOS only. TBR=stevenjb@chromium.org (cherry picked from commit d6d2c9a258f0a731ead5847b870e1383137076d0) Bug: 800931 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0a56d90f5db67fa564bad083469310cf5d87bb90 Reviewed-on: https://chromium-review.googlesource.com/903186 Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#534604} Reviewed-on: https://chromium-review.googlesource.com/909863 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#391} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/75cded4921013bc0bb134f811cd8a2e89e1f742f/chrome/browser/resources/settings/icons.html [modify] https://crrev.com/75cded4921013bc0bb134f811cd8a2e89e1f742f/chrome/browser/resources/settings/settings_menu/settings_menu.html |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jennschen@chromium.org
, Jan 10 2018