[css-typed-om] CSSNumericValue.to should return CSSUnitValue |
|||
Issue description
Currently the IDL for CSSNumericValue says:
[RaisesException, NewObject] CSSNumericValue to(DOMString unit);
But based on the resolution in https://github.com/w3c/css-houdini-drafts/issues/525, it should say:
[RaisesException, NewObject] CSSUnitValue to(DOMString unit);
,
Jan 11 2018
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1464e1e9de118a15faedff56c282f5105a0ef5c3 commit 1464e1e9de118a15faedff56c282f5105a0ef5c3 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Fri Jan 12 02:46:08 2018 [css-typed-om] CSSNumericValue.to should return CSSUnitValue CSSNumericValue.toSum returns a CSSMathSum and not a CSSNumericValue. so CSSNumericValue.to should return CSSUnitValue for consistency. https://github.com/w3c/css-houdini-drafts/issues/525 Bug: 800927 Change-Id: I8fe800f224367943a060e8ef422405f8007eaa77 Reviewed-on: https://chromium-review.googlesource.com/861690 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#528861} [modify] https://crrev.com/1464e1e9de118a15faedff56c282f5105a0ef5c3/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.cpp [modify] https://crrev.com/1464e1e9de118a15faedff56c282f5105a0ef5c3/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.h [modify] https://crrev.com/1464e1e9de118a15faedff56c282f5105a0ef5c3/third_party/WebKit/Source/core/css/cssom/CSSNumericValue.idl
,
Jan 12 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by hs1217....@samsung.com
, Jan 11 2018