Ads blocked bubble UI on Mac "Learn more" link is broken |
|||||||
Issue descriptionClicking does nothing, I suspect this is related to the (?) icon refactor on the non-Mac UIs.
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4869baace5e088c8f6a2ecc08bee69d32fe0b4da commit 4869baace5e088c8f6a2ecc08bee69d32fe0b4da Author: shivanisha <shivanisha@chromium.org> Date: Thu Jan 11 20:05:27 2018 Fix the handling when Learn more link is clicked in subresource filter. This CL fixes the handling of learn more link in mac UI for subresource filter. TEST=browser_tests --gtest_filter=ContentSettingBubbleControllerTest. LearnMoreLinkClicked Also verified manually using --disable-features=SecondaryUiMd. Without the flag it is working fine as well. Bug: 800917 Change-Id: I363cd052858ac78f9d9ae666f9d1719cdaabb92c Reviewed-on: https://chromium-review.googlesource.com/860761 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#528723} [modify] https://crrev.com/4869baace5e088c8f6a2ecc08bee69d32fe0b4da/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm [modify] https://crrev.com/4869baace5e088c8f6a2ecc08bee69d32fe0b4da/chrome/browser/ui/cocoa/subresource_filter/subresource_filter_bubble_controller.mm
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ec17ec740a99dd15c1f5cddd4db2d55928155a4 commit 3ec17ec740a99dd15c1f5cddd4db2d55928155a4 Author: shivanisha <shivanisha@chromium.org> Date: Thu Jan 11 21:38:33 2018 Mac: Fix test for subresource filter learn more link click The CL fixes the browser test landed in https://chromium-review.googlesource.com/c/chromium/src/+/860761 such that it now matches the correct URL string that the page opens when learn more link is clicked. Earlier the test succeeded because both URLs matched were empty since the last navigation did not commit and converting an invalid string to URL also resulted in an empty URL. Bug: 800917 Change-Id: I87797844d237f3bb46df8261537f3af7f010f7a1 Reviewed-on: https://chromium-review.googlesource.com/862466 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#528764} [modify] https://crrev.com/3ec17ec740a99dd15c1f5cddd4db2d55928155a4/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm
,
Jan 16 2018
,
Jan 16 2018
Added Merge-Request-64. This is a low impact change. The "learn more" link on Mac UI previously did not do anything and after the fix it is landing on a help page.
,
Jan 16 2018
Sorry, in comment 5 I meant low risk , not low-impact.
,
Jan 16 2018
This bug requires manual review: We are only 6 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 16 2018
,
Jan 16 2018
Seems like a fairly low risk change; approving merge to M64. Branch:3282
,
Jan 16 2018
Thanks. Merged into 3282.
,
Jan 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b3f2eb34745ef0ef2ac0fc34615534c83fd5708 commit 8b3f2eb34745ef0ef2ac0fc34615534c83fd5708 Author: shivanisha <shivanisha@chromium.org> Date: Tue Jan 16 20:21:30 2018 Fix the handling when Learn more link is clicked in subresource filter. This CL fixes the handling of learn more link in mac UI for subresource filter. TEST=browser_tests --gtest_filter=ContentSettingBubbleControllerTest. LearnMoreLinkClicked Also verified manually using --disable-features=SecondaryUiMd. Without the flag it is working fine as well. Bug: 800917 Change-Id: I363cd052858ac78f9d9ae666f9d1719cdaabb92c Reviewed-on: https://chromium-review.googlesource.com/860761 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#528723}(cherry picked from commit 4869baace5e088c8f6a2ecc08bee69d32fe0b4da) Reviewed-on: https://chromium-review.googlesource.com/868262 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#511} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/8b3f2eb34745ef0ef2ac0fc34615534c83fd5708/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm [modify] https://crrev.com/8b3f2eb34745ef0ef2ac0fc34615534c83fd5708/chrome/browser/ui/cocoa/subresource_filter/subresource_filter_bubble_controller.mm
,
Jan 19 2018
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/655a80494906c5f19e44743f2f3e313b8cd9d006 commit 655a80494906c5f19e44743f2f3e313b8cd9d006 Author: shivanisha <shivanisha@chromium.org> Date: Mon Jan 22 16:53:24 2018 Mac UI: Test Ads "Learn More" link with SecondaryUiMd code path This CL adds a test to check the "Learn More" link in the ads bubble when using the SecondaryUiMd code path. The test for non-SecondaryUiMd code path was added in https://chromium-review.googlesource.com/c/chromium/src/+/860761 AdsLearnMoreLinkClicked Bug: 800917 TEST: browser_tests --gtest_filter=ContentSettingImageModelBrowserTest. Change-Id: Iec3055a22a7da6b551ce7e46cde57ee8735f3185 Reviewed-on: https://chromium-review.googlesource.com/864906 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#530889} [modify] https://crrev.com/655a80494906c5f19e44743f2f3e313b8cd9d006/chrome/browser/ui/content_settings/content_setting_image_model_browsertest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by csharrison@chromium.org
, Jan 11 2018