New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800917 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Ads blocked bubble UI on Mac "Learn more" link is broken

Project Member Reported by csharrison@chromium.org, Jan 10 2018

Issue description

Clicking does nothing, I suspect this is related to the (?) icon refactor on the non-Mac UIs.
 
Only broken without the SecondaryUiMd feature, which unfortunately is not launching in M64.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4869baace5e088c8f6a2ecc08bee69d32fe0b4da

commit 4869baace5e088c8f6a2ecc08bee69d32fe0b4da
Author: shivanisha <shivanisha@chromium.org>
Date: Thu Jan 11 20:05:27 2018

Fix the handling when Learn more link is clicked in subresource filter.

This CL fixes the handling of learn more link in mac UI for subresource
filter.

TEST=browser_tests --gtest_filter=ContentSettingBubbleControllerTest.
LearnMoreLinkClicked
Also verified manually using --disable-features=SecondaryUiMd. Without
the flag it is working fine as well.

Bug:  800917 
Change-Id: I363cd052858ac78f9d9ae666f9d1719cdaabb92c
Reviewed-on: https://chromium-review.googlesource.com/860761
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528723}
[modify] https://crrev.com/4869baace5e088c8f6a2ecc08bee69d32fe0b4da/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm
[modify] https://crrev.com/4869baace5e088c8f6a2ecc08bee69d32fe0b4da/chrome/browser/ui/cocoa/subresource_filter/subresource_filter_bubble_controller.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ec17ec740a99dd15c1f5cddd4db2d55928155a4

commit 3ec17ec740a99dd15c1f5cddd4db2d55928155a4
Author: shivanisha <shivanisha@chromium.org>
Date: Thu Jan 11 21:38:33 2018

Mac: Fix test for subresource filter learn more link click

The CL fixes the browser test landed in
https://chromium-review.googlesource.com/c/chromium/src/+/860761
such that it now matches the correct URL string that the page opens when
learn more link is clicked. Earlier the test succeeded because both URLs
matched were empty since the last navigation did not commit and
converting an invalid string to URL also resulted in an empty URL.

Bug:  800917 
Change-Id: I87797844d237f3bb46df8261537f3af7f010f7a1
Reviewed-on: https://chromium-review.googlesource.com/862466
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528764}
[modify] https://crrev.com/3ec17ec740a99dd15c1f5cddd4db2d55928155a4/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm

Labels: Merge-Request-64
Added Merge-Request-64.
This is a low impact change. The "learn more" link on Mac UI previously did not do anything and after the fix it is landing on a help page.
Sorry, in comment 5 I meant low risk , not low-impact.
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 16 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -shivanisha@chromium.org csharrison@chromium.org
Owner: shivanisha@chromium.org
Cc: tapted@chromium.org shrike@chromium.org
Labels: -Merge-Review-64 Merge-Approved-64
Seems like a fairly low risk change; approving merge to M64. Branch:3282
Thanks. Merged into 3282.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 16 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b3f2eb34745ef0ef2ac0fc34615534c83fd5708

commit 8b3f2eb34745ef0ef2ac0fc34615534c83fd5708
Author: shivanisha <shivanisha@chromium.org>
Date: Tue Jan 16 20:21:30 2018

Fix the handling when Learn more link is clicked in subresource filter.

This CL fixes the handling of learn more link in mac UI for subresource
filter.

TEST=browser_tests --gtest_filter=ContentSettingBubbleControllerTest.
LearnMoreLinkClicked
Also verified manually using --disable-features=SecondaryUiMd. Without
the flag it is working fine as well.

Bug:  800917 
Change-Id: I363cd052858ac78f9d9ae666f9d1719cdaabb92c
Reviewed-on: https://chromium-review.googlesource.com/860761
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#528723}(cherry picked from commit 4869baace5e088c8f6a2ecc08bee69d32fe0b4da)
Reviewed-on: https://chromium-review.googlesource.com/868262
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#511}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/8b3f2eb34745ef0ef2ac0fc34615534c83fd5708/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_browsertest.mm
[modify] https://crrev.com/8b3f2eb34745ef0ef2ac0fc34615534c83fd5708/chrome/browser/ui/cocoa/subresource_filter/subresource_filter_bubble_controller.mm

Status: Fixed (was: Started)
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/655a80494906c5f19e44743f2f3e313b8cd9d006

commit 655a80494906c5f19e44743f2f3e313b8cd9d006
Author: shivanisha <shivanisha@chromium.org>
Date: Mon Jan 22 16:53:24 2018

Mac UI: Test Ads "Learn More" link with SecondaryUiMd code path

This CL adds a test to check the "Learn More" link in the ads bubble
when using the SecondaryUiMd code path. The test for non-SecondaryUiMd
code path was added in
https://chromium-review.googlesource.com/c/chromium/src/+/860761

AdsLearnMoreLinkClicked

Bug:  800917 
TEST: browser_tests --gtest_filter=ContentSettingImageModelBrowserTest.
Change-Id: Iec3055a22a7da6b551ce7e46cde57ee8735f3185
Reviewed-on: https://chromium-review.googlesource.com/864906
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530889}
[modify] https://crrev.com/655a80494906c5f19e44743f2f3e313b8cd9d006/chrome/browser/ui/content_settings/content_setting_image_model_browsertest.cc

Sign in to add a comment