New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800905 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 780141



Sign in to add a comment

[Findit] Flake Aanlyzer - Failure to get master_name in buildbucket_client

Project Member Reported by lijeffrey@chromium.org, Jan 10 2018

Issue description

Generator waterfall.flake.schedule_flake_try_job_pipeline.ScheduleFlakeTryJobPipeline(*(u'chromium.sandbox', u'Linux Tests SANDBOX', u'interactive_ui_tests', u'WebViewInteractiveTests/WebViewInteractiveTest.LongPressSelection/1', u'96de83c487be35a0ca3d55be03198a6bebc4a7f7', u'ag9zfmZpbm... (648 bytes), **{})#60d60e3d18b1475680ae9fdad45a9db6 raised exception. AttributeError: 'NoneType' object has no attribute 'startswith' (/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/infra_api_clients/../third_party/pipeline/pipeline.py:2434)
Traceback (most recent call last):
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/infra_api_clients/../third_party/pipeline/pipeline.py", line 2158, in evaluate
    self, pipeline_key, root_pipeline_key, caller_output)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/infra_api_clients/../third_party/pipeline/pipeline.py", line 1113, in _run_internal
    return self.run(*self.args, **self.kwargs)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/waterfall/flake/schedule_flake_try_job_pipeline.py", line 57, in run
    cache_name, dimensions, self.pipeline_id)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/services/try_job.py", line 335, in TriggerTryJob
    swarming_util.AssignWarmCacheHost(try_job, cache_name, FinditHttpClient())
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/waterfall/swarming_util.py", line 886, in AssignWarmCacheHost
    if not tryjob.is_swarmbucket_build:
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/common/waterfall/buildbucket_client.py", line 98, in is_swarmbucket_build
    bucket = _GetBucketName(self.master_name)
  File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/common/waterfall/buildbucket_client.py", line 31, in _GetBucketName
    if (master_name.startswith(buildbot_prefix) or
AttributeError: 'NoneType' object has no attribute 'startswith'
 
Components: Tools>Test>FindIt>Flakiness
Blocking: 780141
Owner: lijeffrey@chromium.org
We should consider bailing out when we encounter this particular master.

Comment 5 by st...@chromium.org, Jan 10 2018

If there is no matching variable builders, commit-level analysis should be bailed out, besides fully blacklisted this particular master.
It seems this master has the flake trybot set to linux_chromium_variable_deflake in config, should that be removed from config as well?
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/779c5a4be911f29ef1641567403c650c9f674195

commit 779c5a4be911f29ef1641567403c650c9f674195
Author: Jeffrey Li <lijeffrey@google.com>
Date: Thu Jan 11 01:17:46 2018

[Findit] Flake Analzyer - Skip try jobs for chromium.sandbox

'chromium.sandbox' isn't a real master that's mostly used for testing.
Skip try jobs for analyses on this master.

Bug:  800905 
Change-Id: Idcffb2ee7fdcb1117a4368f20a79cfd3dafdadcb
Reviewed-on: https://chromium-review.googlesource.com/861255
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/779c5a4be911f29ef1641567403c650c9f674195/appengine/findit/waterfall/flake/test/initialize_flake_try_job_pipeline_test.py
[modify] https://crrev.com/779c5a4be911f29ef1641567403c650c9f674195/appengine/findit/waterfall/flake/flake_constants.py
[modify] https://crrev.com/779c5a4be911f29ef1641567403c650c9f674195/appengine/findit/waterfall/flake/initialize_flake_try_job_pipeline.py

Status: Fixed (was: Assigned)

Sign in to add a comment