git cl upload --similarity doesn't work for Gerrit |
||
Issue descriptionIf Gerrit does not support this feature, we should document it so in `git cl.
,
Feb 9 2018
Issue 808445 has been merged into this issue.
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/13101a6e42d159a7c9b4dddb2aaf916dab663b7e commit 13101a6e42d159a7c9b4dddb2aaf916dab663b7e Author: Aaron Gable <agable@chromium.org> Date: Fri Feb 09 22:52:29 2018 Remove similarity support from git-cl The purpose of this CL is to remove confusion around whether or not git-cl support the similarity flags when talking to Gerrit. It does not. However, because Rietveld support has not been fully ripped out of git-cl, this change does modify some of the Rietveld-specific code to remove similarity support from everywhere. Bug: 800902 Change-Id: I8703ed60d6889c7a36400b8a9f8f26de4669020a Reviewed-on: https://chromium-review.googlesource.com/912389 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> [modify] https://crrev.com/13101a6e42d159a7c9b4dddb2aaf916dab663b7e/tests/git_cl_test.py [modify] https://crrev.com/13101a6e42d159a7c9b4dddb2aaf916dab663b7e/git_cl.py
,
Feb 9 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by aga...@chromium.org
, Feb 9 2018Status: Started (was: Untriaged)