New issue
Advanced search Search tips

Issue 800902 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

git cl upload --similarity doesn't work for Gerrit

Project Member Reported by robertma@chromium.org, Jan 10 2018

Issue description

If Gerrit does not support this feature, we should document it so in `git cl.
 
Owner: aga...@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/#/c/chromium/tools/depot_tools/+/912389
Issue 808445 has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/13101a6e42d159a7c9b4dddb2aaf916dab663b7e

commit 13101a6e42d159a7c9b4dddb2aaf916dab663b7e
Author: Aaron Gable <agable@chromium.org>
Date: Fri Feb 09 22:52:29 2018

Remove similarity support from git-cl

The purpose of this CL is to remove confusion around whether or
not git-cl support the similarity flags when talking to Gerrit.
It does not. However, because Rietveld support has not been
fully ripped out of git-cl, this change does modify some of the
Rietveld-specific code to remove similarity support from everywhere.

Bug:  800902 
Change-Id: I8703ed60d6889c7a36400b8a9f8f26de4669020a
Reviewed-on: https://chromium-review.googlesource.com/912389
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

[modify] https://crrev.com/13101a6e42d159a7c9b4dddb2aaf916dab663b7e/tests/git_cl_test.py
[modify] https://crrev.com/13101a6e42d159a7c9b4dddb2aaf916dab663b7e/git_cl.py

Status: Fixed (was: Started)

Sign in to add a comment