New issue
Advanced search Search tips

Issue 800885 link

Starred by 1 user
Status: Fixed
Owner:
chrisha@chromium.org
Closed: Jul 18
Cc:
sebmarchand@chromium.org
chrisha@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Allow tabs that have never been focused to be discarded

Project Member Reported by fdoray@chromium.org, Jan 10 2018 
To preserve old behavior, TabLifecycleUnit prevents tab that have been opened less than 10 minutes ago from being discarded. It would be better not to protect these tabs, as they probably don't contain any information that the user cares about.

Comment 1 by chrisha@chromium.org, Jul 17

Owner: chrisha@chromium.org
I'm taking this. We're going to address this by using the |last_active_time| from the underlying WebContents, which is persisted across session restore events.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0f9909ace730997801ec383091ee5f2cdeb44af

commit f0f9909ace730997801ec383091ee5f2cdeb44af
Author: Chris Hamilton <chrisha@chromium.org>
Date: Wed Jul 18 12:42:01 2018

Use WebContents::GetLastActiveTime when creating TabLifecycleUnits.

This allows session restored tabs to persist their time since last use across
sessions, allowing them to be appropriately prioritized.

BUG= 800885 

Change-Id: Ic578b93b418d07d83b47b9ae4e9ea561800f9fcc
Reviewed-on: https://chromium-review.googlesource.com/1140785
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576015}
[modify] https://crrev.com/f0f9909ace730997801ec383091ee5f2cdeb44af/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/f0f9909ace730997801ec383091ee5f2cdeb44af/chrome/browser/resource_coordinator/tab_lifecycle_unit.h
[modify] https://crrev.com/f0f9909ace730997801ec383091ee5f2cdeb44af/chrome/browser/resource_coordinator/tab_lifecycle_unit_unittest.cc

Comment 3 by chrisha@chromium.org, Jul 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment