MediaViewerActivity: Determine file URI when possible |
||||||||
Issue descriptionCurrently in MediaViewerActivity, we send the content:// URI off as the URI to display to the user. However, we want to show the user the file:// URI instead when possible.
,
Jul 20
,
Jul 24
Could we show the file name instead of the URI? It sounds that it would be more beneficial for the user than a very long string they can't parse.
,
Aug 2
,
Aug 7
+emilyschechter any concerns from a security UX perspective about this (or should we ask security eng instead)? In my opinion showing the file:// path will be much more useful than showing the content:// URI in terms of understanding what is being shown? I guess we need to be sure that we're showing the file:// scheme always in the case to avoid someone doing something like: file://totalysanelookingfile.www.google.com and having the trailing bit being shown in the omnibox. @steimel, can you upload a couple screenshots of the pre-post UI to make it a bit clearer?
,
Aug 8
Per our offline discussion, we're actually not currently planning on showing the file:// URI for M69. Instead, we're just going to show the file display name as the title. Attached is a screencast where I open a video and it shows the video name as the title.
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/22f1e08c7751380cfb981cac68fc06652581444d commit 22f1e08c7751380cfb981cac68fc06652581444d Author: Tommy Steimel <steimel@chromium.org> Date: Mon Aug 13 19:33:24 2018 [Media Intent Handler] Use file display name as title for content URIs This CL changes NavigationEntryImpl::GetTitleForDisplay for content URIs to use the file's display name if determinable. This affects HTML, audio, and video files opened with Chrome on Android. This does not affect image files since ImageDocument already has a built-in title. Bug: 800880 Change-Id: I0ad03d2dc13d4895f6789a6a7a6ea1199e19745b Reviewed-on: https://chromium-review.googlesource.com/1165790 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#582664} [modify] https://crrev.com/22f1e08c7751380cfb981cac68fc06652581444d/base/android/content_uri_utils.cc [modify] https://crrev.com/22f1e08c7751380cfb981cac68fc06652581444d/base/android/content_uri_utils.h [modify] https://crrev.com/22f1e08c7751380cfb981cac68fc06652581444d/base/android/java/src/org/chromium/base/ContentUriUtils.java [modify] https://crrev.com/22f1e08c7751380cfb981cac68fc06652581444d/content/browser/frame_host/navigation_entry_impl.cc [modify] https://crrev.com/22f1e08c7751380cfb981cac68fc06652581444d/content/browser/frame_host/navigation_entry_impl_unittest.cc
,
Aug 17
Merge request for the CL in comment 7. This solves a UX blocker for the media intent handler launch (which is approved for M69). I waited on it since there was one issue with it which is now fixed in crbug/874149 (which I will also merge request). Thanks!
,
Aug 17
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 20
Approved for merge to 69, branch 3497.
,
Aug 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/207c72adfe3aa9621f0950e72ccef8e21d242fa2 commit 207c72adfe3aa9621f0950e72ccef8e21d242fa2 Author: Tommy Steimel <steimel@chromium.org> Date: Mon Aug 20 16:51:30 2018 [Media Intent Handler] Use file display name as title for content URIs This CL changes NavigationEntryImpl::GetTitleForDisplay for content URIs to use the file's display name if determinable. This affects HTML, audio, and video files opened with Chrome on Android. This does not affect image files since ImageDocument already has a built-in title. Bug: 800880 Change-Id: I0ad03d2dc13d4895f6789a6a7a6ea1199e19745b Reviewed-on: https://chromium-review.googlesource.com/1165790 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#582664}(cherry picked from commit 22f1e08c7751380cfb981cac68fc06652581444d) Reviewed-on: https://chromium-review.googlesource.com/1181581 Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#713} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/207c72adfe3aa9621f0950e72ccef8e21d242fa2/base/android/content_uri_utils.cc [modify] https://crrev.com/207c72adfe3aa9621f0950e72ccef8e21d242fa2/base/android/content_uri_utils.h [modify] https://crrev.com/207c72adfe3aa9621f0950e72ccef8e21d242fa2/base/android/java/src/org/chromium/base/ContentUriUtils.java [modify] https://crrev.com/207c72adfe3aa9621f0950e72ccef8e21d242fa2/content/browser/frame_host/navigation_entry_impl.cc [modify] https://crrev.com/207c72adfe3aa9621f0950e72ccef8e21d242fa2/content/browser/frame_host/navigation_entry_impl_unittest.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by steimel@chromium.org
, Jan 10 2018