Issue metadata
Sign in to add a comment
|
Investigate why cookie permission sets status=allowed inside OnContentBlocked |
||||||||||||||||||||||||
Issue descriptionIn order to fix a problem with the cookie-block notification bubble not being displayed in the omnibox, a change was made to OnContentBlocked/OnContentBlockedWithDetail to force status.allowed to true. This does not look like an appropriate fix, and it breaks OnContentBlocked for other permissions. Original bug: "cookie blocking notification bubble is not displayed in the omnibox." https://bugs.chromium.org/p/chromium/issues/detail?id=224557 Relevant code: TabSpecificContentSettings::OnContentBlocked() TabSpecificContentSettings::OnContentBlockedWithDetail() https://cs.chromium.org/search/?q=TabSpecificContentSettings::OnContentBlocked&type=cs
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d3d7cf43470f8ed2733c41cdff469371c6fe538 commit 9d3d7cf43470f8ed2733c41cdff469371c6fe538 Author: Jochen Eisinger <jochen@chromium.org> Date: Mon Jan 15 08:41:25 2018 Remove spurious recording of cookie blocking as "allowed" This looks like an unintentional bug introducing during an unrelated change a few years ago BUG= 800845 R=garykac@chromium.org,benwells@chromium.org Change-Id: I5e2b4f41b79f0808d622c86a77bfea789907c6e5 Reviewed-on: https://chromium-review.googlesource.com/863602 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#529228} [modify] https://crrev.com/9d3d7cf43470f8ed2733c41cdff469371c6fe538/chrome/browser/content_settings/tab_specific_content_settings.cc
,
Jan 15 2018
,
Jan 15 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by benwells@chromium.org
, Jan 12 2018Components: -Internals>Permissions Internals>Permissions>Model Internals>Network>Cookies
Status: Available (was: Untriaged)