Issue metadata
Sign in to add a comment
|
"virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html" is flaky |
||||||||||||||||||||||
Issue description"virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybgsSBUZsYWtlImN2aXJ0dWFsL3doZWVsc2Nyb2xsbGF0Y2hpbmcvZmFzdC9jb21wb3NpdG9yLXdoZWVsLXNjcm9sbC1sYXRjaGluZy90b3VjaHBhZC1zY3JvbGwtaW1wbC10by1tYWluLmh0bWwM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jan 11 2018
Detected 5 new flakes for test/step "virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybgsSBUZsYWtlImN2aXJ0dWFsL3doZWVsc2Nyb2xsbGF0Y2hpbmcvZmFzdC9jb21wb3NpdG9yLXdoZWVsLXNjcm9sbC1sYXRjaGluZy90b3VjaHBhZC1zY3JvbGwtaW1wbC10by1tYWluLmh0bWwM. This message was posted automatically by the chromium-try-flakes app.
,
Jan 13 2018
Detected 3 new flakes for test/step "virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybgsSBUZsYWtlImN2aXJ0dWFsL3doZWVsc2Nyb2xsbGF0Y2hpbmcvZmFzdC9jb21wb3NpdG9yLXdoZWVsLXNjcm9sbC1sYXRjaGluZy90b3VjaHBhZC1zY3JvbGwtaW1wbC10by1tYWluLmh0bWwM. This message was posted automatically by the chromium-try-flakes app.
,
Jan 15 2018
Remove the label since an owner was assigned.
,
Jan 15 2018
,
Jan 18 2018
Detected 7 new flakes for test/step "virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNybgsSBUZsYWtlImN2aXJ0dWFsL3doZWVsc2Nyb2xsbGF0Y2hpbmcvZmFzdC9jb21wb3NpdG9yLXdoZWVsLXNjcm9sbC1sYXRjaGluZy90b3VjaHBhZC1zY3JvbGwtaW1wbC10by1tYWluLmh0bWwM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Jan 18 2018
This is flaking hard on mac_chromium_rel_ng; 5 today, 10 yesterday, some last week. I will be sending out a CL to disable it.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30175d7901b7995ca9852ebbad097c9e1d24d7ae commit 30175d7901b7995ca9852ebbad097c9e1d24d7ae Author: Stephen McGruer <smcgruer@chromium.org> Date: Thu Jan 18 21:29:36 2018 Disable touchpad-scroll-impl-to-main.html on Mac This is flaking hard on mac_chromium_rel_ng, and is blocking tryjobs. Bug: 800840 Change-Id: If79dd7e475aad28cd93d22dbfb699c058efb056f TBR=sahel@chromium.org Change-Id: If79dd7e475aad28cd93d22dbfb699c058efb056f Reviewed-on: https://chromium-review.googlesource.com/874896 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#530276} [modify] https://crrev.com/30175d7901b7995ca9852ebbad097c9e1d24d7ae/third_party/WebKit/LayoutTests/TestExpectations
,
Jan 19 2018
,
Jan 26 2018
Failures are still happening in this test on the trybot: https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/636479 Also here: https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/636764 https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/636749 and probably other places. It's because it's sometimes crashing: crash log for renderer (pid <unknown>): STDOUT: <empty> STDERR: STDERR: DevTools listening on ws://127.0.0.1:62538/devtools/browser/0b595739-9428-44e4-a34e-a22362efa7b1 STDERR: [14847:25603:0125/195138.451852:FATAL:scoped_web_input_event_with_latency_info.cc(28)] Check failed: other.latency_.trace_id() > latency_.trace_id() (7 vs. 7) STDERR: 0 Content Shell Framework 0x000000011eec2d2c base::debug::StackTrace::StackTrace(unsigned long) + 28 STDERR: 1 Content Shell Framework 0x000000011eee7440 logging::LogMessage::~LogMessage() + 224 STDERR: 2 Content Shell Framework 0x00000001232392b3 content::ScopedWebInputEventWithLatencyInfo::CoalesceWith(content::ScopedWebInputEventWithLatencyInfo const&) + 131 STDERR: 3 Content Shell Framework 0x000000012323554d content::QueuedWebInputEvent::FilterNewEvent(content::MainThreadEventQueueTask*) + 477 STDERR: 4 Content Shell Framework 0x00000001232369f7 content::MainThreadEventQueueTaskList::Queue(std::__1::unique_ptr<content::MainThreadEventQueueTask, std::__1::default_delete<content::MainThreadEventQueueTask> >) + 263 STDERR: 5 Content Shell Framework 0x0000000123234503 content::MainThreadEventQueue::QueueEvent(std::__1::unique_ptr<content::MainThreadEventQueueTask, std::__1::default_delete<content::MainThreadEventQueueTask> >) + 179 STDERR: 6 Content Shell Framework 0x00000001232343cc content::MainThreadEventQueue::HandleEvent(std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, content::InputEventDispatchType, content::InputEventAckState, base::OnceCallback<void (content::InputEventAckState, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >, base::Optional<cc::TouchAction>)>) + 796 STDERR: 7 Content Shell Framework 0x000000012323d2ed content::WidgetInputHandlerManager::DidHandleInputEventAndOverscroll(base::OnceCallback<void (content::InputEventAckSource, ui::LatencyInfo const&, content::InputEventAckState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)>, ui::InputHandlerProxy::EventDisposition, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >) + 429 STDERR: 8 Content Shell Framework 0x0000000123240b8a void base::internal::FunctorTraits<void (content::WidgetInputHandlerManager::*)(base::OnceCallback<void (content::InputEventAckSource, ui::LatencyInfo const&, content::InputEventAckState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)>, ui::InputHandlerProxy::EventDisposition, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >), void>::Invoke<scoped_refptr<content::WidgetInputHandlerManager>, base::OnceCallback<void (content::InputEventAckSource, ui::LatencyInfo const&, content::InputEventAckState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)>, ui::InputHandlerProxy::EventDisposition, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> > >(void (content::WidgetInputHandlerManager::*)(base::OnceCallback<void (content::InputEventAckSource, ui::LatencyInfo const&, content::InputEventAckState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)>, ui::InputHandlerProxy::EventDisposition, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >), scoped_refptr<content::WidgetInputHandlerManager>&&, base::OnceCallback<void (content::InputEventAckSource, ui::LatencyInfo const&, content::InputEventAckState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)>&&, ui::InputHandlerProxy::EventDisposition&&, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>&&, ui::LatencyInfo const&&&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >&&) + 218 STDERR: 9 Content Shell Framework 0x0000000123240aa4 base::internal::Invoker<base::internal::BindState<void (content::WidgetInputHandlerManager::*)(base::OnceCallback<void (content::InputEventAckSource, ui::LatencyInfo const&, content::InputEventAckState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)>, ui::InputHandlerProxy::EventDisposition, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >), scoped_refptr<content::WidgetInputHandlerManager>, base::OnceCallback<void (content::InputEventAckSource, ui::LatencyInfo const&, content::InputEventAckState, base::Optional<ui::DidOverscrollParams> const&, base::Optional<cc::TouchAction> const&)> >, void (ui::InputHandlerProxy::EventDisposition, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >)>::RunOnce(base::internal::BindStateBase*, ui::InputHandlerProxy::EventDisposition, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>&&, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >&&) + 52 STDERR: 10 Content Shell Framework 0x000000011d27efb7 ui::EventWithCallback::RunCallbacks(ui::InputHandlerProxy::EventDisposition, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >) + 647 STDERR: 11 Content Shell Framework 0x000000011d2805a3 ui::InputHandlerProxy::DispatchSingleInputEvent(std::__1::unique_ptr<ui::EventWithCallback, std::__1::default_delete<ui::EventWithCallback> >, base::TimeTicks) + 803 STDERR: 12 Content Shell Framework 0x000000011d280666 ui::InputHandlerProxy::DispatchQueuedInputEvents() + 102 STDERR: 13 Content Shell Framework 0x000000011d280115 ui::InputHandlerProxy::HandleInputEventWithLatencyInfo(std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, base::OnceCallback<void (ui::InputHandlerProxy::EventDisposition, std::__1::unique_ptr<blink::WebInputEvent, ui::WebInputEventDeleter>, ui::LatencyInfo const&, std::__1::unique_ptr<ui::DidOverscrollParams, std::__1::default_delete<ui::DidOverscrollParams> >)>) + 805
,
Jan 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/480bdb31777bf33c3053ae2590b1ff54f95cdec7 commit 480bdb31777bf33c3053ae2590b1ff54f95cdec7 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Jan 26 18:11:56 2018 Skip touchpad-scroll-impl-to-main.html on Mac. virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/ touchpad-scroll-impl-to-main.html is crashing, also, on Mac. Skip it until it's fixed. NOTRY=true TBR=sahel@chromium.org Bug: 800840 Change-Id: I1ad8fe7f8a5f226ca9253a11dea09b34c4596003 Reviewed-on: https://chromium-review.googlesource.com/889379 Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532018} [modify] https://crrev.com/480bdb31777bf33c3053ae2590b1ff54f95cdec7/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e Author: Sahel Sharify <sahel@chromium.org> Date: Thu Mar 15 17:30:49 2018 Send GSB before switching to mainthread scrolling in smooth scroll path. This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling path,if the compositor handles the GSB and during the scrolling we have to switch to main thread since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original GSB was handled on the compositor rather than being sent to the main thread. touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling in this cl I've moved the test to a new virtual test suite that has default scroll animation value. I have removed the test expectations since I have changed the test and this might fix the flake. subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to a new test suite. Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 Reviewed-on: https://chromium-review.googlesource.com/961264 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#543425} [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/VirtualTestSuites [rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html [rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html [copy] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt [rename] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt [modify] https://crrev.com/5d5a062fac6f567cd8f8b2ef7e894e7623f8013e/ui/events/blink/input_handler_proxy.cc
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a6d89788324987fbad1450b2db6f113129a7130 commit 0a6d89788324987fbad1450b2db6f113129a7130 Author: Caleb Rouleau <crouleau@chromium.org> Date: Thu Mar 15 19:20:17 2018 Revert "Send GSB before switching to mainthread scrolling in smooth scroll path." This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e. Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 bug: 822386 Original change's description: > Send GSB before switching to mainthread scrolling in smooth scroll path. > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > GSB was handled on the compositor rather than being sent to the main thread. > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > in this cl I've moved the test to a new virtual test suite that has default scroll animation > value. > > I have removed the test expectations since I have changed the test and this might fix the flake. > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > a new test suite. > > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > Reviewed-on: https://chromium-review.googlesource.com/961264 > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543425} TBR=tdresser@chromium.org,sahel@chromium.org Change-Id: I3c5253d96d011c9723063effac91c969ee352305 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/963388 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#543467} [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/VirtualTestSuites [rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/subpixel-accumulation.html [rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/touchpad-scroll-impl-to-main.html [rename] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/README.txt [delete] https://crrev.com/44f923b213a284825b87fd7a8b9dea048c964653/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt [modify] https://crrev.com/0a6d89788324987fbad1450b2db6f113129a7130/ui/events/blink/input_handler_proxy.cc
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0842dc1779dae371e2bda39bdbe19c73bcac2f0 commit f0842dc1779dae371e2bda39bdbe19c73bcac2f0 Author: Sahel Sharify <sahel@chromium.org> Date: Thu Mar 15 21:22:26 2018 Reland "Send GSB before switching to mainthread scrolling in smooth scroll path." This reverts commit 0a6d89788324987fbad1450b2db6f113129a7130. Reason for revert: touchpad-scroll-impl-to-main.html is a flaky test that I changed it in the original cl and removed the tests expectations to see if the flake is fixed or not. Changing the test expectations caused unexpected test failure. In this reland I left the test expectations for touchpad-scroll-impl-to-main.html unchanged. Original change's description: > Revert "Send GSB before switching to mainthread scrolling in smooth scroll path." > > This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e. > > Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 > > bug: 822386 > > Original change's description: > > Send GSB before switching to mainthread scrolling in smooth scroll path. > > > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > > GSB was handled on the compositor rather than being sent to the main thread. > > > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > > in this cl I've moved the test to a new virtual test suite that has default scroll animation > > value. > > > > I have removed the test expectations since I have changed the test and this might fix the flake. > > > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > > a new test suite. > > > > Bug: 820979, 708499, 757165, 800840 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > > Reviewed-on: https://chromium-review.googlesource.com/961264 > > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543425} > > TBR=tdresser@chromium.org,sahel@chromium.org > > Change-Id: I3c5253d96d011c9723063effac91c969ee352305 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/963388 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543467} TBR=tdresser@chromium.org,crouleau@chromium.org Change-Id: I460ff89a12c94772564c77418f2c1e58c72314a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/964809 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543498} [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/VirtualTestSuites [rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html [rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html [copy] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt [rename] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt [modify] https://crrev.com/f0842dc1779dae371e2bda39bdbe19c73bcac2f0/ui/events/blink/input_handler_proxy.cc
,
Apr 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b commit dfc61b12139e0a086e7e24994c7ef10a98b1aa2b Author: Sahel Sharify <sahel@chromium.org> Date: Tue Apr 03 15:56:43 2018 Reland "Send GSB before switching to mainthread scrolling in smooth scroll path." This reverts commit 0a6d89788324987fbad1450b2db6f113129a7130. Reason for revert: touchpad-scroll-impl-to-main.html is a flaky test that I changed it in the original cl and removed the tests expectations to see if the flake is fixed or not. Changing the test expectations caused unexpected test failure. In this reland I left the test expectations for touchpad-scroll-impl-to-main.html unchanged. Original change's description: > Revert "Send GSB before switching to mainthread scrolling in smooth scroll path." > > This reverts commit 5d5a062fac6f567cd8f8b2ef7e894e7623f8013e. > > Reason for revert: added a failing test https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/32246 see issue 822386 > > bug: 822386 > > Original change's description: > > Send GSB before switching to mainthread scrolling in smooth scroll path. > > > > This cl is the equivalent of https://codereview.chromium.org/2854683002 fix for smooth scrolling > > path,if the compositor handles the GSB and during the scrolling we have to switch to main thread > > since the compositor cannot handle a GSU a GSB must be sent to the main thread since the original > > GSB was handled on the compositor rather than being sent to the main thread. > > > > touchpad-scroll-impl-to-main.html is the test that forces switch from compositor thread to main > > thread in the middle of scrolling. It used to get executed with --disable-smooth-scrolling > > in this cl I've moved the test to a new virtual test suite that has default scroll animation > > value. > > > > I have removed the test expectations since I have changed the test and this might fix the flake. > > > > subpixel-accumulation.html needs scroll animation to be disabled and that's why I had to move it to > > a new test suite. > > > > Bug: 820979, 708499, 757165, 800840 > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I21b1f4285897d74559f6827e6a232f007dc897b0 > > Reviewed-on: https://chromium-review.googlesource.com/961264 > > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543425} > > TBR=tdresser@chromium.org,sahel@chromium.org > > Change-Id: I3c5253d96d011c9723063effac91c969ee352305 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 820979, 708499, 757165, 800840 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/963388 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543467} TBR=tdresser@chromium.org,crouleau@chromium.org Change-Id: I460ff89a12c94772564c77418f2c1e58c72314a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820979, 708499, 757165, 800840 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/964809 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#543498}(cherry picked from commit f0842dc1779dae371e2bda39bdbe19c73bcac2f0) Reviewed-on: https://chromium-review.googlesource.com/992852 Cr-Commit-Position: refs/branch-heads/3359@{#551} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/FlagExpectations/disable-blink-features=RootLayerScrolling [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/VirtualTestSuites [rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/animated-scroll/touchpad-scroll-impl-to-main.html [rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/fast/compositor-wheel-scroll-latching/non-animated-scroll/subpixel-accumulation.html [copy] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/animated-scroll/README.txt [rename] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/third_party/WebKit/LayoutTests/virtual/wheelscrolllatching/fast/compositor-wheel-scroll-latching/non-animated-scroll/README.txt [modify] https://crrev.com/dfc61b12139e0a086e7e24994c7ef10a98b1aa2b/ui/events/blink/input_handler_proxy.cc
,
Apr 23 2018
There is also bug 789041 for the ScopedWebInputEventWithLatencyInfo::CoalesceWith() (D)CHECK failure.
,
May 7 2018
This flakiness happened in https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/86573
,
Aug 24
This looks fixed in recent runs: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=touchpad-scroll-impl-to-main.html |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sahel@chromium.org
, Jan 11 2018Status: Assigned (was: Untriaged)