'WebGL Error fired' breakpoint fails to stop at correct location
Reported by
pie...@gmail.com,
Jan 10 2018
|
|||||||||
Issue descriptionChrome Version : 63.0.3239.132 (Official Build) (64-bit What steps will reproduce the problem? (1) set an event listener breakpoint on canvas/WebGL Error fired (2) trigger a WebGL error, eg 'WebGL: INVALID_VALUE: uniform3fv: invalid size' (3) notice that the console output includes the CORRECT location of the erroneous call, with a correct stack trace. (4) notice that the debugger stops at the INCORRECT location. i believe it only breaks the _next_ time entering the function that contains the error. What is the expected result? debugger should stop at the correct location.
,
Jan 12 2018
@Reporter: Could you please attach a sample test file to check this issue. This would help in further triaging of the issue from TE end. Thanks!
,
Jan 12 2018
,
Jan 12 2018
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 12 2018
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb285d38cee06746e129bd0a661093ace2ed921a commit eb285d38cee06746e129bd0a661093ace2ed921a Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Tue Jan 23 19:42:37 2018 [DevTools] intrumented webgl error with synchronous breakpoint Most of the time we use webgl error breakpoint to set breakpoint at webgl call which produces opengl warning or error. Asynchronous break at next JavaScript execution is not useful here. R=dgozman@chromium.org Bug: chromium:800835 Change-Id: Ief8670a22ceff51e6cb7b55f47a403a7f6a52959 Reviewed-on: https://chromium-review.googlesource.com/879073 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#531305} [add] https://crrev.com/eb285d38cee06746e129bd0a661093ace2ed921a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/domdebugger-webgl-breakpoint-expected.txt [add] https://crrev.com/eb285d38cee06746e129bd0a661093ace2ed921a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/domdebugger-webgl-breakpoint.js [modify] https://crrev.com/eb285d38cee06746e129bd0a661093ace2ed921a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
,
Jan 23 2018
I believe that we can merge this trivial fix at least to M65.
,
Jan 23 2018
,
Jan 24 2018
Tested the issue on latest chrome version 66.0.3330.0 using Ubuntu 14.04, Mac 10.13.1 and windows-10 with steps mentioned below: 1) Launched chrome latest version and navigated to https://codepen.io/Spongman/pen/dJKOVZ?editors=0010 as provided in comment#3 2) Naviagted to Devtools -> Console and on code pen console entered 'WebGL: INVALID_VALUE: uniform3fv: invalid size' and clicked on enter 3) Clicked on the output link on Devtools -> Console area 4) Under Sources tab cliked on pretty print, it shows a line highlighted in console_runner @kozy: I am seeing the same behaviour on chrome version 63.0.3239.132, please find the attached screen cast for your reference and let us know if we missed anything in reproducing the issue or verification
,
Jan 24 2018
,
Jan 24 2018
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 24 2018
Pls merge your change to M65 branch 3325 before 2:00 PM PT today so we can pick it up for dev release on Wednesday. Thank you.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/778f007ac7eda1b0fab68363970740acded500ed commit 778f007ac7eda1b0fab68363970740acded500ed Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Jan 24 23:01:53 2018 [DevTools] intrumented webgl error with synchronous breakpoint Most of the time we use webgl error breakpoint to set breakpoint at webgl call which produces opengl warning or error. Asynchronous break at next JavaScript execution is not useful here. R=dgozman@chromium.org TBR=kozyatinskiy@chromium.org (cherry picked from commit eb285d38cee06746e129bd0a661093ace2ed921a) Bug: chromium:800835 Change-Id: Ief8670a22ceff51e6cb7b55f47a403a7f6a52959 Reviewed-on: https://chromium-review.googlesource.com/879073 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531305} Reviewed-on: https://chromium-review.googlesource.com/884730 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#75} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [add] https://crrev.com/778f007ac7eda1b0fab68363970740acded500ed/third_party/WebKit/LayoutTests/inspector-protocol/debugger/domdebugger-webgl-breakpoint-expected.txt [add] https://crrev.com/778f007ac7eda1b0fab68363970740acded500ed/third_party/WebKit/LayoutTests/inspector-protocol/debugger/domdebugger-webgl-breakpoint.js [modify] https://crrev.com/778f007ac7eda1b0fab68363970740acded500ed/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp
,
Jan 24 2018
To verify bug you should set canvas event listener breakpoint and check source location where pause happens.
,
Jan 24 2018
@viswatej i think you missed the whole 'WebGL Error Fired' breakpoint part. i just verified that this is fixed in 66.0.3330.0 canary/win10x64. thanks! |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by krajshree@chromium.org
, Jan 11 2018