Links to builder pages in the header of the console view have hard-coded 'chromium' part in URL |
|||||||||
Issue descriptionSee attached screenshot. For example, the link for the 'b' tab is https://ci.chromium.org/p/chromium/builders/luci.v8.ci/V8%20Linux64%20-%20builder but should be https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20builder This way, user stays in the V8 project instead of jumping to Chromium.
,
Jan 10 2018
Looks like I found relevant TODO: https://chromium.googlesource.com/infra/luci/luci-go/+/a9603b62bacdad9e4ec807bdfc254a95fde8c15d/milo/frontend/routes.go#148.
,
Jan 10 2018
,
Jan 10 2018
(FWIW that TODO wasn't relevant)
,
Jan 11 2018
,
Jan 11 2018
CC jchinless since she worked on the routing when we launched the UI.
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/4d6cd3dc46b124d87933e8b1365e1789ee683086 commit 4d6cd3dc46b124d87933e8b1365e1789ee683086 Author: Nodir Turakulov <nodir@google.com> Date: Thu Jan 11 20:03:35 2018 [milo] console: fix builder link Console impl assumed that builder id is a valid URL path of a builder. Use model.BuilderIDLink. Also set BuilderSummary.ProjectID to the currently served project. This CL adds technical debt. Project must be a part of the builder ID, but that is a larger refactoring or rewrite. Bug: 800826 Change-Id: I60399ac779e3086fd5aa9cc779dd7e24cf3d5fa2 Reviewed-on: https://chromium-review.googlesource.com/860732 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/4d6cd3dc46b124d87933e8b1365e1789ee683086/milo/buildsource/console.go [modify] https://crrev.com/4d6cd3dc46b124d87933e8b1365e1789ee683086/milo/frontend/appengine/templates/pages/builder_groups.html [modify] https://crrev.com/4d6cd3dc46b124d87933e8b1365e1789ee683086/milo/frontend/expectations/console-Full_console_with_Header.html [modify] https://crrev.com/4d6cd3dc46b124d87933e8b1365e1789ee683086/milo/frontend/ui/console.go [modify] https://crrev.com/4d6cd3dc46b124d87933e8b1365e1789ee683086/milo/frontend/view_console.go
,
Jan 11 2018
,
Jan 12 2018
,
Jan 30 2018
,
Jan 30 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by serg...@chromium.org
, Jan 10 2018