New issue
Advanced search Search tips

Issue 800825 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Sep 12
Cc:
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocking:
issue 865801



Sign in to add a comment

Remove Tab reference from UrlBar.java

Project Member Reported by tedc...@chromium.org, Jan 10 2018 
The long term goal is to make the UrlBar a pure java view with no native dependencies.  Thus all references to Tab need to be removed.  All existing usages need to either be moved to the UrlBarDelegate or we should move towards a push model instead of pull model for UI state.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a99e85c96dbc2dac7d5aed111a1639d0ed31c2dc

commit a99e85c96dbc2dac7d5aed111a1639d0ed31c2dc
Author: Ted Choc <tedchoc@google.com>
Date: Thu Jan 11 20:04:54 2018

Remove dead code in UrlBar for dismissing the CVC action mode.

Originally added 10/28/11 in internal CL: 6431c8391790ee0d3d64dea609062d30219f6949
Made unreachable by 10/22/13: b66b7575fe42fe6061a0c92d54628ce3e664f825

Since the gesture detector consumes events when not focused, we never hit the
code that would dismiss the action mode on down until after the focus has happened
and the normal clearing would have happened.

BUG= 800825 

Change-Id: I5d50a78b08ed48e2035f272cd1c72a2973335306
Reviewed-on: https://chromium-review.googlesource.com/860430
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Commit-Queue: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528722}
[modify] https://crrev.com/a99e85c96dbc2dac7d5aed111a1639d0ed31c2dc/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java

Comment 2 by k...@chromium.org, Jan 29 2018

Labels: -Type-Bug Type-Task
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccbdb867bc488dfb9320d6a25dd29a0406214b59

commit ccbdb867bc488dfb9320d6a25dd29a0406214b59
Author: Ted Choc <tedchoc@google.com>
Date: Fri Jul 20 21:06:40 2018

Move URL emphasis logic to ToolbarModel.

One major change is that UrlBarData now typically has editing text when
generated by the ToolbarModel.  The displayText is a stylized version
of the URL that will be replaced with the plain text version when
editing.

BUG= 800825 

Change-Id: Ia6f3a9a1b87195f1d7ab98c2b567f843fe783a61
Reviewed-on: https://chromium-review.googlesource.com/1142535
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576985}
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/java/src/org/chromium/chrome/browser/omnibox/AutocompleteEditText.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/java/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizer.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBarData.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
[modify] https://crrev.com/ccbdb867bc488dfb9320d6a25dd29a0406214b59/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/ToolbarModelTest.java

Comment 4 by tedc...@chromium.org, Jul 20

Blocking: 865801

Comment 6 by twelling...@chromium.org, Sep 12

Cc: twelling...@chromium.org
Is this done?

Comment 7 by tedc...@chromium.org, Sep 12

Status: Fixed (was: Started)
Yeah, there is still more work that needs to be done to clean up the dependencies for how data is gathered in the UrlBarMediator, but we should file a new bug for that.
►

Sign in to add a comment