New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 800804 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

trouble drawing huge lines

Project Member Reported by reed@google.com, Jan 10 2018

Issue description

Chrome draws 1 line for this test, while Edge/IE (and test skia code) draw 2 lines.

LayoutTests/svg/custom/massive-coordinates.svg

Need to investigate why chrome only draws 1.
 

Comment 1 by reed@google.com, Jan 10 2018

Cc: bsalo...@google.com
https://fiddle.skia.org/c/@massive_coordinates_svg

Seems to draw differently between cpu and gpu

Comment 2 by reed@google.com, Jan 10 2018

Cc: egdaniel@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/d284949b595e2d7c6c6901c5b49e822a02a4d79f

commit d284949b595e2d7c6c6901c5b49e822a02a4d79f
Author: Mike Reed <reed@google.com>
Date: Wed Jan 10 20:39:33 2018

restore intersect methods to use old-style empty-checks on their inputs

Bug introduced when we made isEmpty check for int32_t width/height

Bug:800804
Change-Id: I59799c88fb02f176c1545dd0edae050b510df079
Reviewed-on: https://skia-review.googlesource.com/93302
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Reed <reed@google.com>

[add] https://crrev.com/d284949b595e2d7c6c6901c5b49e822a02a4d79f/gm/hugepath.cpp
[modify] https://crrev.com/d284949b595e2d7c6c6901c5b49e822a02a4d79f/include/core/SkRect.h
[modify] https://crrev.com/d284949b595e2d7c6c6901c5b49e822a02a4d79f/docs/SkIRect_Reference.bmh
[modify] https://crrev.com/d284949b595e2d7c6c6901c5b49e822a02a4d79f/gn/gm.gni

Comment 4 by reed@google.com, Jan 10 2018

Cc: -egdaniel@chromium.org egdaniel@google.com
Owner: egdaniel@chromium.org

Comment 5 by egdaniel@google.com, Jan 10 2018

When testing, GPU works for stroke width 0 through 0.999.. but fails for greater or equal to 1. So most likely our AAHairline is working and then failing on larger strokes.

Raster will fail (and draw nothing) if the width is greater than 1, also suggesting the hairline works there.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/e2330261a704e2db762e2de0d297bf8b4dc510f1

commit e2330261a704e2db762e2de0d297bf8b4dc510f1
Author: Mike Reed <reed@google.com>
Date: Fri Jan 12 19:31:04 2018

relax path bounds check so we can draw larger paths

Bug:800804
Change-Id: Ief0679de95887d8e11aa5853228c2bdef27d07a2
Reviewed-on: https://skia-review.googlesource.com/94100
Reviewed-by: Yuqian Li <liyuqian@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/e2330261a704e2db762e2de0d297bf8b4dc510f1/gm/hugepath.cpp
[modify] https://crrev.com/e2330261a704e2db762e2de0d297bf8b4dc510f1/src/core/SkScan_AntiPath.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/ff25cdf898e6b95a6ab26cff4a9e7a94bd0755f1

commit ff25cdf898e6b95a6ab26cff4a9e7a94bd0755f1
Author: Mike Reed <reed@google.com>
Date: Fri Jan 12 21:59:34 2018

Revert "relax path bounds check so we can draw larger paths"

This reverts commit e2330261a704e2db762e2de0d297bf8b4dc510f1.

Reason for revert: triggered assert

48.3s	start tiles_rt-8888 gm  bigrect
48.3s	start tiles_rt-8888 gm  big_rrect_circle_aa_effect
48.3s	start tiles_rt-8888 gm  big_rrect_ellipse_aa_effect
../../../src/core/SkScan_Path.cpp(229): fatal error: "assert(leftE->fFirstY <= stop_y)"


Original change's description:
> relax path bounds check so we can draw larger paths
> 
> Bug:800804
> Change-Id: Ief0679de95887d8e11aa5853228c2bdef27d07a2
> Reviewed-on: https://skia-review.googlesource.com/94100
> Reviewed-by: Yuqian Li <liyuqian@google.com>
> Commit-Queue: Mike Reed <reed@google.com>

TBR=egdaniel@google.com,liyuqian@google.com,reed@google.com

Change-Id: I63509625b8afaa2064f0b187c17b73bd7739cdb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 800804
Reviewed-on: https://skia-review.googlesource.com/94481
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>

[modify] https://crrev.com/ff25cdf898e6b95a6ab26cff4a9e7a94bd0755f1/gm/hugepath.cpp
[modify] https://crrev.com/ff25cdf898e6b95a6ab26cff4a9e7a94bd0755f1/src/core/SkScan_AntiPath.cpp

Status: Assigned (was: Untriaged)

Sign in to add a comment