New issue
Advanced search Search tips

Issue 800767 link

Starred by 11 users
Status: Verified
Owner:
orphis@chromium.org
Closed: Sep 10
Cc:
guidou@chromium.org
robertma@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-08-14
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: ----

Blocked on:
issue 591719
issue 852412


Sign in to add a comment

Deprecate and Remove URL.createObjectURL for MediaStream

Project Member Reported by orphis@chromium.org, Jan 10 2018 
Feature description:
Deprecate and Remove URL.createObjectURL for MediaStream in favor of assigning streams to srcObject directly.

Eng owner: orphis@chromium.org
Product owner: juberti@chromium.org

Design doc: https://w3c.github.io/mediacapture-main/

Are you planning on experimenting before launch? No
Any new strings? No
Any implications for Google webservices (i.e. sync, translate)? Yes
Binary size? Not much smaller
Do the existing perf tests exercise all aspects of your new feature(s)? Yes

Comment 1 by orphis@chromium.org, Jan 10 2018

Blockedon: 591719

Comment 2 by orphis@chromium.org, Jan 10 2018

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e16825899d0362f71ff8d7585f54985d2d4c4ef

commit 7e16825899d0362f71ff8d7585f54985d2d4c4ef
Author: Florent Castelli <orphis@chromium.org>
Date: Mon Jan 22 15:24:06 2018

Deprecation warning for URL.createObjectURL with Media Streams

The feature is now deprecated in favor of assigning streams
to HTMLMediaElement.srcObject.

Bug:  800767 
Change-Id: I472cf4b1d52f5bae3a6dcc2344d19df8b142cfbf
Reviewed-on: https://chromium-review.googlesource.com/875988
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530864}
[modify] https://crrev.com/7e16825899d0362f71ff8d7585f54985d2d4c4ef/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html
[modify] https://crrev.com/7e16825899d0362f71ff8d7585f54985d2d4c4ef/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html
[modify] https://crrev.com/7e16825899d0362f71ff8d7585f54985d2d4c4ef/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html
[modify] https://crrev.com/7e16825899d0362f71ff8d7585f54985d2d4c4ef/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/7e16825899d0362f71ff8d7585f54985d2d4c4ef/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp

Comment 4 by orphis@chromium.org, Jan 22 2018

Labels: Merge-Request-65
Status: Started (was: Assigned)

Comment 5 by orphis@chromium.org, Jan 22 2018

Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 23 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 23 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b1288874a0bc189a9d4842776658ff51841d396

commit 5b1288874a0bc189a9d4842776658ff51841d396
Author: Florent Castelli <orphis@chromium.org>
Date: Tue Jan 23 16:41:16 2018

Deprecation warning for URL.createObjectURL with Media Streams

The feature is now deprecated in favor of assigning streams
to HTMLMediaElement.srcObject.

Bug:  800767 
Change-Id: I472cf4b1d52f5bae3a6dcc2344d19df8b142cfbf
Reviewed-on: https://chromium-review.googlesource.com/875988
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530864}(cherry picked from commit 7e16825899d0362f71ff8d7585f54985d2d4c4ef)
Reviewed-on: https://chromium-review.googlesource.com/881503
Cr-Commit-Position: refs/branch-heads/3325@{#29}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/5b1288874a0bc189a9d4842776658ff51841d396/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html
[modify] https://crrev.com/5b1288874a0bc189a9d4842776658ff51841d396/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html
[modify] https://crrev.com/5b1288874a0bc189a9d4842776658ff51841d396/third_party/WebKit/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html
[modify] https://crrev.com/5b1288874a0bc189a9d4842776658ff51841d396/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/5b1288874a0bc189a9d4842776658ff51841d396/third_party/WebKit/Source/modules/mediastream/URLMediaStream.cpp

Comment 8 by phistuck@chromium.org, Mar 3 2018

Labels: Hotlist-Interop

Comment 9 by guidou@chromium.org, Apr 20 2018

Cc: robertma@chromium.org guidou@chromium.org
 Issue 834283  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/703cf3e54c0778e5ef160dce99c8121acb140594

commit 703cf3e54c0778e5ef160dce99c8121acb140594
Author: Florent Castelli <orphis@chromium.org>
Date: Wed May 02 14:04:21 2018

Remove deprecated usage of URL.createObjectURL with MediaStream

Only straightforward usage has been removed, identified with regexp
"URL.createObjectURL.*stream".

Bug:  800767 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I83d563080b2f534e7d9e3062b1633017dc9a01a8
Reviewed-on: https://chromium-review.googlesource.com/878741
Commit-Queue: Florent Castelli <orphis@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555378}
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/chrome/browser/resources/chromeos/user_images_grid.js
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/chrome/browser/resources/feedback/js/take_screenshot.js
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/chrome/common/extensions/docs/examples/api/tabCapture/receiver.js
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/chrome/test/data/extensions/api_test/tab_capture/end_to_end.js
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/chrome/test/data/extensions/api_test/tab_capture/offscreen_test_harness.js
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/chrome/test/data/extensions/api_test/tab_capture/performance.js
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/chrome/test/data/webrtc/webrtc-simulcast.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/content/test/data/media/canvas_capture_color.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/content/test/data/media/getusermedia-depth-capture.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/content/test/data/media/getusermedia-real-webcam.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/content/test/data/media/mediarecorder_test.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/content/test/data/media/peerconnection-call-audio.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/content/test/data/media/peerconnection-call-data.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/content/test/data/media/peerconnection-call.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/content/test/data/media/video_capture_test.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/extensions/test/data/app_view/apitest/media_request/guest.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/native_client_sdk/src/examples/api/video_encode/example.js
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/ppapi/examples/video_effects/video_effects.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/ppapi/examples/video_encode/video_encode.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/third_party/WebKit/LayoutTests/media/video-capture-preview.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/third_party/blink/manual_tests/webaudio/multichannel-mediastreamdestination.html
[modify] https://crrev.com/703cf3e54c0778e5ef160dce99c8121acb140594/ui/webui/resources/cr_elements/chromeos/cr_picture/cr_camera.js
Project Member

Comment 11 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccbdd13284e7a814fe2e92b375328b22b962ebef

commit ccbdd13284e7a814fe2e92b375328b22b962ebef
Author: Florent Castelli <orphis@chromium.org>
Date: Wed May 23 17:44:28 2018

Postpone removal of createObjectUrl with MediaStream to M69

Bug:  800767 
Change-Id: I8d656e4a68f543404620a6eb9608eae3f0f7416a
Reviewed-on: https://chromium-review.googlesource.com/1068869
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561146}
[modify] https://crrev.com/ccbdd13284e7a814fe2e92b375328b22b962ebef/third_party/blink/renderer/core/frame/deprecation.cc

Comment 12 by pedro.pi...@masvoz.net, May 31 2018 

Chrome 67 still shows:
[Deprecation] URL.createObjectURL with media streams is deprecated and will be removed in M68, around July 2018. Please use HTMLMediaElement.srcObject instead. See https://www.chromestatus.com/features/5618491470118912 for more details.

Shouldn't it be changed to reflect version 69?

Comment 13 by guidou@chromium.org, May 31 2018 

Too late to merge that change to M67, which is already stable.

Comment 14 by pedro.pi...@masvoz.net, May 31 2018 

Thanks. Then I assume that M68 will reflect that the change will actually take place in M69, right?

Comment 15 by guidou@chromium.org, May 31 2018 

Correct.

Comment 16 by nacho.gi...@masvoz.net, Jun 27 2018 

Testing with Chrome M69 DEV shows: 

[Deprecation] URL.createObjectURL with media streams is deprecated and will be removed in M69, around September 2018. Please use HTMLMediaElement.srcObject instead.

But the call works anyway. I would have expected it to fail, since in theory URL.createObjectURL with media stream is removed in that version. It is removed in the DEV version or not yet?

Regards

Comment 17 by guidou@chromium.org, Jun 27 2018 

It hasn't been removed yet and M69 is still in development. We will either remove it before it becomes Beta, or will update the message to indicate removal on a later version.

Comment 18 by orphis@chromium.org, Jun 27 2018

Blockedon: 852412
Project Member

Comment 19 by bugdroid1@chromium.org, Aug 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e92d3e56fd27a70ffbdea7d00813c64f6ce13c6c

commit e92d3e56fd27a70ffbdea7d00813c64f6ce13c6c
Author: Guido Urdaneta <guidou@chromium.org>
Date: Mon Aug 13 21:32:47 2018

Fix CreateObjectURL deprecation message.

Removal has been postponed to M71.

Bug:  800767 
Change-Id: I73c3ab4b25ac3856398a639cfb8d5c08fe9aa7cc
Reviewed-on: https://chromium-review.googlesource.com/1172283
Reviewed-by: Florent Castelli <orphis@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582710}
[modify] https://crrev.com/e92d3e56fd27a70ffbdea7d00813c64f6ce13c6c/third_party/blink/renderer/core/frame/deprecation.cc

Comment 20 by guidou@chromium.org, Aug 13

Labels: Merge-Request-69
Requesting merge of r582710 to M69. It fixes the deprecation message to say that URL.createObjectURL() will be removed in M71 instead of M69.
Project Member

Comment 21 by sheriffbot@chromium.org, Aug 13

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 22 by gov...@chromium.org, Aug 13

NextAction: 2018-08-14
r582710  is not yet in canary. Pls update the bug with canary result tomorrow. Also how safe will be to merge to M69?

Comment 23 by monor...@bugs.chromium.org, Aug 14 

The NextAction date has arrived: 2018-08-14

Comment 24 by guidou@chromium.org, Aug 14 

I tested r582710 on Canary 70.0.3522.0 and it works as expected.
The merge is totally safe and recommended.

Comment 25 by gov...@chromium.org, Aug 14

Labels: -Merge-Review-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #24. Please merge ASAP so we can pick it up for this week Beta release. Thank you.
Project Member

Comment 26 by bugdroid1@chromium.org, Aug 14

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bdbda338a7153d9a0da966c4547b4a10d528a9e

commit 2bdbda338a7153d9a0da966c4547b4a10d528a9e
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Aug 14 19:31:09 2018

Fix CreateObjectURL deprecation message.

Removal has been postponed to M71.

Bug:  800767 
Change-Id: I73c3ab4b25ac3856398a639cfb8d5c08fe9aa7cc
Reviewed-on: https://chromium-review.googlesource.com/1172283
Reviewed-by: Florent Castelli <orphis@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#582710}(cherry picked from commit e92d3e56fd27a70ffbdea7d00813c64f6ce13c6c)
Reviewed-on: https://chromium-review.googlesource.com/1174492
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#623}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/2bdbda338a7153d9a0da966c4547b4a10d528a9e/third_party/blink/renderer/core/frame/deprecation.cc

Comment 27 by foolip@chromium.org, Aug 27

Labels: Pri-2
Project Member

Comment 28 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d38023cc2b6816e5c2d5d4f1d290306de3d01a70

commit d38023cc2b6816e5c2d5d4f1d290306de3d01a70
Author: Florent Castelli <orphis@chromium.org>
Date: Mon Sep 10 10:47:47 2018

Remove deprecated URL.createObjectURL(MediaStream)

Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/tWzutytXsqc/lGaWCFdHAgAJ

Bug:  800767 
Change-Id: Ibb8339e65abdb4cbb91549ffc4e64e18b36a0efd
Reviewed-on: https://chromium-review.googlesource.com/1097413
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589880}
[modify] https://crrev.com/d38023cc2b6816e5c2d5d4f1d290306de3d01a70/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/historical-expected.txt
[modify] https://crrev.com/d38023cc2b6816e5c2d5d4f1d290306de3d01a70/third_party/blink/renderer/core/frame/deprecation.cc
[modify] https://crrev.com/d38023cc2b6816e5c2d5d4f1d290306de3d01a70/third_party/blink/renderer/modules/mediastream/BUILD.gn
[delete] https://crrev.com/57c883df3def61924f73730eb8efb2a12c406107/third_party/blink/renderer/modules/mediastream/url_media_stream.cc
[delete] https://crrev.com/57c883df3def61924f73730eb8efb2a12c406107/third_party/blink/renderer/modules/mediastream/url_media_stream.h
[delete] https://crrev.com/57c883df3def61924f73730eb8efb2a12c406107/third_party/blink/renderer/modules/mediastream/url_media_stream.idl
[modify] https://crrev.com/d38023cc2b6816e5c2d5d4f1d290306de3d01a70/third_party/blink/renderer/modules/modules_idl_files.gni

Comment 29 by orphis@chromium.org, Sep 10

Status: Verified (was: Started)
►

Sign in to add a comment