With the GN check improvements introduced in crbug.com/794926 new issues are being reported for the //third_party/WebKit/* targets (it was previously clean).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e commit f2a1d026361ecb777513d1c6d2ccdb7f36bc574e Author: Daniel Bratell <bratell@opera.com> Date: Fri Oct 26 13:21:07 2018 Making it (almost) possible to gn check blink/public/* Mostly it's about marking includes inside INSIDE_BLINK as // nogncheck Also some added dependencies on for instance //media to cover an include of "media/base/video_rotation.h" and on various mojo headers. There are five errors left which look like real layer violations. Bug: 800764 Change-Id: Ie63283def2dadc6c0b5933175551e9addb9da5ec Reviewed-on: https://chromium-review.googlesource.com/c/1299142 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603072} [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/common/BUILD.gn [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/BUILD.gn [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/common/BUILD.gn [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/file_path_conversion.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/interface_registry.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/modules/service_worker/web_service_worker_request.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/modules/service_worker/web_service_worker_response.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_crypto.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_crypto_key_algorithm_params.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_double_point.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_double_size.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_float_point.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_float_point_3d.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_float_rect.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_float_size.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_media_stream_source.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_point.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_private_ptr.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_rect.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_scroll_into_view_params.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_size.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/platform/web_string.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/web/web_dom_message_event.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/web/web_element_collection.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/web/web_frame_owner_properties.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/web/web_icon_url.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/web/web_performance.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/web/web_range.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/web/web_surrounding_text.h [modify] https://crrev.com/f2a1d026361ecb777513d1c6d2ccdb7f36bc574e/third_party/blink/public/web/web_text_direction.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58b1e50ab47d91f374b75afa2ddd01b7a936295a commit 58b1e50ab47d91f374b75afa2ddd01b7a936295a Author: Daniel Bratell <bratell@opera.com> Date: Sun Oct 28 09:06:40 2018 Remove WebThread code violating dependency rules from blink/public blink/public can't depend on internal blink code but luckily the code that was violating this was unused so it could just be deleted. Bug: 800764 Change-Id: Id487e43362931677e93e15d736e7e74922103be0 Reviewed-on: https://chromium-review.googlesource.com/c/1301522 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603369} [modify] https://crrev.com/58b1e50ab47d91f374b75afa2ddd01b7a936295a/third_party/blink/public/platform/scheduler/test/mock_renderer_scheduler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e8ad726c743cf8a9060050b3fef5f801a4c1149 commit 4e8ad726c743cf8a9060050b3fef5f801a4c1149 Author: Daniel Bratell <bratell@opera.com> Date: Sun Oct 28 09:30:22 2018 Remove dependency from blink/public to webrtc/p2p As part of making blink/public's dependencies automatically checked by gn, this is one dependency that was unintended and unnecessary. Moving the dependency into platform/export makes for a cleaner API. Bug: 800764 Change-Id: I4e5f2095bddc4e51de08ed16db51c248884dfd5f Reviewed-on: https://chromium-review.googlesource.com/c/1301468 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603370} [modify] https://crrev.com/4e8ad726c743cf8a9060050b3fef5f801a4c1149/third_party/blink/public/platform/platform.h [modify] https://crrev.com/4e8ad726c743cf8a9060050b3fef5f801a4c1149/third_party/blink/renderer/platform/exported/platform.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6c4973eaf898850816145711c723d1163b377fbd commit 6c4973eaf898850816145711c723d1163b377fbd Author: Daniel Bratell <bratell@opera.com> Date: Sun Oct 28 09:35:22 2018 Delete unused WebCanonicalCookie::BuildCookieLine() The BuildCookieLine() function violated layering by using internal blink types in the blink public API but since it wasn't used anyway it can just be deleted. Also hide the export include from gn since it's an ugly exception, just for debug component builds. Bug: 800764 Change-Id: I7381e68f801e6037667d254d690faa376461e9da Reviewed-on: https://chromium-review.googlesource.com/c/1301469 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603371} [modify] https://crrev.com/6c4973eaf898850816145711c723d1163b377fbd/third_party/blink/public/platform/web_canonical_cookie.h [modify] https://crrev.com/6c4973eaf898850816145711c723d1163b377fbd/third_party/blink/renderer/platform/exported/web_canonical_cookie.cc [modify] https://crrev.com/6c4973eaf898850816145711c723d1163b377fbd/third_party/blink/renderer/platform/exported/web_canonical_cookie_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5444910bc205c0b4610be4095dcfa851ee79e1b9 commit 5444910bc205c0b4610be4095dcfa851ee79e1b9 Author: Daniel Bratell <bratell@opera.com> Date: Mon Oct 29 22:21:43 2018 Moving common_export.h to blink's public folder common_export.h was kept out of public since it was not to be directly included by users of blink's public API but that made dependency tracking unnecessarily complicated and it was included indirectly anyway since many public headers included it. This patch moves the header to blink's public/common. It's still not to be include by external blink API users, but there is also no reason for them to do it. This allows us to remove the dependency hacks and makes dependency checks easier. Bug: 800764 Change-Id: I834f389f9c1871a5e1e66b2fa69477b7eb40e0a0 Reviewed-on: https://chromium-review.googlesource.com/c/1301467 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#603654} [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/common/BUILD.gn [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/common/feature_policy/feature_policy_mojom_traits.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/BUILD.gn [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/DEPS [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/associated_interfaces/associated_interface_provider.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/associated_interfaces/associated_interface_registry.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/blob/blob_utils.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/cache_storage/cache_storage_utils.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/client_hints/client_hints.h [rename] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/common_export.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/device_memory/approximated_device_memory.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/dom_storage/session_storage_namespace_id.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/download/download_stats.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/dwrite_rasterizer_support/dwrite_rasterizer_support.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/experiments/memory_ablation_experiment.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/feature_policy/feature_policy.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/features.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/font_unique_name_lookup/font_table_matcher.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/font_unique_name_lookup/icu_fold_case_util.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/frame/frame_owner_element_type.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/frame/user_activation_state.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/indexeddb/indexeddb_key.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/indexeddb/indexeddb_key_path.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/indexeddb/indexeddb_key_range.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/indexeddb/indexeddb_metadata.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/indexeddb/indexeddb_mojom_traits.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/manifest/manifest.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/manifest/manifest.typemap [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/manifest/manifest_mojom_traits.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/messaging/cloneable_message.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/messaging/message_port_channel.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/messaging/string_message_codec.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/messaging/transferable_message.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/mime_util/mime_util.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/notifications/notification_resources.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/notifications/notification_struct_traits.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/notifications/platform_notification_data.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/origin_policy/origin_policy.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/origin_trials/trial_token.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/origin_trials/trial_token_validator.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/page/launching_process_state.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/privacy_preferences.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/service_worker/service_worker_status_code.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/service_worker/service_worker_type_converters.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/common/service_worker/service_worker_utils.h [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/mojom/BUILD.gn [modify] https://crrev.com/5444910bc205c0b4610be4095dcfa851ee79e1b9/third_party/blink/public/mojom/usb/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1b8e00ce27f85c60cd7f892c0a2553f900bfc83 commit e1b8e00ce27f85c60cd7f892c0a2553f900bfc83 Author: Daniel Bratell <bratell@opera.com> Date: Tue Oct 30 10:23:59 2018 Removing dependency from blink/public to media/base There is no reasonable target to depend on to get access to media/base/video_rotation (depending on all of //media seems to be the only way) so to clean up dependencies from blink/public, forward declare the enum. Better solutions are welcome. Bug: 800764 Change-Id: Ic5079fbb11c6be189a3fc658ea9d10764c0149e5 Reviewed-on: https://chromium-review.googlesource.com/c/1301521 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603854} [modify] https://crrev.com/e1b8e00ce27f85c60cd7f892c0a2553f900bfc83/media/base/video_rotation.h [modify] https://crrev.com/e1b8e00ce27f85c60cd7f892c0a2553f900bfc83/third_party/blink/public/platform/web_video_frame_submitter.h
Comment 1 by msimoni...@opera.com
, Jan 11 2018