New issue
Advanced search Search tips

Issue 800758 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 787464



Sign in to add a comment

Media Engagement Preload: measure load time and lookup time for DB

Project Member Reported by mlamouri@chromium.org, Jan 10 2018

Issue description

DB load time and lookup time can have an impact on Chrome performances. We need to measure these in order to have an idea of the impact and look for improvements.
 
Blocking: 787464
Labels: -OS-Android
Status: Started (was: Assigned)
Labels: ReleaseBlock-Stable
Labels: Merge-Request-65
Requesting merge to M65 as it's only metrics and we would like to be able to catch perf regressions early.
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 23 2018

Labels: -Merge-Request-65 Hotlist-Merge-Approved Merge-Approved-65
Your change meets the bar and is auto-approved for M65. Please go ahead and merge the CL to branch 3325 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 23 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2200cdd0825947a0823092ca0d7cca782900669d

commit 2200cdd0825947a0823092ca0d7cca782900669d
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Jan 23 10:46:21 2018

Media Engagement: add metrics for time to load and time to lookup.

Bug:  800758 
Change-Id: Iea3614bd17563ef0106be267e5f597a79c23bec0
Reviewed-on: https://chromium-review.googlesource.com/874690
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#530477}(cherry picked from commit c7d8bcf2e7e27dc311efbc3ed997c9172a4a450d)
Reviewed-on: https://chromium-review.googlesource.com/880702
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#26}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/2200cdd0825947a0823092ca0d7cca782900669d/chrome/browser/media/media_engagement_preloaded_list.cc
[modify] https://crrev.com/2200cdd0825947a0823092ca0d7cca782900669d/chrome/browser/media/media_engagement_preloaded_list.h
[modify] https://crrev.com/2200cdd0825947a0823092ca0d7cca782900669d/chrome/browser/media/media_engagement_preloaded_list_unittest.cc
[modify] https://crrev.com/2200cdd0825947a0823092ca0d7cca782900669d/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment